Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php namespace Bedard\Shop\Controllers; |
||
| 13 | class Options extends BackendController |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * Create an option with deferred bindings to a product. |
||
| 17 | * |
||
| 18 | * @return Response |
||
| 19 | */ |
||
| 20 | View Code Duplication | public function create() |
|
| 38 | |||
| 39 | /** |
||
| 40 | * Create a value with deferred bindings to an option. |
||
| 41 | * |
||
| 42 | * @return Response |
||
| 43 | */ |
||
| 44 | View Code Duplication | public function createValue() |
|
| 62 | |||
| 63 | /** |
||
| 64 | * Validate an option. |
||
| 65 | * |
||
| 66 | * @return Response |
||
| 67 | */ |
||
| 68 | public function validate() |
||
| 84 | } |
||
| 85 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.