Passed
Pull Request — master (#1393)
by
unknown
10:46
created
src/Exclusion/GroupsExclusionStrategy.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -54,14 +54,14 @@  discard block
 block discarded – undo
54 54
         if ($this->nestedGroups) {
55 55
             $groups = $this->getGroupsFor($navigatorContext);
56 56
 
57
-            if (!$property->groups) {
58
-                return !in_array(self::DEFAULT_GROUP, $groups);
57
+            if ( ! $property->groups) {
58
+                return ! in_array(self::DEFAULT_GROUP, $groups);
59 59
             }
60 60
 
61 61
             return $this->shouldSkipUsingGroups($property, $groups);
62 62
         } else {
63
-            if (!$property->groups) {
64
-                return !isset($this->groups[self::DEFAULT_GROUP]);
63
+            if ( ! $property->groups) {
64
+                return ! isset($this->groups[self::DEFAULT_GROUP]);
65 65
             }
66 66
 
67 67
             foreach ($property->groups as $group) {
@@ -87,14 +87,14 @@  discard block
 block discarded – undo
87 87
 
88 88
     public function getGroupsFor(Context $navigatorContext): array
89 89
     {
90
-        if (!$this->nestedGroups) {
90
+        if ( ! $this->nestedGroups) {
91 91
             return array_keys($this->groups);
92 92
         }
93 93
 
94 94
         $paths = $navigatorContext->getCurrentPath();
95 95
         $groups = $this->groups;
96 96
         foreach ($paths as $index => $path) {
97
-            if (!array_key_exists($path, $groups)) {
97
+            if ( ! array_key_exists($path, $groups)) {
98 98
                 if ($index > 0) {
99 99
                     $groups = [self::DEFAULT_GROUP];
100 100
                 } else {
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
             }
106 106
 
107 107
             $groups = $groups[$path];
108
-            if (!array_filter($groups, 'is_string')) {
108
+            if ( ! array_filter($groups, 'is_string')) {
109 109
                 $groups += [self::DEFAULT_GROUP];
110 110
             }
111 111
         }
Please login to merge, or discard this patch.
src/Metadata/Driver/DocBlockDriver/DocBlockTypeResolver.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public function getPropertyDocblockTypeHint(\ReflectionProperty $reflectionProperty): ?string
55 55
     {
56
-        if (!$reflectionProperty->getDocComment()) {
56
+        if ( ! $reflectionProperty->getDocComment()) {
57 57
             return null;
58 58
         }
59 59
 
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
         // The PhpDoc contains multiple non-null types which produces ambiguity when deserializing.
75 75
         if (count($typesWithoutNull) > 1) {
76
-            $typeHint = implode('|', array_map(static function (TypeNode $type) {
76
+            $typeHint = implode('|', array_map(static function(TypeNode $type) {
77 77
                 return (string) $type;
78 78
             }, $types));
79 79
 
@@ -92,20 +92,20 @@  discard block
 block discarded – undo
92 92
         if ($type instanceof ArrayTypeNode) {
93 93
             $resolvedType = $this->resolveTypeFromTypeNode($type->type, $reflectionProperty);
94 94
 
95
-            return 'array<' . $resolvedType . '>';
95
+            return 'array<'.$resolvedType.'>';
96 96
         }
97 97
 
98 98
         // Generic array syntax: array<Product> | array<\Foo\Bar\Product> | array<int,Product>
99 99
         if ($type instanceof GenericTypeNode) {
100
-            if (!$this->isSimpleType($type->type, 'array')) {
100
+            if ( ! $this->isSimpleType($type->type, 'array')) {
101 101
                 throw new \InvalidArgumentException(sprintf("Can't use non-array generic type %s for collection in %s:%s", (string) $type->type, $reflectionProperty->getDeclaringClass()->getName(), $reflectionProperty->getName()));
102 102
             }
103 103
 
104
-            $resolvedTypes = array_map(function (TypeNode $node) use ($reflectionProperty) {
104
+            $resolvedTypes = array_map(function(TypeNode $node) use ($reflectionProperty) {
105 105
                 return $this->resolveTypeFromTypeNode($node, $reflectionProperty);
106 106
             }, $type->genericTypes);
107 107
 
108
-            return 'array<' . implode(',', $resolvedTypes) . '>';
108
+            return 'array<'.implode(',', $resolvedTypes).'>';
109 109
         }
110 110
 
111 111
         // Primitives and class names: Collection | \Foo\Bar\Product | string
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             return [];
126 126
         }
127 127
 
128
-        return array_merge(...array_map(static function (VarTagValueNode $node) {
128
+        return array_merge(...array_map(static function(VarTagValueNode $node) {
129 129
             if ($node->type instanceof UnionTypeNode) {
130 130
                 return $node->type->types;
131 131
             }
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
      */
144 144
     private function filterNullFromTypes(array $types): array
145 145
     {
146
-        return array_values(array_filter(array_map(function (TypeNode $node) {
146
+        return array_values(array_filter(array_map(function(TypeNode $node) {
147 147
             return $this->isNullType($node) ? null : $node;
148 148
         }, $types)));
149 149
     }
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
      */
187 187
     private function resolveTypeFromTypeNode(TypeNode $typeNode, \ReflectionProperty $reflectionProperty): string
188 188
     {
189
-        if (!($typeNode instanceof IdentifierTypeNode)) {
189
+        if ( ! ($typeNode instanceof IdentifierTypeNode)) {
190 190
             throw new \InvalidArgumentException(sprintf("Can't use unsupported type %s for collection in %s:%s", (string) $typeNode, $reflectionProperty->getDeclaringClass()->getName(), $reflectionProperty->getName()));
191 191
         }
192 192
 
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
             return $typeHint;
200 200
         }
201 201
 
202
-        $expandedClassName = $declaringClass->getNamespaceName() . '\\' . $typeHint;
202
+        $expandedClassName = $declaringClass->getNamespaceName().'\\'.$typeHint;
203 203
         if ($this->isClassOrInterface($expandedClassName)) {
204 204
             return $expandedClassName;
205 205
         }
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 
226 226
     private function endsWith(string $statementClassToCheck, string $typeHintToSearchFor): bool
227 227
     {
228
-        $typeHintToSearchFor = '\\' . $typeHintToSearchFor;
228
+        $typeHintToSearchFor = '\\'.$typeHintToSearchFor;
229 229
 
230 230
         return substr($statementClassToCheck, -strlen($typeHintToSearchFor)) === $typeHintToSearchFor;
231 231
     }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
         preg_match_all(self::GROUP_USE_STATEMENTS_REGEX, $classContents, $foundGroupUseStatements);
247 247
         for ($useStatementIndex = 0; $useStatementIndex < count($foundGroupUseStatements[0]); $useStatementIndex++) {
248 248
             foreach (explode(',', $foundGroupUseStatements[2][$useStatementIndex]) as $singleUseStatement) {
249
-                $foundUseStatements[] = trim($foundGroupUseStatements[1][$useStatementIndex]) . trim($singleUseStatement);
249
+                $foundUseStatements[] = trim($foundGroupUseStatements[1][$useStatementIndex]).trim($singleUseStatement);
250 250
             }
251 251
         }
252 252
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 
280 280
     private function resolveType(string $typeHint, \ReflectionProperty $reflectionProperty): string
281 281
     {
282
-        if (!$this->hasGlobalNamespacePrefix($typeHint) && !$this->isPrimitiveType($typeHint)) {
282
+        if ( ! $this->hasGlobalNamespacePrefix($typeHint) && ! $this->isPrimitiveType($typeHint)) {
283 283
             $typeHint = $this->expandClassNameUsingUseStatements($typeHint, $this->getDeclaringClassOrTrait($reflectionProperty), $reflectionProperty);
284 284
         }
285 285
 
Please login to merge, or discard this patch.
src/GraphNavigator/SerializationGraphNavigator.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 
140 140
         switch ($type['name']) {
141 141
             case 'NULL':
142
-                if (!$this->shouldSerializeNull && !$this->isRootNullAllowed()) {
142
+                if ( ! $this->shouldSerializeNull && ! $this->isRootNullAllowed()) {
143 143
                     throw new NotAcceptableException();
144 144
                 }
145 145
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
             case 'resource':
170 170
                 $msg = 'Resources are not supported in serialized data.';
171 171
                 if (null !== $path = $this->context->getPath()) {
172
-                    $msg .= ' Path: ' . $path;
172
+                    $msg .= ' Path: '.$path;
173 173
                 }
174 174
 
175 175
                 throw new RuntimeException($msg);
@@ -235,8 +235,8 @@  discard block
 block discarded – undo
235 235
                     throw new ExcludedClassException();
236 236
                 }
237 237
 
238
-                if (!is_object($data)) {
239
-                    throw new InvalidArgumentException('Value at ' . $this->context->getPath() . ' is expected to be an object of class ' . $type['name'] . ' but is of type ' . gettype($data));
238
+                if ( ! is_object($data)) {
239
+                    throw new InvalidArgumentException('Value at '.$this->context->getPath().' is expected to be an object of class '.$type['name'].' but is of type '.gettype($data));
240 240
                 }
241 241
 
242 242
                 $this->context->pushClassMetadata($metadata);
Please login to merge, or discard this patch.
src/SerializerBuilder.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
     private function getAccessorStrategy(): AccessorStrategyInterface
218 218
     {
219
-        if (!$this->accessorStrategy) {
219
+        if ( ! $this->accessorStrategy) {
220 220
             $this->accessorStrategy = new DefaultAccessorStrategy($this->expressionEvaluator);
221 221
         }
222 222
 
@@ -260,11 +260,11 @@  discard block
 block discarded – undo
260 260
 
261 261
     public function setCacheDir(string $dir): self
262 262
     {
263
-        if (!is_dir($dir)) {
263
+        if ( ! is_dir($dir)) {
264 264
             $this->createDir($dir);
265 265
         }
266 266
 
267
-        if (!is_writable($dir)) {
267
+        if ( ! is_writable($dir)) {
268 268
             throw new InvalidArgumentException(sprintf('The cache directory "%s" is not writable.', $dir));
269 269
         }
270 270
 
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
     public function setMetadataDirs(array $namespacePrefixToDirMap): self
387 387
     {
388 388
         foreach ($namespacePrefixToDirMap as $dir) {
389
-            if (!is_dir($dir)) {
389
+            if ( ! is_dir($dir)) {
390 390
                 throw new InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));
391 391
             }
392 392
         }
@@ -424,7 +424,7 @@  discard block
 block discarded – undo
424 424
      */
425 425
     public function addMetadataDir(string $dir, string $namespacePrefix = ''): self
426 426
     {
427
-        if (!is_dir($dir)) {
427
+        if ( ! is_dir($dir)) {
428 428
             throw new InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));
429 429
         }
430 430
 
@@ -463,11 +463,11 @@  discard block
 block discarded – undo
463 463
      */
464 464
     public function replaceMetadataDir(string $dir, string $namespacePrefix = ''): self
465 465
     {
466
-        if (!is_dir($dir)) {
466
+        if ( ! is_dir($dir)) {
467 467
             throw new InvalidArgumentException(sprintf('The directory "%s" does not exist.', $dir));
468 468
         }
469 469
 
470
-        if (!isset($this->metadataDirs[$namespacePrefix])) {
470
+        if ( ! isset($this->metadataDirs[$namespacePrefix])) {
471 471
             throw new InvalidArgumentException(sprintf('There is no directory configured for namespace prefix "%s". Please use addMetadataDir() for adding new directories.', $namespacePrefix));
472 472
         }
473 473
 
@@ -566,19 +566,19 @@  discard block
 block discarded – undo
566 566
         if (null !== $this->metadataCache) {
567 567
             $metadataFactory->setCache($this->metadataCache);
568 568
         } elseif (null !== $this->cacheDir) {
569
-            $this->createDir($this->cacheDir . '/metadata');
570
-            $metadataFactory->setCache(new FileCache($this->cacheDir . '/metadata'));
569
+            $this->createDir($this->cacheDir.'/metadata');
570
+            $metadataFactory->setCache(new FileCache($this->cacheDir.'/metadata'));
571 571
         }
572 572
 
573
-        if (!$this->handlersConfigured) {
573
+        if ( ! $this->handlersConfigured) {
574 574
             $this->addDefaultHandlers();
575 575
         }
576 576
 
577
-        if (!$this->listenersConfigured) {
577
+        if ( ! $this->listenersConfigured) {
578 578
             $this->addDefaultListeners();
579 579
         }
580 580
 
581
-        if (!$this->visitorsAdded) {
581
+        if ( ! $this->visitorsAdded) {
582 582
             $this->addDefaultSerializationVisitors();
583 583
             $this->addDefaultDeserializationVisitors();
584 584
         }
@@ -645,12 +645,12 @@  discard block
 block discarded – undo
645 645
     private function decorateAnnotationReader(Reader $annotationReader): Reader
646 646
     {
647 647
         if (null !== $this->cacheDir) {
648
-            $this->createDir($this->cacheDir . '/annotations');
648
+            $this->createDir($this->cacheDir.'/annotations');
649 649
             if (class_exists(FilesystemAdapter::class)) {
650
-                $annotationsCache = new FilesystemAdapter('', 0, $this->cacheDir . '/annotations');
650
+                $annotationsCache = new FilesystemAdapter('', 0, $this->cacheDir.'/annotations');
651 651
                 $annotationReader = new PsrCachedReader($annotationReader, $annotationsCache, $this->debug);
652 652
             } else {
653
-                $annotationsCache = new FilesystemCache($this->cacheDir . '/annotations');
653
+                $annotationsCache = new FilesystemCache($this->cacheDir.'/annotations');
654 654
                 $annotationReader = new CachedReader($annotationReader, $annotationsCache, $this->debug);
655 655
             }
656 656
         }
Please login to merge, or discard this patch.
src/Metadata/Driver/AttributeDriver/AttributeReader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 
56 56
     private function buildAnnotation(array $attributes): ?object
57 57
     {
58
-        if (!isset($attributes[0])) {
58
+        if ( ! isset($attributes[0])) {
59 59
             return null;
60 60
         }
61 61
 
Please login to merge, or discard this patch.
src/Annotation/AnnotationUtilsTrait.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -10,9 +10,9 @@  discard block
 block discarded – undo
10 10
 {
11 11
     private function loadAnnotationParameters(array $vars): void
12 12
     {
13
-        if (!array_key_exists('values', $vars)) {
13
+        if ( ! array_key_exists('values', $vars)) {
14 14
             $values = [];
15
-        } elseif (!is_array($vars['values'])) {
15
+        } elseif ( ! is_array($vars['values'])) {
16 16
             $values = ['value' => $vars['values']];
17 17
         } else {
18 18
             $values = $vars['values'];
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         }
31 31
 
32 32
         foreach ($vars as $key => $value) {
33
-            if (!property_exists(static::class, $key)) {
33
+            if ( ! property_exists(static::class, $key)) {
34 34
                 throw new InvalidArgumentException(sprintf('Unknown property "%s" on annotation "%s".', $key, static::class));
35 35
             }
36 36
 
Please login to merge, or discard this patch.
src/Builder/DefaultDriverFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@
 block discarded – undo
50 50
 
51 51
         $driver = new AnnotationDriver($annotationReader, $this->propertyNamingStrategy, $this->typeParser);
52 52
 
53
-        if (!empty($metadataDirs)) {
53
+        if ( ! empty($metadataDirs)) {
54 54
             $fileLocator = new FileLocator($metadataDirs);
55 55
             $driver = new DriverChain([
56 56
                 new YamlDriver($fileLocator, $this->propertyNamingStrategy, $this->typeParser, $this->expressionEvaluator),
Please login to merge, or discard this patch.
src/Twig/SerializerExtension.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     public function getFilters()
36 36
     {
37 37
         return [
38
-            new TwigFilter($this->serializationFunctionsPrefix . 'serialize', [$this, 'serialize']),
38
+            new TwigFilter($this->serializationFunctionsPrefix.'serialize', [$this, 'serialize']),
39 39
         ];
40 40
     }
41 41
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     public function getFunctions()
48 48
     {
49 49
         return [
50
-            new TwigFunction($this->serializationFunctionsPrefix . 'serialization_context', '\JMS\Serializer\SerializationContext::create'),
50
+            new TwigFunction($this->serializationFunctionsPrefix.'serialization_context', '\JMS\Serializer\SerializationContext::create'),
51 51
         ];
52 52
     }
53 53
 
Please login to merge, or discard this patch.
src/Twig/SerializerRuntimeExtension.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     public function getFilters()
21 21
     {
22 22
         return [
23
-            new TwigFilter($this->serializationFunctionsPrefix . 'serialize', [SerializerRuntimeHelper::class, 'serialize']),
23
+            new TwigFilter($this->serializationFunctionsPrefix.'serialize', [SerializerRuntimeHelper::class, 'serialize']),
24 24
         ];
25 25
     }
26 26
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     public function getFunctions()
33 33
     {
34 34
         return [
35
-            new TwigFunction($this->serializationFunctionsPrefix . 'serialization_context', '\JMS\Serializer\SerializationContext::create'),
35
+            new TwigFunction($this->serializationFunctionsPrefix.'serialization_context', '\JMS\Serializer\SerializationContext::create'),
36 36
         ];
37 37
     }
38 38
 }
Please login to merge, or discard this patch.