Issues in TagAdded.php - Fixed Issues - Inspection of "Improve events, add tests/documentation" - rtconner/laravel-tagging - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — laravel-5 ( 66f120...6eb64b )

by Robert

created 2019-07-03 02:57 UTC

src/Events/TagAdded.php (2 issues)

Labels

Bug 1
Documentation 1

Severity

Minor 1
Unknown 1

<?php namespace Conner\Tagging\Events;

use Conner\Tagging\Taggable;
use Illuminate\Queue\SerializesModels;
use Illuminate\Database\Eloquent\Model;

class TagAdded
{
    use SerializesModels;


    /** @var \Illuminate\Database\Eloquent\Model **/
    public $model;

    /**
     * Create a new event instance.
     *
     * @param Taggable|Model $model
     * @return void
     */
    public function __construct($model)
    {
        $this->model = $model;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }
}

1			<?php namespace Conner\Tagging\Events;
2
3			use Conner\Tagging\Taggable;
4			use Illuminate\Queue\SerializesModels;
5			use Illuminate\Database\Eloquent\Model;
6
7			class TagAdded
8			{
9			use SerializesModels;
			0 ignored issues – show introduced 2019-07-03 02:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The trait `Illuminate\Queue\SerializesModels` requires some properties which are not provided by `Conner\Tagging\Events\TagAdded`: `$id`, `$class`, `$connection`, `$relations` Loading history...
10
11			/ @var \Illuminate\Database\Eloquent\Model /
12			public $model;
13
14			/**
15			* Create a new event instance.
16			*
17			* @param Taggable\|Model $model
18			* @return void
19			*/
20			public function __construct($model)
21			{
22			$this->model = $model;
			0 ignored issues – show Documentation Bug introduced 2019-07-03 02:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$model` can also be of type `Conner\Tagging\Taggable`. However, the property `$model` is declared as type `Illuminate\Database\Eloquent\Model`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
23			}
24			}

rtconner / laravel-tagging

Push — laravel-5 ( 66f120...6eb64b )

src/Events/TagAdded.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like