Installer::getPackage() - Code Metrics - Inspection of "Update tests" - rocketeers/rocketeer - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 6e6bc5...106abb )

by Maxime

created 2016-08-27 12:14 UTC

Installer::getPackage() A

↳ Parent: Installer

Complexity

Conditions	2
Paths	2

Duplication

Lines	0
Ratio	0 %

Size

Total Lines	6
Code Lines	4

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	4
cts	4
cp	1
rs	9.4285
cc	2
eloc	4
nc	2
nop	0
crap	2

<?php

/*
 * This file is part of Rocketeer
 *
 * (c) Maxime Fabre <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 */

namespace Rocketeer\Tasks\Plugins;

use Rocketeer\Tasks\AbstractTask;

/**
 * Installs one or more plugins.
 */
class Installer extends AbstractTask
{
    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Installs one or more plugins';

    /**
     * Whether to run the commands locally
     * or on the server.
     *
     * @var bool
     */
    protected $local = true;

    /**
     * {@inheritdoc}
     */
    public function execute()
    {
        // Get package and destination folder
        $package = $this->getPackage();
        $method = $package ? 'require' : 'install';

        if (!$this->files->has($this->paths->getRocketeerPath().'/composer.json')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->igniter->exportComposerFile();
        }

        // Install plugin
        $this->explainer->line($package ? 'Installing '.$package : 'Setting up Composer');
        $this->runComposerMethod($method, $package);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * @param string          $method
     * @param string|string[] $arguments
     */
    protected function runComposerMethod($method, $arguments)
    {
        $noDev = $method === 'install' ? '--no-dev' : '--update-no-dev';
        $options = [$noDev => '', '--working-dir' => $this->paths->getRocketeerPath()];
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $env = ['COMPOSER_DISCARD_CHANGES' => 1];

        // Install plugin
        $command = $this->composer()->$method($arguments, $options, $env);
        $this->run($this->shellCommand($command));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * @return array|null|string
     */
    protected function getPackage()
    {
        return array_key_exists('package', $this->command->getInput()->getArguments())
            ? $this->command->argument('package')
            : null;
    }
}


1		<?php
2
3		/*
4		* This file is part of Rocketeer
5		*
6		* (c) Maxime Fabre <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*
11		*/
12
13		namespace Rocketeer\Tasks\Plugins;
14
15		use Rocketeer\Tasks\AbstractTask;
16
17		/**
18		* Installs one or more plugins.
19		*/
20		class Installer extends AbstractTask
21		{
22		/**
23		* The console command description.
24		*
25		* @var string
26		*/
27		protected $description = 'Installs one or more plugins';
28
29		/**
30		* Whether to run the commands locally
31		* or on the server.
32		*
33		* @var bool
34		*/
35		protected $local = true;
36
37		/**
38		* {@inheritdoc}
39		*/
40	8	public function execute()
41		{
42		// Get package and destination folder
43	8	$package = $this->getPackage();
44	8	$method = $package ? 'require' : 'install';
45
46	8	if (!$this->files->has($this->paths->getRocketeerPath().'/composer.json')) {
		0 ignored issues – show Documentation Bug introduced 2016-07-30 22:17 UTC by Report Bug Copy Issue Report The method `getRocketeerPath` does not exist on `object<Rocketeer\Services\Environment\Pathfinder>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
47	6	$this->igniter->exportComposerFile();
48	6	}
49
50		// Install plugin
51	8	$this->explainer->line($package ? 'Installing '.$package : 'Setting up Composer');
52	8	$this->runComposerMethod($method, $package);
		0 ignored issues – show Bug introduced 2016-08-27 13:17 UTC by Report Bug Copy Issue Report It seems like `$package` defined by `$this->getPackage()` on line `43` can also be of type `array` or `null`; however, `Rocketeer\Tasks\Plugins\...er::runComposerMethod()` does only seem to accept `string\|array<integer,string>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
53	8	}
54
55		/**
56		* @param string $method
57		* @param string\|string[] $arguments
58		*/
59	8	protected function runComposerMethod($method, $arguments)
60		{
61	8	$noDev = $method === 'install' ? '--no-dev' : '--update-no-dev';
62	8	$options = [$noDev => '', '--working-dir' => $this->paths->getRocketeerPath()];
		0 ignored issues – show Documentation Bug introduced 2016-08-05 15:47 UTC by Report Bug Copy Issue Report The method `getRocketeerPath` does not exist on `object<Rocketeer\Services\Environment\Pathfinder>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
63	8	$env = ['COMPOSER_DISCARD_CHANGES' => 1];
64
65		// Install plugin
66	8	$command = $this->composer()->$method($arguments, $options, $env);
67	8	$this->run($this->shellCommand($command));
		0 ignored issues – show Documentation Bug introduced 2016-07-10 17:10 UTC by Report Bug Copy Issue Report The method `shellCommand` does not exist on `object<Rocketeer\Tasks\Plugins\Installer>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
68	8	}
69
70		/**
71		* @return array\|null\|string
72		*/
73	8	protected function getPackage()
74		{
75	8	return array_key_exists('package', $this->command->getInput()->getArguments())
76	8	? $this->command->argument('package')
77	8	: null;
78		}
79		}
80

rocketeers / rocketeer

Push — develop ( 6e6bc5...106abb )

Installer::getPackage() A

Complexity

Duplication

Size

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like