TranslatedRouteCommandContext::makeLocaleRoutesPath() - Code Metrics - Inspection of "refer to issue #15" - richan-fongdasen/laravel-i18n - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

unknown

created 2020-01-18 16:18 UTC

makeLocaleRoutesPath() A

↳ Parent: TranslatedRouteCommandContext

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace RichanFongdasen\I18n\Traits;

use RichanFongdasen\I18n\I18nService;

trait TranslatedRouteCommandContext
{
    /**
     * Returns whether a given locale is supported.
     *
     * @param string $locale
     *
     * @return bool
     */
    protected function isSupportedLocale($locale)
    {
        return $this->getI18nService()->getLocale($locale) !== null;
    }

    /**
     * @return string[]
     */
    protected function getSupportedLocales()
    {
        return $this->getI18nService()->getLocale()->toArray();
    }

    /**
     * @return \RichanFongdasen\I18n\I18nService
     */
    protected function getI18nService()
    {
        return app(I18nService::class);
    }

    /**
     * @return string
     */
    protected function getBootstrapPath()
    {
        return $this->laravel->bootstrapPath();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param string|null $locale
     *
     * @return string
     */
    protected function makeLocaleRoutesPath($locale = null)

    {
        $path = $this->laravel->getCachedRoutesPath();
        if ($locale === null) {
            return $path;
        }
        $path = substr($path, 0, -4).'_'.$locale.'.php';

        return $path;
    }

    /**
     * The env key that the forced locale for routing is stored in.
     *
     * @return string
     */
    protected function getLocaleEnvKey()
    {
        return I18nService::ENV_ROUTE_KEY;
    }
}


1		<?php
2
3		namespace RichanFongdasen\I18n\Traits;
4
5		use RichanFongdasen\I18n\I18nService;
6
7		trait TranslatedRouteCommandContext
8		{
9		/**
10		* Returns whether a given locale is supported.
11		*
12		* @param string $locale
13		*
14		* @return bool
15		*/
16		protected function isSupportedLocale($locale)
17		{
18		return $this->getI18nService()->getLocale($locale) !== null;
19		}
20
21		/**
22		* @return string[]
23		*/
24		protected function getSupportedLocales()
25		{
26		return $this->getI18nService()->getLocale()->toArray();
27		}
28
29		/**
30		* @return \RichanFongdasen\I18n\I18nService
31		*/
32		protected function getI18nService()
33		{
34		return app(I18nService::class);
35		}
36
37		/**
38		* @return string
39		*/
40		protected function getBootstrapPath()
41		{
42		return $this->laravel->bootstrapPath();
		0 ignored issues – show Bug introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report The property `laravel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43		}
44
45		/**
46		* @param string\|null $locale
47		*
48		* @return string
49		*/
50	View Code Duplication	protected function makeLocaleRoutesPath($locale = null)
		0 ignored issues – show Duplication introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		$path = $this->laravel->getCachedRoutesPath();
53		if ($locale === null) {
54		return $path;
55		}
56		$path = substr($path, 0, -4).'_'.$locale.'.php';
57
58		return $path;
59		}
60
61		/**
62		* The env key that the forced locale for routing is stored in.
63		*
64		* @return string
65		*/
66		protected function getLocaleEnvKey()
67		{
68		return I18nService::ENV_ROUTE_KEY;
69		}
70		}
71

richan-fongdasen / laravel-i18n

Pull Request — master (#16)

makeLocaleRoutesPath() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like