Issues in Mailer.php (master) - Issues in master - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Issues (201)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/Mailer.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript;

use function base64_encode;
use function chunk_split;
use function current;
use function function_exists;
use function implode;
use function is_array;
use function is_file;
use function key;
use function mail;
use function trim;
use function uniqid;

/**
 * parent class to send an mail
 *
 * @since 2.0.0
 *
 * @package Redaxscript
 * @category Mailer
 * @author Henry Ruhs
 */

class Mailer
{
	/**
	 * array of the recipient
	 *
	 * @var array
	 */

	protected $_toArray = [];

	/**
	 * array of the sender
	 *
	 * @var array
	 */

	protected $_fromArray = [];

	/**
	 * subject of the email
	 *
	 * @var string
	 */

	protected $_subject;

	/**
	 * body of the email
	 *
	 * @var string|array
	 */

	protected $_body;

	/**
	 * array of the attachments
	 *
	 * @var array
	 */

	protected $_attachmentArray = [];

	/**
	 * built recipient contents
	 *
	 * @var string
	 */

	protected $_fromString;

	/**
	 * built subject contents
	 *
	 * @var string
	 */

	protected $_subjectString;

	/**
	 * built body contents
	 *
	 * @var string
	 */

	protected $_bodyString;

	/**
	 * built header contents
	 *
	 * @var string
	 */

	protected $_headerString;

	/**
	 * init the class
	 *
	 * @since 2.4.0
	 *
	 * @param array $toArray array of the recipient
	 * @param array $fromArray array of the sender
	 * @param string $subject subject of the email
	 * @param string|array $body body of the email
	 * @param array|null $attachmentArray array of the attachments
	 */

	public function init(array $toArray = [], array $fromArray = [], string $subject = null, $body = null, ?array $attachmentArray = []) : void
	{
		$this->_toArray = $toArray;
		$this->_fromArray = $fromArray;
		$this->_subject = $subject;
		$this->_body = $body;
		$this->_attachmentArray = $attachmentArray;

		/* create as needed */

		$this->_createFromString();
		$this->_createSubjectString();
		$this->_createBodyString();
		$this->_createHeaderString();
	}

	/**
	 * create the recipient contents
	 *
	 * @since 2.0.0
	 */

	protected function _createFromString() : void
	{
		/* create from string */

		$from = current($this->_fromArray);
		$fromName = key($this->_fromArray);

		/* from name fallback */

		if (!$fromName)
		{
			$fromName = $from;
		}
		$this->_fromString = $fromName . ' <' . $from . '>';
	}

	/**
	 * create the subject contents
	 *
	 * @since 2.0.0
	 */

	protected function _createSubjectString() : void
	{
		$settingModel = new Model\Setting();

		/* collect subject string */

		$subject = $settingModel->get('subject');

		/* extended subject string */

		if ($subject)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			$this->_subjectString = $subject;
			if ($this->_subject)
			{
				$this->_subjectString .= $settingModel->get('divider');
			}
		}
		$this->_subjectString .= $this->_subject;
	}

	/**
	 * create the body contents
	 *
	 * @since 2.0.0
	 */

	protected function _createBodyString() : void
	{
		$this->_bodyString = is_array($this->_body) ? implode(PHP_EOL, $this->_body) : $this->_body;
	}

	/**
	 * create the header contents
	 *
	 * @since 2.0.0
	 */

	protected function _createHeaderString() : void
	{
		$settingModel = new Model\Setting();

		/* collect header string */

		$this->_headerString = 'MIME-Version: 1.0' . PHP_EOL;

		/* handle attachment */

		if ($this->_attachmentArray)
		{
			foreach ($this->_attachmentArray as $attachment)
			{
				if (is_file($attachment))
				{
					$content = trim(chunk_split(base64_encode($attachment)));
					$boundary = uniqid();
					$this->_headerString .= 'Content-Type: multipart/mixed; boundary="' . $boundary . '"' . PHP_EOL;
					$this->_headerString .= '--' . $boundary . PHP_EOL;

					/* handle body string */

					if ($this->_bodyString)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
					{
						$this->_headerString .= 'Content-Type: text/html; charset=' . $settingModel->get('charset') . PHP_EOL;
						$this->_headerString .= 'Content-Transfer-Encoding: 8bit' . PHP_EOL;
						$this->_headerString .= $this->_bodyString . PHP_EOL;
						$this->_headerString .= '--' . $boundary . PHP_EOL;

						/* reset body string */

						$this->_bodyString = null;
					}
					$this->_headerString .= 'Content-Type: application/octet-stream; name="' . $attachment . '"' . PHP_EOL;
					$this->_headerString .= 'Content-Transfer-Encoding: base64' . PHP_EOL;
					$this->_headerString .= 'Content-Disposition: attachment; filename="' . $attachment . '"' . PHP_EOL;
					$this->_headerString .= $content . PHP_EOL;
					$this->_headerString .= '--' . $boundary . '--';
				}
			}
		}
		else
		{
			$this->_headerString .= 'Content-Type: text/html; charset=' . $settingModel->get('charset') . PHP_EOL;
		}

		/* collect header string */

		$this->_headerString .= 'From: ' . $this->_fromString . PHP_EOL;
		$this->_headerString .= 'Reply-To: ' . $this->_fromString . PHP_EOL;
		$this->_headerString .= 'Return-Path: ' . $this->_fromString . PHP_EOL;
	}

	/**
	 * send the email
	 *
	 * @since 2.6.2
	 *
	 * @return bool
	 */

	public function send() : bool
	{
		foreach ($this->_toArray as $to)
		{
			if (!function_exists('mail') || !mail($to, $this->_subjectString, $this->_bodyString, $this->_headerString))
			{
				return false;
			}
		}
		return true;
	}
}


1		<?php
2		namespace Redaxscript;
3
4		use function base64_encode;
5		use function chunk_split;
6		use function current;
7		use function function_exists;
8		use function implode;
9		use function is_array;
10		use function is_file;
11		use function key;
12		use function mail;
13		use function trim;
14		use function uniqid;
15
16		/**
17		* parent class to send an mail
18		*
19		* @since 2.0.0
20		*
21		* @package Redaxscript
22		* @category Mailer
23		* @author Henry Ruhs
24		*/
25
26		class Mailer
27		{
28		/**
29		* array of the recipient
30		*
31		* @var array
32		*/
33
34		protected $_toArray = [];
35
36		/**
37		* array of the sender
38		*
39		* @var array
40		*/
41
42		protected $_fromArray = [];
43
44		/**
45		* subject of the email
46		*
47		* @var string
48		*/
49
50		protected $_subject;
51
52		/**
53		* body of the email
54		*
55		* @var string\|array
56		*/
57
58		protected $_body;
59
60		/**
61		* array of the attachments
62		*
63		* @var array
64		*/
65
66		protected $_attachmentArray = [];
67
68		/**
69		* built recipient contents
70		*
71		* @var string
72		*/
73
74		protected $_fromString;
75
76		/**
77		* built subject contents
78		*
79		* @var string
80		*/
81
82		protected $_subjectString;
83
84		/**
85		* built body contents
86		*
87		* @var string
88		*/
89
90		protected $_bodyString;
91
92		/**
93		* built header contents
94		*
95		* @var string
96		*/
97
98		protected $_headerString;
99
100		/**
101		* init the class
102		*
103		* @since 2.4.0
104		*
105		* @param array $toArray array of the recipient
106		* @param array $fromArray array of the sender
107		* @param string $subject subject of the email
108		* @param string\|array $body body of the email
109		* @param array\|null $attachmentArray array of the attachments
110		*/
111
112	4	public function init(array $toArray = [], array $fromArray = [], string $subject = null, $body = null, ?array $attachmentArray = []) : void
113		{
114	4	$this->_toArray = $toArray;
115	4	$this->_fromArray = $fromArray;
116	4	$this->_subject = $subject;
117	4	$this->_body = $body;
118	4	$this->_attachmentArray = $attachmentArray;
119
120		/* create as needed */
121
122	4	$this->_createFromString();
123	4	$this->_createSubjectString();
124	4	$this->_createBodyString();
125	4	$this->_createHeaderString();
126	4	}
127
128		/**
129		* create the recipient contents
130		*
131		* @since 2.0.0
132		*/
133
134	4	protected function _createFromString() : void
135		{
136		/* create from string */
137
138	4	$from = current($this->_fromArray);
139	4	$fromName = key($this->_fromArray);
140
141		/* from name fallback */
142
143	4	if (!$fromName)
144		{
145	2	$fromName = $from;
146		}
147	4	$this->_fromString = $fromName . ' <' . $from . '>';
148	4	}
149
150		/**
151		* create the subject contents
152		*
153		* @since 2.0.0
154		*/
155
156	4	protected function _createSubjectString() : void
157		{
158	4	$settingModel = new Model\Setting();
159
160		/* collect subject string */
161
162	4	$subject = $settingModel->get('subject');
163
164		/* extended subject string */
165
166	4	if ($subject)
		0 ignored issues – show Bug Best Practice introduced 2018-09-04 20:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$subject` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
167		{
168	4	$this->_subjectString = $subject;
169	4	if ($this->_subject)
170		{
171	4	$this->_subjectString .= $settingModel->get('divider');
172		}
173		}
174	4	$this->_subjectString .= $this->_subject;
175	4	}
176
177		/**
178		* create the body contents
179		*
180		* @since 2.0.0
181		*/
182
183	4	protected function _createBodyString() : void
184		{
185	4	$this->_bodyString = is_array($this->_body) ? implode(PHP_EOL, $this->_body) : $this->_body;
186	4	}
187
188		/**
189		* create the header contents
190		*
191		* @since 2.0.0
192		*/
193
194	4	protected function _createHeaderString() : void
195		{
196	4	$settingModel = new Model\Setting();
197
198		/* collect header string */
199
200	4	$this->_headerString = 'MIME-Version: 1.0' . PHP_EOL;
201
202		/* handle attachment */
203
204	4	if ($this->_attachmentArray)
205		{
206	2	foreach ($this->_attachmentArray as $attachment)
207		{
208	2	if (is_file($attachment))
209		{
210	2	$content = trim(chunk_split(base64_encode($attachment)));
211	2	$boundary = uniqid();
212	2	$this->_headerString .= 'Content-Type: multipart/mixed; boundary="' . $boundary . '"' . PHP_EOL;
213	2	$this->_headerString .= '--' . $boundary . PHP_EOL;
214
215		/* handle body string */
216
217	2	if ($this->_bodyString)
		0 ignored issues – show Bug Best Practice introduced 2017-10-31 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->_bodyString` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
218		{
219	2	$this->_headerString .= 'Content-Type: text/html; charset=' . $settingModel->get('charset') . PHP_EOL;
220	2	$this->_headerString .= 'Content-Transfer-Encoding: 8bit' . PHP_EOL;
221	2	$this->_headerString .= $this->_bodyString . PHP_EOL;
222	2	$this->_headerString .= '--' . $boundary . PHP_EOL;
223
224		/* reset body string */
225
226	2	$this->_bodyString = null;
227		}
228	2	$this->_headerString .= 'Content-Type: application/octet-stream; name="' . $attachment . '"' . PHP_EOL;
229	2	$this->_headerString .= 'Content-Transfer-Encoding: base64' . PHP_EOL;
230	2	$this->_headerString .= 'Content-Disposition: attachment; filename="' . $attachment . '"' . PHP_EOL;
231	2	$this->_headerString .= $content . PHP_EOL;
232	2	$this->_headerString .= '--' . $boundary . '--';
233		}
234		}
235		}
236		else
237		{
238	2	$this->_headerString .= 'Content-Type: text/html; charset=' . $settingModel->get('charset') . PHP_EOL;
239		}
240
241		/* collect header string */
242
243	4	$this->_headerString .= 'From: ' . $this->_fromString . PHP_EOL;
244	4	$this->_headerString .= 'Reply-To: ' . $this->_fromString . PHP_EOL;
245	4	$this->_headerString .= 'Return-Path: ' . $this->_fromString . PHP_EOL;
246	4	}
247
248		/**
249		* send the email
250		*
251		* @since 2.6.2
252		*
253		* @return bool
254		*/
255
256	4	public function send() : bool
257		{
258	4	foreach ($this->_toArray as $to)
259		{
260	4	if (!function_exists('mail') \|\| !mail($to, $this->_subjectString, $this->_bodyString, $this->_headerString))
261		{
262		return false;
263		}
264		}
265	4	return true;
266		}
267		}
268

redaxscript / redaxscript

Issues (201)

Security Analysis no request data

includes/Mailer.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like