Issues in SettingTest.php - Fixed Issues - Inspection of "Introduce live reload as option for serving" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1da492...320203 )

by Henry

created 2019-12-14 10:20 UTC

tests/unit/Admin/Controller/SettingTest.php (3 issues)

Labels

Bug 3

Severity

Major 3

Henry Ruhs 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Admin\Controller;

use Redaxscript\Admin;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * SettingTest
 *
 * @since 4.1.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 *
 * @covers Redaxscript\Admin\Controller\Setting
 * @covers Redaxscript\Admin\Controller\ControllerAbstract
 */

class SettingTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 4.1.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$optionArray = $this->getOptionArray();

		$installer = $this->installerFactory();

		$installer->init();
		$installer->rawCreate();
		$installer->insertSettings($optionArray);
	}

	/**
	 * tearDown
	 *
	 * @since 4.1.0
	 */

	public function tearDown() : void
	{
		$this->dropDatabase();

	}

	/**
	 * testUpdate
	 *
	 * @since 4.1.0
	 *
	 * @param array $registryArray
	 * @param array $postArray
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testUpdate(array $registryArray = [], array $postArray = [], string $expect = null) : void
	{
		/* setup */

		$this->_registry->init($registryArray);
		$this->_request->set('post', $postArray);
		$settingController = new Admin\Controller\Setting($this->_registry, $this->_request, $this->_language, $this->_config);

		/* actual */

		$actual = $settingController->process('update');

		/* compare */

		$this->assertEquals($expect, $actual);
	}

	/**
	 * testInvalid
	 *
	 * @since 4.1.0
	 *
	 * @param array $registryArray
	 * @param array $postArray
	 * @param string $expect
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testInvalid(array $registryArray = [], array $postArray = [], string $expect = null) : void
	{
		/* setup */

		$this->_registry->init($registryArray);
		$this->_request->set('post', $postArray);
		$settingController = new Admin\Controller\Setting($this->_registry, $this->_request, $this->_language, $this->_config);

		/* actual */

		$actual = $settingController->process('invalid');

		/* compare */

		$this->assertEquals($expect, $actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Admin\Controller;
3
4			use Redaxscript\Admin;
5			use Redaxscript\Tests\TestCaseAbstract;
6
7			/**
8			* SettingTest
9			*
10			* @since 4.1.0
11			*
12			* @package Redaxscript
13			* @category Tests
14			* @author Henry Ruhs
15			*
16			* @covers Redaxscript\Admin\Controller\Setting
17			* @covers Redaxscript\Admin\Controller\ControllerAbstract
18			*/
19
20			class SettingTest extends TestCaseAbstract
21			{
22			/**
23			* setUp
24			*
25			* @since 4.1.0
26			*/
27
28			public function setUp() : void
29			{
30			parent::setUp();
31			$optionArray = $this->getOptionArray();
			0 ignored issues – show Bug introduced 2019-09-24 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getOptionArray()` does not seem to exist on `object<Redaxscript\Tests...Controller\SettingTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32			$installer = $this->installerFactory();
			0 ignored issues – show Bug introduced 2019-09-24 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `installerFactory()` does not seem to exist on `object<Redaxscript\Tests...Controller\SettingTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
33			$installer->init();
34			$installer->rawCreate();
35			$installer->insertSettings($optionArray);
36			}
37
38			/**
39			* tearDown
40			*
41			* @since 4.1.0
42			*/
43
44			public function tearDown() : void
45			{
46			$this->dropDatabase();
			0 ignored issues – show Bug introduced 2019-09-24 20:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `dropDatabase()` does not seem to exist on `object<Redaxscript\Tests...Controller\SettingTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47			}
48
49			/**
50			* testUpdate
51			*
52			* @since 4.1.0
53			*
54			* @param array $registryArray
55			* @param array $postArray
56			* @param string $expect
57			*
58			* @dataProvider providerAutoloader
59			*/
60
61			public function testUpdate(array $registryArray = [], array $postArray = [], string $expect = null) : void
62			{
63			/* setup */
64
65			$this->_registry->init($registryArray);
66			$this->_request->set('post', $postArray);
67			$settingController = new Admin\Controller\Setting($this->_registry, $this->_request, $this->_language, $this->_config);
68
69			/* actual */
70
71			$actual = $settingController->process('update');
72
73			/* compare */
74
75			$this->assertEquals($expect, $actual);
76			}
77
78			/**
79			* testInvalid
80			*
81			* @since 4.1.0
82			*
83			* @param array $registryArray
84			* @param array $postArray
85			* @param string $expect
86			*
87			* @dataProvider providerAutoloader
88			*/
89
90			public function testInvalid(array $registryArray = [], array $postArray = [], string $expect = null) : void
91			{
92			/* setup */
93
94			$this->_registry->init($registryArray);
95			$this->_request->set('post', $postArray);
96			$settingController = new Admin\Controller\Setting($this->_registry, $this->_request, $this->_language, $this->_config);
97
98			/* actual */
99
100			$actual = $settingController->process('invalid');
101
102			/* compare */
103
104			$this->assertEquals($expect, $actual);
105			}
106			}
107

redaxscript / redaxscript

Push — master ( 1da492...320203 )

tests/unit/Admin/Controller/SettingTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like