Issues in Template.php - Fixed Issues - Inspection of "Transition to PHP8 testing part9" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9cd30...c2303d )

by Henry

created 2021-02-21 12:13 UTC

includes/Detector/Template.php (2 issues)

Labels

Bug 2

Severity

Minor 2

redaxmedia 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Detector;

use Redaxscript\Filter;
use Redaxscript\Model;

/**
 * children class to detect the current template
 *
 * @since 2.0.0
 *
 * @package Redaxscript
 * @category Detector
 * @author Henry Ruhs
 */

class Template extends DetectorAbstract
{
	/**
	 * automate run
	 *
	 * @since 2.1.0
	 */

	public function autorun() : void
	{
		$settingModel = new Model\Setting();
		$contentModel = new Model\Content();
		$specialFilter = new Filter\Special();
		$dbStatus = $this->_registry->get('dbStatus');
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');
		$path = 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml';
		$setupArray =
		[
			'query' => $specialFilter->sanitize($this->_request->getQuery('t')),
			'session' => $this->_request->getSession('template'),
			'contents' => $contentModel->getByTableAndId($lastTable, $lastId)->template,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
			'fallback' => 'default'
		];

		/* detect template */

		$this->_output = $this->_detect('template', $path, $setupArray);
	}
}


1		<?php
2		namespace Redaxscript\Detector;
3
4		use Redaxscript\Filter;
5		use Redaxscript\Model;
6
7		/**
8		* children class to detect the current template
9		*
10		* @since 2.0.0
11		*
12		* @package Redaxscript
13		* @category Detector
14		* @author Henry Ruhs
15		*/
16
17		class Template extends DetectorAbstract
18		{
19		/**
20		* automate run
21		*
22		* @since 2.1.0
23		*/
24
25	7	public function autorun() : void
26		{
27	7	$settingModel = new Model\Setting();
28	7	$contentModel = new Model\Content();
29	7	$specialFilter = new Filter\Special();
30	7	$dbStatus = $this->_registry->get('dbStatus');
31	7	$lastTable = $this->_registry->get('lastTable');
32	7	$lastId = $this->_registry->get('lastId');
33	7	$path = 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml';
34		$setupArray =
35		[
36	7	'query' => $specialFilter->sanitize($this->_request->getQuery('t')),
37	7	'session' => $this->_request->getSession('template'),
38	7	'contents' => $contentModel->getByTableAndId($lastTable, $lastId)->template,
		0 ignored issues – show Bug introduced 2018-12-07 16:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$lastTable` defined by `$this->_registry->get('lastTable')` on line `31` can also be of type `array`; however, `Redaxscript\Model\Content::getByTableAndId()` does only seem to accept `null\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2018-12-07 16:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$lastId` defined by `$this->_registry->get('lastId')` on line `32` can also be of type `array` or `string`; however, `Redaxscript\Model\Content::getByTableAndId()` does only seem to accept `null\|integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
39	7	'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
40	7	'fallback' => 'default'
41		];
42
43		/* detect template */
44
45	7	$this->_output = $this->_detect('template', $path, $setupArray);
46	7	}
47		}
48

redaxscript / redaxscript

Push — master ( e9cd30...c2303d )

includes/Detector/Template.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like