Issues in LanguageTest.php - New Issues - Inspection of "Minor fixes and updated dependencies" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cbd317...231b94 )

by Henry

created 2018-12-15 14:06 UTC

tests/phpunit/LanguageTest.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests;

/**
 * LanguageTest
 *
 * @since 2.2.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 *
 * @covers Redaxscript\Language
 */

class LanguageTest extends TestCaseAbstract
{
	/**
	 * testInit
	 *
	 * @since 3.0.0
	 */

	public function testInit()
	{
		/* setup */

		$this->_language->init('de');
		$this->_language->init('en');

		/* actual */

		$actual = $this->_language;

		/* compare */

		$this->assertInstanceOf('Redaxscript\Language', $actual);
	}

	/**
	 * testGetAndSet
	 *
	 * @since 2.4.0
	 */

	public function testGetAndSet()
	{
		/* setup */

		$this->_language->set('testKey', 'testValue');

		/* actual */

		$actual = $this->_language->get('testKey');

		/* compare */

		$this->assertEquals('testValue', $actual);
	}

	/**
	 * testGetIndex
	 *
	 * @since 2.2.0
	 */

	public function testGetIndex()
	{
		/* actual */

		$actual = $this->_language->get('name', '_package');

		/* compare */

		$this->assertEquals('Redaxscript', $actual);
	}

	/**
	 * testGetAll
	 *
	 * @since 2.2.0
	 */

	public function testGetAll()
	{
		/* actual */

		$actualArray = $this->_language->get();

		/* compare */

		$this->assertArrayHasKey('home', $actualArray);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
	}

	/**
	 * testGetInvalid
	 *
	 * @since 2.2.0
	 */

	public function testGetInvalid()
	{
		/* actual */

		$actual = $this->_language->get('invalidKey');

		/* compare */

		$this->assertNull($actual);
	}
}


1			<?php
2			namespace Redaxscript\Tests;
3
4			/**
5			* LanguageTest
6			*
7			* @since 2.2.0
8			*
9			* @package Redaxscript
10			* @category Tests
11			* @author Henry Ruhs
12			*
13			* @covers Redaxscript\Language
14			*/
15
16			class LanguageTest extends TestCaseAbstract
17			{
18			/**
19			* testInit
20			*
21			* @since 3.0.0
22			*/
23
24			public function testInit()
25			{
26			/* setup */
27
28			$this->_language->init('de');
29			$this->_language->init('en');
30
31			/* actual */
32
33			$actual = $this->_language;
34
35			/* compare */
36
37			$this->assertInstanceOf('Redaxscript\Language', $actual);
38			}
39
40			/**
41			* testGetAndSet
42			*
43			* @since 2.4.0
44			*/
45
46			public function testGetAndSet()
47			{
48			/* setup */
49
50			$this->_language->set('testKey', 'testValue');
51
52			/* actual */
53
54			$actual = $this->_language->get('testKey');
55
56			/* compare */
57
58			$this->assertEquals('testValue', $actual);
59			}
60
61			/**
62			* testGetIndex
63			*
64			* @since 2.2.0
65			*/
66
67			public function testGetIndex()
68			{
69			/* actual */
70
71			$actual = $this->_language->get('name', '_package');
72
73			/* compare */
74
75			$this->assertEquals('Redaxscript', $actual);
76			}
77
78			/**
79			* testGetAll
80			*
81			* @since 2.2.0
82			*/
83
84			public function testGetAll()
85			{
86			/* actual */
87
88			$actualArray = $this->_language->get();
89
90			/* compare */
91
92			$this->assertArrayHasKey('home', $actualArray);
			0 ignored issues – show Bug introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$actualArray` defined by `$this->_language->get()` on line `88` can also be of type `null` or `string`; however, `PHPUnit\Framework\Assert::assertArrayHasKey()` does only seem to accept `array\|object<ArrayAccess>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
93			}
94
95			/**
96			* testGetInvalid
97			*
98			* @since 2.2.0
99			*/
100
101			public function testGetInvalid()
102			{
103			/* actual */
104
105			$actual = $this->_language->get('invalidKey');
106
107			/* compare */
108
109			$this->assertNull($actual);
110			}
111			}
112

redaxscript / redaxscript

Push — master ( cbd317...231b94 )

tests/phpunit/LanguageTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like