Issues in Session.php - Fixed Issues - Inspection of "Modernize Singleton class" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7de195...5f1ca1 )

by Henry

created 2021-02-21 20:51 UTC

includes/Bootstrap/Session.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Bootstrap;

use Redaxscript\Server;
use function session_id;
use function session_regenerate_id;
use function session_set_cookie_params;
use function session_start;
use function session_status;

/**
 * children class to boot the session
 *
 * @since 3.1.0
 *
 * @package Redaxscript
 * @category Bootstrap
 * @author Henry Ruhs
 */

class Session extends BootstrapAbstract
{
	/**
	 * automate run
	 *
	 * @since 3.1.0
	 */

	public function autorun() : void
	{
		$protocol = new Server\Protocol($this->_request);
		session_set_cookie_params(
		[
			'samesite' => 'strict',
			'secure' => $protocol->getOutput() === 'https'
		]);
		session_start();
		$this->_request->refreshSession();

		/* session guard */

		if (!$this->_request->getSession('sessionGuard'))
		{
			$this->_request->setSession('sessionGuard', session_regenerate_id());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}
		$this->_registry->set('sessionId', session_id());
		$this->_registry->set('sessionStatus', session_status());
	}
}


1		<?php
2		namespace Redaxscript\Bootstrap;
3
4		use Redaxscript\Server;
5		use function session_id;
6		use function session_regenerate_id;
7		use function session_set_cookie_params;
8		use function session_start;
9		use function session_status;
10
11		/**
12		* children class to boot the session
13		*
14		* @since 3.1.0
15		*
16		* @package Redaxscript
17		* @category Bootstrap
18		* @author Henry Ruhs
19		*/
20
21		class Session extends BootstrapAbstract
22		{
23		/**
24		* automate run
25		*
26		* @since 3.1.0
27		*/
28
29	1	public function autorun() : void
30		{
31	1	$protocol = new Server\Protocol($this->_request);
32	1	session_set_cookie_params(
33		[
34	1	'samesite' => 'strict',
35	1	'secure' => $protocol->getOutput() === 'https'
36		]);
37	1	session_start();
38	1	$this->_request->refreshSession();
39
40		/* session guard */
41
42	1	if (!$this->_request->getSession('sessionGuard'))
43		{
44	1	$this->_request->setSession('sessionGuard', session_regenerate_id());
		0 ignored issues – show Documentation introduced 2018-11-15 22:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\session_regenerate_id()` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45		}
46	1	$this->_registry->set('sessionId', session_id());
47	1	$this->_registry->set('sessionStatus', session_status());
48	1	}
49		}
50

redaxscript / redaxscript

Push — master ( 7de195...5f1ca1 )

includes/Bootstrap/Session.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like