Issues in Common.php - All Issues - Inspection of "Modernize Singleton class" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7de195...5f1ca1 )

by Henry

created 2021-02-21 20:51 UTC

includes/Admin/Controller/Common.php (29 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Admin\Controller;

use Redaxscript\Admin;
use function method_exists;

/**
 * children class to handle common
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Controller
 * @author Henry Ruhs
 */

class Common extends ControllerAbstract
{
	/**
	 * process the class
	 *
	 * @since 4.0.0
	 *
	 * @param string $action action to process
	 *
	 * @return string
	 */

	public function process(string $action = null) : string
	{
		$table = $this->_registry->get('tableParameter');
		$id = $this->_registry->get('idParameter');
		$alias = $this->_registry->get('aliasParameter');

		/* handle publish */

		if ($action === 'publish')
		{
			if ($this->_publish($table, $id))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				return $this->_success(
				[
					'route' => $this->_getRoute($table, $id),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle unpublish */

		if ($action === 'unpublish')
		{
			if ($this->_unpublish($table, $id))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				return $this->_success(
				[
					'route' => $this->_getRoute($table, $id),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle enable */

		if ($action === 'enable')
		{
			if ($this->_enable($table, $id))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				return $this->_success(
				[
					'route' => $this->_getRoute($table, $id),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle disable */

		if ($action === 'disable')
		{
			if ($this->_disable($table, $id))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				return $this->_success(
				[
					'route' => $this->_getRoute($table, $id),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle install */

		if ($action === 'install')
		{
			if ($this->_install($table, $alias))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				$moduleModel = new Admin\Model\Module();
				$moduleId = $moduleModel->getByAlias($alias)->id;
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
				return $this->_success(
				[
					'route' => $this->_getRoute($table, $moduleId),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle uninstall */

		if ($action === 'uninstall')
		{
			if ($this->_uninstall($table, $alias))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				return $this->_success(
				[
					'route' => $this->_getRoute($table),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle delete */

		if ($action === 'delete')
		{
			if ($this->_delete($table, $id))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			{
				return $this->_success(
				[
					'route' => $this->_getRoute($table),
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
					'timeout' => 0
				]);
			}
		}

		/* handle error */

		return $this->_error(
		[
			'route' => $this->_getRoute($table)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
		]);
	}

	/**
	 * publish the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param int $id identifier of the item
	 *
	 * @return bool
	 */

	protected function _publish(string $table = null, int $id = null) : bool
	{
		if ($table === 'categories')
		{
			$categoryModel = new Admin\Model\Category();
			$articleModel = new Admin\Model\Article();
			$commentModel = new Admin\Model\Comment();
			return $categoryModel->publishById($id) && $articleModel->publishByCategory($id) && $commentModel->publishByCategory($id);
		}
		if ($table === 'articles')
		{
			$articleModel = new Admin\Model\Article();
			$commentModel = new Admin\Model\Comment();
			return $articleModel->publishById($id) && $commentModel->publishByArticle($id);
		}
		if ($table === 'extras')
		{
			$extraModel = new Admin\Model\Extra();
			return $extraModel->publishById($id);
		}
		if ($table === 'comments')
		{
			$commentModel = new Admin\Model\Comment();
			return $commentModel->publishById($id);
		}
		return false;
	}

	/**
	 * unpublish the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param int $id identifier of the item
	 *
	 * @return bool
	 */

	protected function _unpublish(string $table = null, int $id = null) : bool
	{
		if ($table === 'categories')
		{
			$categoryModel = new Admin\Model\Category();
			$articleModel = new Admin\Model\Article();
			$commentModel = new Admin\Model\Comment();
			return $categoryModel->unpublishById($id) && $articleModel->unpublishByCategory($id) && $commentModel->unpublishByCategory($id);
		}
		if ($table === 'articles')
		{
			$articleModel = new Admin\Model\Article();
			$commentModel = new Admin\Model\Comment();
			return $articleModel->unpublishById($id) && $commentModel->unpublishByArticle($id);
		}
		if ($table === 'extras')
		{
			$extraModel = new Admin\Model\Extra();
			return $extraModel->unpublishById($id);
		}
		if ($table === 'comments')
		{
			$commentModel = new Admin\Model\Comment();
			return $commentModel->unpublishById($id);
		}
		return false;
	}

	/**
	 * enable the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param int $id identifier of the item
	 *
	 * @return bool
	 */

	protected function _enable(string $table = null, int $id = null) : bool
	{
		if ($table === 'groups')
		{
			$groupModel = new Admin\Model\Group();
			return $groupModel->enableById($id);
		}
		if ($table === 'users')
		{
			$userModel = new Admin\Model\User();
			return $userModel->enableById($id);
		}
		if ($table === 'modules')
		{
			$moduleModel = new Admin\Model\Module();
			return $moduleModel->enableById($id);
		}
		return false;
	}

	/**
	 * disable the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param int $id identifier of the item
	 *
	 * @return bool
	 */

	protected function _disable(string $table = null, int $id = null) : bool
	{
		if ($table === 'groups')
		{
			$groupModel = new Admin\Model\Group();
			return $groupModel->disableById($id);
		}
		if ($table === 'users')
		{
			$userModel = new Admin\Model\User();
			return $userModel->disableById($id);
		}
		if ($table === 'modules')
		{
			$moduleModel = new Admin\Model\Module();
			return $moduleModel->disableById($id);
		}
		return false;
	}

	/**
	 * install the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param string $alias alias of the item
	 *
	 * @return bool
	 */

	protected function _install(string $table = null, string $alias = null) : bool
	{
		if ($table === 'modules')
		{
			$moduleClass = 'Redaxscript\Modules\\' . $alias . '\\' . $alias;
			if (method_exists($moduleClass, 'install'))
			{
				$module = new $moduleClass($this->_registry, $this->_request, $this->_language, $this->_config);
				return $module->install();
			}
		}
		return false;
	}

	/**
	 * uninstall the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param string $alias alias of the item
	 *
	 * @return bool
	 */

	protected function _uninstall(string $table = null, string $alias = null) : bool
	{
		if ($table === 'modules')
		{
			$moduleClass = 'Redaxscript\Modules\\' . $alias . '\\' . $alias;
			if (method_exists($moduleClass, 'uninstall'))
			{
				$module = new $moduleClass($this->_registry, $this->_request, $this->_language, $this->_config);
				return $module->uninstall();
			}
		}
		return false;
	}

	/**
	 * delete the item
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param int $id identifier of the item
	 *
	 * @return bool
	 */

	protected function _delete(string $table = null, int $id = null) : bool
	{
		if ($table === 'categories')
		{
			$categoryModel = new Admin\Model\Category();
			$articleModel = new Admin\Model\Article();
			$commentModel = new Admin\Model\Comment();
			return $commentModel->deleteByCategory($id) && $articleModel->deleteByCategory($id) && $categoryModel->deleteById($id);
		}
		if ($table === 'articles')
		{
			$articleModel = new Admin\Model\Article();
			$commentModel = new Admin\Model\Comment();
			return $commentModel->deleteByArticle($id) && $articleModel->deleteById($id);
		}
		if ($table === 'extras')
		{
			$extraModel = new Admin\Model\Extra();
			return $extraModel->deleteById($id);
		}
		if ($table === 'comments')
		{
			$commentModel = new Admin\Model\Comment();
			return $commentModel->deleteById($id);
		}
		if ($table === 'groups')
		{
			$groupModel = new Admin\Model\Group();
			return $groupModel->deleteById($id);
		}
		if ($table === 'users')
		{
			$userModel = new Admin\Model\User();
			return $userModel->deleteById($id);
		}
		return false;
	}

	/**
	 * get the route
	 *
	 * @since 4.0.0
	 *
	 * @param string $table name of the table
	 * @param int $id identifier of the item
	 *
	 * @return string
	 */

	protected function _getRoute(string $table = null, int $id = null) : string
	{
		if ($this->_registry->get($table . 'Edit') && $table)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
		{
			if ($id)
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
			{
				return 'admin/view/' . $table . '#row-' . $id;
			}
			return 'admin/view/' . $table;
		}
		return 'admin';
	}
}


1			<?php
2			namespace Redaxscript\Admin\Controller;
3
4			use Redaxscript\Admin;
5			use function method_exists;
6
7			/**
8			* children class to handle common
9			*
10			* @since 4.0.0
11			*
12			* @package Redaxscript
13			* @category Controller
14			* @author Henry Ruhs
15			*/
16
17			class Common extends ControllerAbstract
18			{
19			/**
20			* process the class
21			*
22			* @since 4.0.0
23			*
24			* @param string $action action to process
25			*
26			* @return string
27			*/
28
29			public function process(string $action = null) : string
30			{
31			$table = $this->_registry->get('tableParameter');
32			$id = $this->_registry->get('idParameter');
33			$alias = $this->_registry->get('aliasParameter');
34
35			/* handle publish */
36
37			if ($action === 'publish')
38			{
39			if ($this->_publish($table, $id))
			0 ignored issues – show Bug introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$table` defined by `$this->_registry->get('tableParameter')` on line `31` can also be of type `array`; however, `Redaxscript\Admin\Controller\Common::_publish()` does only seem to accept `null\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$id` defined by `$this->_registry->get('idParameter')` on line `32` can also be of type `array` or `string`; however, `Redaxscript\Admin\Controller\Common::_publish()` does only seem to accept `null\|integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...

redaxscript / redaxscript

Push — master ( 7de195...5f1ca1 )

includes/Admin/Controller/Common.php (29 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like