Issues in FileTest.php - All Issues - Inspection of "Develop (#598)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ea243...da58d4 )

by Henry

created 2019-05-29 16:08 UTC

tests/unit/Filesystem/FileTest.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests\Filesystem;

use org\bovigo\vfs\vfsStream as Stream;
use Redaxscript\Filesystem;
use Redaxscript\Tests\TestCaseAbstract;

/**
 * FileTest
 *
 * @since 3.2.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 *
 * @covers Redaxscript\Filesystem\File
 */

class FileTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 3.2.0
	 */

	public function setUp() : void
	{
		Stream::setup('root', 0777, $this->getJSON('tests' . DIRECTORY_SEPARATOR. 'unit-provider' . DIRECTORY_SEPARATOR. 'Filesystem' . DIRECTORY_SEPARATOR. 'FilesystemTest_setUp.json'));
	}

	/**
	 * testCreate
	 *
	 * @since 3.2.0
	 *
	 * @param string $root
	 * @param bool $recursive
	 * @param string $file
	 * @param array $expectArray
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testCreate(string $root = null, bool $recursive = null, string $file = null, array $expectArray = []) : void
	{
		/* setup */

		$filesystem = new Filesystem\File();
		$filesystem->init(Stream::url($root), $recursive);

		$filesystem->createFile($file);

		/* actual */

		$actualArray = $filesystem->getArray();

		/* compare */

		$this->assertEquals($expectArray, $actualArray);
	}

	/**
	 * testReadAndWrite
	 *
	 * @since 3.2.0
	 *
	 * @param string $root
	 * @param bool $recursive
	 * @param string $file
	 * @param string $content
	 * @param array $expectArray
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testReadAndWrite(string $root = null, bool $recursive = null, string $file = null, string $content = null, array $expectArray = []) : void
	{
		/* setup */

		$filesystem = new Filesystem\File();
		$filesystem->init(Stream::url($root), $recursive);

		$filesystem->writeFile($file, $content);

		/* actual */

		$actualArray =
		[
			$filesystem->readFile($file),
			$filesystem->renderFile($file)
		];

		/* compare */

		$this->assertEquals($expectArray, $actualArray);
	}

	/**
	 * testRemove
	 *
	 * @since 3.2.0
	 *
	 * @param string $root
	 * @param bool $recursive
	 * @param string $file
	 * @param array $expectArray
	 *
	 * @dataProvider providerAutoloader
	 */

	public function testRemove(string $root = null, bool $recursive = null, string $file = null, array $expectArray = []) : void
	{
		/* setup */

		$filesystem = new Filesystem\File();
		$filesystem->init(Stream::url($root), $recursive);

		$filesystem->removeFile($file);

		/* actual */

		$actualArray = $filesystem->getArray();

		/* compare */

		$this->assertEquals($expectArray, $actualArray);
	}
}


1			<?php
2			namespace Redaxscript\Tests\Filesystem;
3
4			use org\bovigo\vfs\vfsStream as Stream;
5			use Redaxscript\Filesystem;
6			use Redaxscript\Tests\TestCaseAbstract;
7
8			/**
9			* FileTest
10			*
11			* @since 3.2.0
12			*
13			* @package Redaxscript
14			* @category Tests
15			* @author Henry Ruhs
16			*
17			* @covers Redaxscript\Filesystem\File
18			*/
19
20			class FileTest extends TestCaseAbstract
21			{
22			/**
23			* setUp
24			*
25			* @since 3.2.0
26			*/
27
28			public function setUp() : void
29			{
30			Stream::setup('root', 0777, $this->getJSON('tests' . DIRECTORY_SEPARATOR. 'unit-provider' . DIRECTORY_SEPARATOR. 'Filesystem' . DIRECTORY_SEPARATOR. 'FilesystemTest_setUp.json'));
31			}
32
33			/**
34			* testCreate
35			*
36			* @since 3.2.0
37			*
38			* @param string $root
39			* @param bool $recursive
40			* @param string $file
41			* @param array $expectArray
42			*
43			* @dataProvider providerAutoloader
44			*/
45
46			public function testCreate(string $root = null, bool $recursive = null, string $file = null, array $expectArray = []) : void
47			{
48			/* setup */
49
50			$filesystem = new Filesystem\File();
51			$filesystem->init(Stream::url($root), $recursive);
			0 ignored issues – show Bug introduced 2017-10-31 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$recursive` defined by parameter `$recursive` on line 46 can also be of type `null`; however, `Redaxscript\Filesystem\Filesystem::init()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
52			$filesystem->createFile($file);
53
54			/* actual */
55
56			$actualArray = $filesystem->getArray();
57
58			/* compare */
59
60			$this->assertEquals($expectArray, $actualArray);
61			}
62
63			/**
64			* testReadAndWrite
65			*
66			* @since 3.2.0
67			*
68			* @param string $root
69			* @param bool $recursive
70			* @param string $file
71			* @param string $content
72			* @param array $expectArray
73			*
74			* @dataProvider providerAutoloader
75			*/
76
77			public function testReadAndWrite(string $root = null, bool $recursive = null, string $file = null, string $content = null, array $expectArray = []) : void
78			{
79			/* setup */
80
81			$filesystem = new Filesystem\File();
82			$filesystem->init(Stream::url($root), $recursive);
			0 ignored issues – show Bug introduced 2017-10-31 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$recursive` defined by parameter `$recursive` on line 77 can also be of type `null`; however, `Redaxscript\Filesystem\Filesystem::init()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
83			$filesystem->writeFile($file, $content);
84
85			/* actual */
86
87			$actualArray =
88			[
89			$filesystem->readFile($file),
90			$filesystem->renderFile($file)
91			];
92
93			/* compare */
94
95			$this->assertEquals($expectArray, $actualArray);
96			}
97
98			/**
99			* testRemove
100			*
101			* @since 3.2.0
102			*
103			* @param string $root
104			* @param bool $recursive
105			* @param string $file
106			* @param array $expectArray
107			*
108			* @dataProvider providerAutoloader
109			*/
110
111			public function testRemove(string $root = null, bool $recursive = null, string $file = null, array $expectArray = []) : void
112			{
113			/* setup */
114
115			$filesystem = new Filesystem\File();
116			$filesystem->init(Stream::url($root), $recursive);
			0 ignored issues – show Bug introduced 2017-10-31 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$recursive` defined by parameter `$recursive` on line 111 can also be of type `null`; however, `Redaxscript\Filesystem\Filesystem::init()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
117			$filesystem->removeFile($file);
118
119			/* actual */
120
121			$actualArray = $filesystem->getArray();
122
123			/* compare */
124
125			$this->assertEquals($expectArray, $actualArray);
126			}
127			}
128

redaxscript / redaxscript

Push — master ( 0ea243...da58d4 )

tests/unit/Filesystem/FileTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like