Completed
Push — master ( 0ea243...da58d4 )
by Henry
10:25 queued 33s
created

includes/Detector/Template.php (2 issues)

call_checks.maybe_mismatching_type_passed_with_def

Bug Minor

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
namespace Redaxscript\Detector;
3
4
use Redaxscript\Model;
5
6
/**
7
 * children class to detect the current template
8
 *
9
 * @since 2.0.0
10
 *
11
 * @package Redaxscript
12
 * @category Detector
13
 * @author Henry Ruhs
14
 */
15
16
class Template extends DetectorAbstract
17
{
18
	/**
19
	 * automate run
20
	 *
21
	 * @since 2.1.0
22
	 */
23
24 7
	public function autorun() : void
25
	{
26 7
		$settingModel = new Model\Setting();
27 7
		$contentModel = new Model\Content();
28 7
		$dbStatus = $this->_registry->get('dbStatus');
29 7
		$lastTable = $this->_registry->get('lastTable');
30 7
		$lastId = $this->_registry->get('lastId');
31 7
		$path = 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml';
32
		$setupArray =
33
		[
34 7
			'query' => $this->_request->getQuery('t'),
35 7
			'session' => $this->_request->getSession('template'),
36 7
			'contents' => $contentModel->getByTableAndId($lastTable, $lastId)->template,
0 ignored issues
show
It seems like $lastTable defined by $this->_registry->get('lastTable') on line 29 can also be of type array; however, Redaxscript\Model\Content::getByTableAndId() does only seem to accept null|string, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
It seems like $lastId defined by $this->_registry->get('lastId') on line 30 can also be of type array or string; however, Redaxscript\Model\Content::getByTableAndId() does only seem to accept null|integer, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
37 7
			'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
38 7
			'fallback' => 'default'
39
		];
40
41
		/* detect template */
42
43 7
		$this->_output = $this->_detect('template', $path, $setupArray);
44 7
	}
45
}
46