Issues in Restore.php - New Issues - Inspection of "Develop (#600)" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da58d4...61a0f7 )

by Henry

created 2019-06-22 15:37 UTC

includes/Console/Command/Restore.php (8 issues)

Showing only issues like (Show All)

Check for loose comparison of strings.

Best Practice Bug Major

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Console\Command;

use Redaxscript\Console\Parser;
use Redaxscript\Filesystem;
use function exec;
use function is_file;

/**
 * children class to execute the restore command
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Console
 * @author Henry Ruhs
 */

class Restore extends CommandAbstract
{
	/**
	 * array of the command
	 *
	 * @var array
	 */

	protected $_commandArray =
	[
		'restore' =>
		[
			'description' => 'Restore command',
			'argumentArray' =>
			[
				'database' =>
				[
					'description' => 'Restore the database',
					'optionArray' =>
					[
						'directory' =>
						[
							'description' => 'Required directory'
						],
						'file' =>
						[
							'description' => 'Required file'
						]
					]
				]
			]
		]
	];

	/**
	 * run the command
	 *
	 * @since 3.0.0
	 *
	 * @param string $mode name of the mode
	 *
	 * @return string|null
	 */

	public function run(string $mode = null) : ?string
	{
		$parser = new Parser($this->_request);
		$parser->init($mode);

		/* run command */

		$argumentKey = $parser->getArgument(1);
		$haltOnError = (bool)$parser->getOption('halt-on-error');
		if ($argumentKey === 'database')
		{
			return $this->_database($parser->getOptionArray()) ? $this->success() : $this->error($haltOnError);
		}
		return $this->getHelp();
	}

	/**
	 * restore the database
	 *
	 * @since 3.0.0
	 *
	 * @param array $optionArray
	 *
	 * @return bool
	 */

	protected function _database(array $optionArray = []) : bool
	{
		$dbType = $this->_config->get('dbType');
		$dbHost = $this->_config->get('dbHost');
		$dbName = $this->_config->get('dbName');
		$dbUser = $this->_config->get('dbUser');
		$dbPassword = $this->_config->get('dbPassword');
		$directory = $this->prompt('directory', $optionArray);
		$file = $this->prompt('file', $optionArray);

		/* restore filesystem */

		$backupFilesystem = new Filesystem\Directory();
		$backupFilesystem->init($directory);

		/* restore */

		if (is_file($directory . DIRECTORY_SEPARATOR . $file))
		{
			$command = ':';
			$content = $backupFilesystem->readFile($file);
			if ($dbType === 'mysql' && $dbHost && $dbName && $dbUser && $dbPassword)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			{
				$command = $content . ' | mysql --host=' . $dbHost . ' --user=' . $dbUser . ' --password=' . $dbPassword . ' ' . $dbName;
			}
			if ($dbType === 'pgsql' && $dbHost && $dbName && $dbUser && $dbPassword)
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			{
				$command = 'PGPASSWORD=' . $dbPassword . ' ' . $content . ' | psql --host=' . $dbHost . ' --username=' . $dbUser . ' ' . $dbName;
			}
			if ($dbType === 'sqlite' && is_file($dbHost))
			{
				$command = 'echo ' . $content . ' > ' . $dbHost;
			}
			exec($command, $outputArray, $error);
			return $error === 0;
		}
		return false;
	}
}


1		<?php
2		namespace Redaxscript\Console\Command;
3
4		use Redaxscript\Console\Parser;
5		use Redaxscript\Filesystem;
6		use function exec;
7		use function is_file;
8
9		/**
10		* children class to execute the restore command
11		*
12		* @since 3.0.0
13		*
14		* @package Redaxscript
15		* @category Console
16		* @author Henry Ruhs
17		*/
18
19		class Restore extends CommandAbstract
20		{
21		/**
22		* array of the command
23		*
24		* @var array
25		*/
26
27		protected $_commandArray =
28		[
29		'restore' =>
30		[
31		'description' => 'Restore command',
32		'argumentArray' =>
33		[
34		'database' =>
35		[
36		'description' => 'Restore the database',
37		'optionArray' =>
38		[
39		'directory' =>
40		[
41		'description' => 'Required directory'
42		],
43		'file' =>
44		[
45		'description' => 'Required file'
46		]
47		]
48		]
49		]
50		]
51		];
52
53		/**
54		* run the command
55		*
56		* @since 3.0.0
57		*
58		* @param string $mode name of the mode
59		*
60		* @return string\|null
61		*/
62
63	2	public function run(string $mode = null) : ?string
64		{
65	2	$parser = new Parser($this->_request);
66	2	$parser->init($mode);
67
68		/* run command */
69
70	2	$argumentKey = $parser->getArgument(1);
71	2	$haltOnError = (bool)$parser->getOption('halt-on-error');
72	2	if ($argumentKey === 'database')
73		{
74	1	return $this->_database($parser->getOptionArray()) ? $this->success() : $this->error($haltOnError);
75		}
76	1	return $this->getHelp();
77		}
78
79		/**
80		* restore the database
81		*
82		* @since 3.0.0
83		*
84		* @param array $optionArray
85		*
86		* @return bool
87		*/
88
89	1	protected function _database(array $optionArray = []) : bool
90		{
91	1	$dbType = $this->_config->get('dbType');
92	1	$dbHost = $this->_config->get('dbHost');
93	1	$dbName = $this->_config->get('dbName');
94	1	$dbUser = $this->_config->get('dbUser');
95	1	$dbPassword = $this->_config->get('dbPassword');
96	1	$directory = $this->prompt('directory', $optionArray);
97	1	$file = $this->prompt('file', $optionArray);
98
99		/* restore filesystem */
100
101	1	$backupFilesystem = new Filesystem\Directory();
102	1	$backupFilesystem->init($directory);
103
104		/* restore */
105
106	1	if (is_file($directory . DIRECTORY_SEPARATOR . $file))
107		{
108		$command = ':';
109		$content = $backupFilesystem->readFile($file);
110		if ($dbType === 'mysql' && $dbHost && $dbName && $dbUser && $dbPassword)
		0 ignored issues – show Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbHost` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbName` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbUser` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbPassword` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
111		{
112		$command = $content . ' \| mysql --host=' . $dbHost . ' --user=' . $dbUser . ' --password=' . $dbPassword . ' ' . $dbName;
113		}
114		if ($dbType === 'pgsql' && $dbHost && $dbName && $dbUser && $dbPassword)
		0 ignored issues – show Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbHost` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbName` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbUser` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2019-06-22 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$dbPassword` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
115		{
116		$command = 'PGPASSWORD=' . $dbPassword . ' ' . $content . ' \| psql --host=' . $dbHost . ' --username=' . $dbUser . ' ' . $dbName;
117		}
118		if ($dbType === 'sqlite' && is_file($dbHost))
119		{
120		$command = 'echo ' . $content . ' > ' . $dbHost;
121		}
122		exec($command, $outputArray, $error);
123		return $error === 0;
124		}
125	1	return false;
126		}
127		}
128

redaxscript / redaxscript

Push — master ( da58d4...61a0f7 )

includes/Console/Command/Restore.php (8 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like