The expression $validateArray of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
39
{
40
6
return $this->_error(
41
[
42
6
'route' => $this->_getErrorRoute($postArray),
43
6
'message' => $validateArray
44
]);
45
}
46
47
/* handle create */
48
49
4
if ($action === 'create')
50
{
51
$createArray =
52
[
53
1
'name' => $postArray['name'],
54
1
'alias' => $postArray['alias'],
55
1
'description' => $postArray['description'],
56
1
'categories' => $postArray['categories'],
57
1
'articles' => $postArray['articles'],
58
1
'extras' => $postArray['extras'],
59
1
'comments' => $postArray['comments'],
60
1
'groups' => $postArray['groups'],
61
1
'users' => $postArray['users'],
62
1
'modules' => $postArray['modules'],
63
1
'settings' => $postArray['settings'],
64
1
'filter' => $postArray['filter'],
65
1
'status' => $postArray['status']
66
];
67
1
if ($this->_create($createArray))
68
{
69
1
return $this->_success(
70
[
71
1
'route' => $this->_getSuccessRoute($postArray),
72
1
'timeout' => 2
73
]);
74
}
75
}
76
77
/* handle update */
78
79
3
if ($action === 'update')
80
{
81
$updateFullArray =
82
[
83
2
'name' => $postArray['name'],
84
2
'alias' => $postArray['alias'],
85
2
'description' => $postArray['description'],
86
2
'categories' => $postArray['categories'],
87
2
'articles' => $postArray['articles'],
88
2
'extras' => $postArray['extras'],
89
2
'comments' => $postArray['comments'],
90
2
'groups' => $postArray['groups'],
91
2
'users' => $postArray['users'],
92
2
'modules' => $postArray['modules'],
93
2
'settings' => $postArray['settings'],
94
2
'filter' => $postArray['filter'],
95
2
'status' => $postArray['status']
96
];
97
$updateLiteArray =
98
[
99
2
'name' => $postArray['name'],
100
2
'alias' => $postArray['alias'],
101
2
'description' => $postArray['description']
102
];
103
2
if ($this->_update($postArray['id'], $postArray['id'] > 1 ? $updateFullArray : $updateLiteArray))
redaxscript /
redaxscript
redaxmedia
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.