Issues in InstallationTest.php - Fixed Issues - Inspection of "Update README.md" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 16ddfb...0ea243 )

by Henry

created 2019-05-20 23:53 UTC

tests/acceptance/InstallationTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Tests;

use Facebook\WebDriver\WebDriverBy;
use Facebook\WebDriver\WebDriverExpectedCondition;
use Facebook\WebDriver\WebDriverSelect;

/**
 * InstallationTest
 *
 * @since 4.0.0
 *
 * @package Redaxscript
 * @category Tests
 * @author Henry Ruhs
 */

class InstallationTest extends TestCaseAbstract
{
	/**
	 * setUp
	 *
	 * @since 4.0.0
	 */

	public function setUp() : void
	{
		parent::setUp();
		$this->_driver->get('http://localhost:8000/install.php');
	}

	/**
	 * testTitle
	 *
	 * @since 4.0.0
	 */

	public function testTitle() : void
	{
		/* expect and actual */

		$expect = $this->_language->get('installation');
		$actual = $this->_driver->getTitle();

		/* compare */

		$this->assertEquals($expect, $actual);
	}

	/**
	 * testBehaviour
	 *
	 * @since 4.0.0
	 */

	public function testBehaviour() : void
	{
		/* prepare */

		$formElement = $this->_driver->findElement(WebDriverBy::tagName('form'));
		$dbHostElement = $formElement->findElement(WebDriverBy::id('db-host'));
		$dbTypeElement = $formElement->findElement(WebDriverBy::id('db-type'));
		$dbNameElement = $formElement->findElement(WebDriverBy::id('db-name'));
		$dbUserElement = $formElement->findElement(WebDriverBy::id('db-user'));
		$dbPasswordElement = $formElement->findElement(WebDriverBy::id('db-password'));
		$dbPrefixElement = $formElement->findElement(WebDriverBy::id('db-prefix'));
		$adminNameElement = $formElement->findElement(WebDriverBy::id('admin-name'));
		$adminUserElement = $formElement->findElement(WebDriverBy::id('admin-user'));
		$adminPasswordElement = $formElement->findElement(WebDriverBy::id('admin-password'));
		$adminEmailElement = $formElement->findElement(WebDriverBy::id('admin-email'));
		$labelAccountElement =  $formElement->findElement(WebDriverBy::cssSelector('[for*="Account"]'));

		/* setup */

		$dbTypeSelect = new WebDriverSelect($dbTypeElement);

		/* compare */

		$this->assertFalse($adminNameElement->isDisplayed());
		$this->assertFalse($adminUserElement->isDisplayed());
		$this->assertFalse($adminPasswordElement->isDisplayed());
		$this->assertFalse($adminEmailElement->isDisplayed());

		/* setup and compare */

		$dbTypeSelect->selectByValue('sqlite');
		$this->assertTrue($dbHostElement->isDisplayed());
		$this->assertFalse($dbNameElement->isDisplayed());
		$this->assertFalse($dbUserElement->isDisplayed());
		$this->assertFalse($dbPasswordElement->isDisplayed());
		$this->assertTrue($dbPrefixElement->isDisplayed());

		/* setup and compare */

		$dbTypeSelect->selectByValue('mysql');
		$this->assertTrue($dbHostElement->isDisplayed());
		$this->assertTrue($dbNameElement->isDisplayed());
		$this->assertTrue($dbUserElement->isDisplayed());
		$this->assertTrue($dbPasswordElement->isDisplayed());
		$this->assertTrue($dbPrefixElement->isDisplayed());

		/* setup and compare */

		$labelAccountElement->click();
		$this->assertTrue($adminNameElement->isDisplayed());
		$this->assertTrue($adminUserElement->isDisplayed());
		$this->assertTrue($adminPasswordElement->isDisplayed());
		$this->assertTrue($adminEmailElement->isDisplayed());
	}

	/**
	 * testInstall
	 *
	 * @since 4.0.0
	 */

	public function testInstall() : void
	{
		/* prepare */

		$formElement = $this->_driver->findElement(WebDriverBy::tagName('form'));
		$dbHostElement = $formElement->findElement(WebDriverBy::id('db-host'));
		$dbTypeElement = $formElement->findElement(WebDriverBy::id('db-type'));
		$dbPrefixElement = $formElement->findElement(WebDriverBy::id('db-prefix'));
		$adminNameElement = $formElement->findElement(WebDriverBy::id('admin-name'));
		$adminUserElement = $formElement->findElement(WebDriverBy::id('admin-user'));
		$adminPasswordElement = $formElement->findElement(WebDriverBy::id('admin-password'));
		$adminEmailElement = $formElement->findElement(WebDriverBy::id('admin-email'));
		$labelAccountElement =  $formElement->findElement(WebDriverBy::cssSelector('[for*="Account"]'));
		$buttonElement = $formElement->findElement(WebDriverBy::tagName('button'));
		$dbTypeSelect = new WebDriverSelect($dbTypeElement);

		/* setup */

		$dbTypeSelect->selectByValue('sqlite');
		$dbHostElement->sendKeys('build/test.sqlite');
		$dbPrefixElement->sendKeys('test_');
		$labelAccountElement->click();
		$adminNameElement->sendKeys('Test');
		$adminUserElement->sendKeys('test');
		$adminPasswordElement->sendKeys('test');
		$adminEmailElement->sendKeys('[email protected]');
		$buttonElement->click();

		/* compare */

		$this->_driver->wait(5)->until(WebDriverExpectedCondition::urlIs('http://localhost:8000/index.php'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->expectNotToPerformAssertions();
	}
}


1			<?php
2			namespace Redaxscript\Tests;
3
4			use Facebook\WebDriver\WebDriverBy;
5			use Facebook\WebDriver\WebDriverExpectedCondition;
6			use Facebook\WebDriver\WebDriverSelect;
7
8			/**
9			* InstallationTest
10			*
11			* @since 4.0.0
12			*
13			* @package Redaxscript
14			* @category Tests
15			* @author Henry Ruhs
16			*/
17
18			class InstallationTest extends TestCaseAbstract
19			{
20			/**
21			* setUp
22			*
23			* @since 4.0.0
24			*/
25
26			public function setUp() : void
27			{
28			parent::setUp();
29			$this->_driver->get('http://localhost:8000/install.php');
30			}
31
32			/**
33			* testTitle
34			*
35			* @since 4.0.0
36			*/
37
38			public function testTitle() : void
39			{
40			/* expect and actual */
41
42			$expect = $this->_language->get('installation');
43			$actual = $this->_driver->getTitle();
44
45			/* compare */
46
47			$this->assertEquals($expect, $actual);
48			}
49
50			/**
51			* testBehaviour
52			*
53			* @since 4.0.0
54			*/
55
56			public function testBehaviour() : void
57			{
58			/* prepare */
59
60			$formElement = $this->_driver->findElement(WebDriverBy::tagName('form'));
61			$dbHostElement = $formElement->findElement(WebDriverBy::id('db-host'));
62			$dbTypeElement = $formElement->findElement(WebDriverBy::id('db-type'));
63			$dbNameElement = $formElement->findElement(WebDriverBy::id('db-name'));
64			$dbUserElement = $formElement->findElement(WebDriverBy::id('db-user'));
65			$dbPasswordElement = $formElement->findElement(WebDriverBy::id('db-password'));
66			$dbPrefixElement = $formElement->findElement(WebDriverBy::id('db-prefix'));
67			$adminNameElement = $formElement->findElement(WebDriverBy::id('admin-name'));
68			$adminUserElement = $formElement->findElement(WebDriverBy::id('admin-user'));
69			$adminPasswordElement = $formElement->findElement(WebDriverBy::id('admin-password'));
70			$adminEmailElement = $formElement->findElement(WebDriverBy::id('admin-email'));
71			$labelAccountElement = $formElement->findElement(WebDriverBy::cssSelector('[for*="Account"]'));
72
73			/* setup */
74
75			$dbTypeSelect = new WebDriverSelect($dbTypeElement);
76
77			/* compare */
78
79			$this->assertFalse($adminNameElement->isDisplayed());
80			$this->assertFalse($adminUserElement->isDisplayed());
81			$this->assertFalse($adminPasswordElement->isDisplayed());
82			$this->assertFalse($adminEmailElement->isDisplayed());
83
84			/* setup and compare */
85
86			$dbTypeSelect->selectByValue('sqlite');
87			$this->assertTrue($dbHostElement->isDisplayed());
88			$this->assertFalse($dbNameElement->isDisplayed());
89			$this->assertFalse($dbUserElement->isDisplayed());
90			$this->assertFalse($dbPasswordElement->isDisplayed());
91			$this->assertTrue($dbPrefixElement->isDisplayed());
92
93			/* setup and compare */
94
95			$dbTypeSelect->selectByValue('mysql');
96			$this->assertTrue($dbHostElement->isDisplayed());
97			$this->assertTrue($dbNameElement->isDisplayed());
98			$this->assertTrue($dbUserElement->isDisplayed());
99			$this->assertTrue($dbPasswordElement->isDisplayed());
100			$this->assertTrue($dbPrefixElement->isDisplayed());
101
102			/* setup and compare */
103
104			$labelAccountElement->click();
105			$this->assertTrue($adminNameElement->isDisplayed());
106			$this->assertTrue($adminUserElement->isDisplayed());
107			$this->assertTrue($adminPasswordElement->isDisplayed());
108			$this->assertTrue($adminEmailElement->isDisplayed());
109			}
110
111			/**
112			* testInstall
113			*
114			* @since 4.0.0
115			*/
116
117			public function testInstall() : void
118			{
119			/* prepare */
120
121			$formElement = $this->_driver->findElement(WebDriverBy::tagName('form'));
122			$dbHostElement = $formElement->findElement(WebDriverBy::id('db-host'));
123			$dbTypeElement = $formElement->findElement(WebDriverBy::id('db-type'));
124			$dbPrefixElement = $formElement->findElement(WebDriverBy::id('db-prefix'));
125			$adminNameElement = $formElement->findElement(WebDriverBy::id('admin-name'));
126			$adminUserElement = $formElement->findElement(WebDriverBy::id('admin-user'));
127			$adminPasswordElement = $formElement->findElement(WebDriverBy::id('admin-password'));
128			$adminEmailElement = $formElement->findElement(WebDriverBy::id('admin-email'));
129			$labelAccountElement = $formElement->findElement(WebDriverBy::cssSelector('[for*="Account"]'));
130			$buttonElement = $formElement->findElement(WebDriverBy::tagName('button'));
131			$dbTypeSelect = new WebDriverSelect($dbTypeElement);
132
133			/* setup */
134
135			$dbTypeSelect->selectByValue('sqlite');
136			$dbHostElement->sendKeys('build/test.sqlite');
137			$dbPrefixElement->sendKeys('test_');
138			$labelAccountElement->click();
139			$adminNameElement->sendKeys('Test');
140			$adminUserElement->sendKeys('test');
141			$adminPasswordElement->sendKeys('test');
142			$adminEmailElement->sendKeys('[email protected]');
143			$buttonElement->click();
144
145			/* compare */
146
147			$this->_driver->wait(5)->until(WebDriverExpectedCondition::urlIs('http://localhost:8000/index.php'));
			0 ignored issues – show Documentation introduced 2019-01-26 22:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Facebook\WebDriver\WebD...alhost:8000/index.php')` is of type `object<Facebook\WebDrive...riverExpectedCondition>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
148			$this->expectNotToPerformAssertions();
149			}
150			}
151

redaxscript / redaxscript

Push — master ( 16ddfb...0ea243 )

tests/acceptance/InstallationTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like