redaxscript / redaxscript

includes/Template/Helper/Description.php

<?php
namespace Redaxscript\Template\Helper;

use Redaxscript\Db;
use Redaxscript\Model;

/**
 * helper class to provide a description helper
 *
 * @since 3.0.0
 *
 * @package Redaxscript
 * @category Template
 * @author Henry Ruhs
 */

class Description extends HelperAbstract
{
	/**
	 * process
	 *
	 * @since 3.0.0
	 *
	 * @return string|null
	 */

	public function process() : ?string
	{
		$settingModel = new Model\Setting();
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');
		$useDescription = $this->_registry->get('useDescription');
		$settingDescription = $settingModel->get('description');
		$description = null;

		/* find description */

		if ($useDescription)
		{
			$description = $useDescription;
		}
		else if ($lastTable && $lastId)
		{
			$content = Db::forTablePrefix($lastTable)->whereIdIs($lastId)->whereNull('access')->findOne();

It seems like $lastTable defined by $this->_registry->get('lastTable') on line 30 can also be of type array; however, Redaxscript\Db::forTablePrefix() does only seem to accept null|string, maybe add an additional type check?

			$description = $content->description;

			/* handle parent */

			if (!$description)
			{
				$parentId = $content->category ? : $content->parent;
				if ($parentId)
				{
					$parent = Db::forTablePrefix('categories')->whereIdIs($parentId)->whereNull('access')->findOne();
					$description = $parent->description;
				}
			}
		}

		/* handle description */

		return $description ? : $settingDescription;
	}
}