Issues in Template.php - Fixed Issues - Inspection of "Use latest gray() syntax" - redaxscript/redaxscript - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aaa756...6a04f6 )

by Henry

created 2018-10-18 20:40 UTC

includes/Detector/Template.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Redaxscript\Detector;

use Redaxscript\Db;
use Redaxscript\Model;

/**
 * children class to detect the required template
 *
 * @since 2.0.0
 *
 * @package Redaxscript
 * @category Detector
 * @author Henry Ruhs
 */

class Template extends DetectorAbstract
{
	/**
	 * automate run
	 *
	 * @since 2.1.0
	 */

	protected function _autorun()
	{
		$settingModel = new Model\Setting();
		$dbStatus = $this->_registry->get('dbStatus');
		$lastTable = $this->_registry->get('lastTable');
		$lastId = $this->_registry->get('lastId');

		/* detect template */

		$this->_output = $this->_detect(
		[
			'query' => $this->_request->getQuery('t'),
			'session' => $this->_request->getSession('template'),
			'contents' => $lastTable ? Db::forTablePrefix($lastTable)->whereIdIs($lastId)->findOne()->template : null,
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
			'fallback' => 'default'
		], 'template', 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml');
	}
}


1		<?php
2		namespace Redaxscript\Detector;
3
4		use Redaxscript\Db;
5		use Redaxscript\Model;
6
7		/**
8		* children class to detect the required template
9		*
10		* @since 2.0.0
11		*
12		* @package Redaxscript
13		* @category Detector
14		* @author Henry Ruhs
15		*/
16
17		class Template extends DetectorAbstract
18		{
19		/**
20		* automate run
21		*
22		* @since 2.1.0
23		*/
24
25	7	protected function _autorun()
26		{
27	7	$settingModel = new Model\Setting();
28	7	$dbStatus = $this->_registry->get('dbStatus');
29	7	$lastTable = $this->_registry->get('lastTable');
30	7	$lastId = $this->_registry->get('lastId');
31
32		/* detect template */
33
34	7	$this->_output = $this->_detect(
35		[
36	7	'query' => $this->_request->getQuery('t'),
37	7	'session' => $this->_request->getSession('template'),
38	7	'contents' => $lastTable ? Db::forTablePrefix($lastTable)->whereIdIs($lastId)->findOne()->template : null,
		0 ignored issues – show Bug introduced 2018-09-08 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$lastTable` defined by `$this->_registry->get('lastTable')` on line `29` can also be of type `array`; however, `Redaxscript\Db::forTablePrefix()` does only seem to accept `null\|string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
39	7	'settings' => $dbStatus === 2 ? $settingModel->get('template') : null,
40	7	'fallback' => 'default'
41	7	], 'template', 'templates' . DIRECTORY_SEPARATOR . $this->_filePlaceholder . DIRECTORY_SEPARATOR . 'index.phtml');
42	7	}
43		}
44

redaxscript / redaxscript

Push — master ( aaa756...6a04f6 )

includes/Detector/Template.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like