Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | View Code Duplication | class GetTransactionDataAction extends BaseApiAwareAction |
|
| 10 | { |
||
| 11 | /** |
||
| 12 | * {@inheritdoc} |
||
| 13 | * |
||
| 14 | * @param $request GetTransactionData |
||
| 15 | */ |
||
| 16 | 1 | public function execute($request) |
|
| 17 | { |
||
| 18 | 1 | RequestNotSupportedException::assertSupports($this, $request); |
|
| 19 | |||
| 20 | 1 | $details = ArrayObject::ensureArrayObject($request->getModel()); |
|
| 21 | |||
| 22 | 1 | $details->replace($this->api->getTransactionData((array) $details)); |
|
| 23 | 1 | } |
|
| 24 | |||
| 25 | /** |
||
| 26 | * {@inheritdoc} |
||
| 27 | */ |
||
| 28 | 1 | public function supports($request) |
|
| 34 | } |
||
| 35 |