Conditions | 1 |
Paths | 1 |
Total Lines | 65 |
Code Lines | 60 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
93 | public function testFromArrayWithEmptyStatement(): void |
||
94 | { |
||
95 | $info = [ |
||
96 | 'distinct' => false, |
||
97 | 'drop_database' => false, |
||
98 | 'group' => false, |
||
99 | 'having' => false, |
||
100 | 'is_affected' => false, |
||
101 | 'is_analyse' => false, |
||
102 | 'is_count' => false, |
||
103 | 'is_delete' => false, |
||
104 | 'is_explain' => false, |
||
105 | 'is_export' => false, |
||
106 | 'is_func' => false, |
||
107 | 'is_group' => false, |
||
108 | 'is_insert' => false, |
||
109 | 'is_maint' => false, |
||
110 | 'is_procedure' => false, |
||
111 | 'is_replace' => false, |
||
112 | 'is_select' => false, |
||
113 | 'is_show' => false, |
||
114 | 'is_subquery' => false, |
||
115 | 'join' => false, |
||
116 | 'limit' => false, |
||
117 | 'offset' => false, |
||
118 | 'order' => false, |
||
119 | 'querytype' => false, |
||
120 | 'reload' => false, |
||
121 | 'select_from' => false, |
||
122 | 'union' => false, |
||
123 | ]; |
||
124 | |||
125 | $statementInfo = StatementInfo::fromArray($info); |
||
126 | |||
127 | $this->assertFalse($statementInfo->distinct); |
||
128 | $this->assertFalse($statementInfo->dropDatabase); |
||
129 | $this->assertFalse($statementInfo->group); |
||
130 | $this->assertFalse($statementInfo->having); |
||
131 | $this->assertFalse($statementInfo->isAffected); |
||
132 | $this->assertFalse($statementInfo->isAnalyse); |
||
133 | $this->assertFalse($statementInfo->isCount); |
||
134 | $this->assertFalse($statementInfo->isDelete); |
||
135 | $this->assertFalse($statementInfo->isExplain); |
||
136 | $this->assertFalse($statementInfo->isExport); |
||
137 | $this->assertFalse($statementInfo->isFunction); |
||
138 | $this->assertFalse($statementInfo->isGroup); |
||
139 | $this->assertFalse($statementInfo->isInsert); |
||
140 | $this->assertFalse($statementInfo->isMaint); |
||
141 | $this->assertFalse($statementInfo->isProcedure); |
||
142 | $this->assertFalse($statementInfo->isReplace); |
||
143 | $this->assertFalse($statementInfo->isSelect); |
||
144 | $this->assertFalse($statementInfo->isShow); |
||
145 | $this->assertFalse($statementInfo->isSubquery); |
||
146 | $this->assertFalse($statementInfo->join); |
||
147 | $this->assertFalse($statementInfo->limit); |
||
148 | $this->assertFalse($statementInfo->offset); |
||
149 | $this->assertFalse($statementInfo->order); |
||
150 | $this->assertFalse($statementInfo->queryType); |
||
151 | $this->assertFalse($statementInfo->reload); |
||
152 | $this->assertFalse($statementInfo->selectFrom); |
||
153 | $this->assertFalse($statementInfo->union); |
||
154 | $this->assertNull($statementInfo->parser); |
||
155 | $this->assertNull($statementInfo->statement); |
||
156 | $this->assertEmpty($statementInfo->selectTables); |
||
157 | $this->assertEmpty($statementInfo->selectExpression); |
||
158 | } |
||
160 |