CharsetsTest::testGetServerCharset() - Code Metrics - Inspection of "Remove mocking from DatabaseInterfaceTest" - phpmyadmin/phpmyadmin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bb9122...7ad73a )

by William

created 2021-05-31 16:31 UTC

CharsetsTest::testGetServerCharset() A

↳ Parent: CharsetsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	53
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	31
nc	1
nop	0
dl	0
loc	53
rs	9.424
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Tests for MySQL Charsets
 */

declare(strict_types=1);

namespace PhpMyAdmin\Tests;

use PhpMyAdmin\Charsets;

/**
 * Tests for MySQL Charsets
 */
class CharsetsTest extends AbstractTestCase
{
    protected function setUp(): void
    {
        parent::setUp();
        parent::setGlobalDbi();
        $GLOBALS['server'] = 0;
        $GLOBALS['cfg']['DBG']['sql'] = false;
        $GLOBALS['cfg']['Server']['DisableIS'] = false;
    }

    public function testGetServerCharset(): void
    {
        $this->dummyDbi->addResult(
            'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
            [
                [
                    'character_set_server',
                    'utf8mb3',
                ],
            ],
            [
                'Variable_name',
                'Value',
            ]
        );
        $this->dummyDbi->addResult(
            'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
            false
        );
        $this->dummyDbi->addResult(
            'SELECT @@character_set_server;',
            false
        );
        $this->dummyDbi->addResult(
            'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
            false
        );
        $this->dummyDbi->addResult(
            'SELECT @@character_set_server;',
            [
                ['utf8mb3'],
            ]
        );

        $charset = Charsets::getServerCharset(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS']
        );
        $this->assertSame('utf8', $charset->getName());

        $charset = Charsets::getServerCharset(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS']
        );
        $this->assertSame('Unknown', $charset->getName());

        $charset = Charsets::getServerCharset(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS']
        );
        $this->assertSame('utf8', $charset->getName());

        $this->assertAllQueriesConsumed();
    }

    public function testFindCollationByName(): void
    {
        $this->assertNull(Charsets::findCollationByName(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS'],
            null
        ));

        $this->assertNull(Charsets::findCollationByName(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS'],
            ''
        ));

        $this->assertNull(Charsets::findCollationByName(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS'],
            'invalid'
        ));

        $actual = Charsets::findCollationByName(
            $GLOBALS['dbi'],
            $GLOBALS['cfg']['Server']['DisableIS'],
            'utf8_general_ci'
        );

        $this->assertInstanceOf(Charsets\Collation::class, $actual);

        $this->assertSame('utf8_general_ci', $actual->getName());
    }
}


1			<?php
2			/**
3			* Tests for MySQL Charsets
4			*/
5
6			declare(strict_types=1);
7
8			namespace PhpMyAdmin\Tests;
9
10			use PhpMyAdmin\Charsets;
11
12			/**
13			* Tests for MySQL Charsets
14			*/
15			class CharsetsTest extends AbstractTestCase
16			{
17			protected function setUp(): void
18			{
19			parent::setUp();
20			parent::setGlobalDbi();
21			$GLOBALS['server'] = 0;
22			$GLOBALS['cfg']['DBG']['sql'] = false;
23			$GLOBALS['cfg']['Server']['DisableIS'] = false;
24			}
25
26			public function testGetServerCharset(): void
27			{
28			$this->dummyDbi->addResult(
29			'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
30			[
31			[
32			'character_set_server',
33			'utf8mb3',
34			],
35			],
36			[
37			'Variable_name',
38			'Value',
39			]
40			);
41			$this->dummyDbi->addResult(
42			'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
43			false
44			);
45			$this->dummyDbi->addResult(
46			'SELECT @@character_set_server;',
47			false
48			);
49			$this->dummyDbi->addResult(
50			'SHOW SESSION VARIABLES LIKE \'character_set_server\';',
51			false
52			);
53			$this->dummyDbi->addResult(
54			'SELECT @@character_set_server;',
55			[
56			['utf8mb3'],
57			]
58			);
59
60			$charset = Charsets::getServerCharset(
61			$GLOBALS['dbi'],
62			$GLOBALS['cfg']['Server']['DisableIS']
63			);
64			$this->assertSame('utf8', $charset->getName());
65
66			$charset = Charsets::getServerCharset(
67			$GLOBALS['dbi'],
68			$GLOBALS['cfg']['Server']['DisableIS']
69			);
70			$this->assertSame('Unknown', $charset->getName());
71
72			$charset = Charsets::getServerCharset(
73			$GLOBALS['dbi'],
74			$GLOBALS['cfg']['Server']['DisableIS']
75			);
76			$this->assertSame('utf8', $charset->getName());
77
78			$this->assertAllQueriesConsumed();
79			}
80
81			public function testFindCollationByName(): void
82			{
83			$this->assertNull(Charsets::findCollationByName(
84			$GLOBALS['dbi'],
85			$GLOBALS['cfg']['Server']['DisableIS'],
86			null
87			));
88
89			$this->assertNull(Charsets::findCollationByName(
90			$GLOBALS['dbi'],
91			$GLOBALS['cfg']['Server']['DisableIS'],
92			''
93			));
94
95			$this->assertNull(Charsets::findCollationByName(
96			$GLOBALS['dbi'],
97			$GLOBALS['cfg']['Server']['DisableIS'],
98			'invalid'
99			));
100
101			$actual = Charsets::findCollationByName(
102			$GLOBALS['dbi'],
103			$GLOBALS['cfg']['Server']['DisableIS'],
104			'utf8_general_ci'
105			);
106
107			$this->assertInstanceOf(Charsets\Collation::class, $actual);
108
109			$this->assertSame('utf8_general_ci', $actual->getName());
110			}
111			}
112

phpmyadmin / phpmyadmin

Push — master ( bb9122...7ad73a )

CharsetsTest::testGetServerCharset() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like