phpmetrics / PhpMetrics

src/Hal/Metrics/Complexity/Text/Halstead/Halstead.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
     /**
      * Inventories tokens
      *
-     * @param array $tokens
+     * @param \SplFixedArray $tokens
      * @return $this
      */
     private function inventory($tokens)

Spacing +12 added lines, -12 removed lines

@@ -66,11 +66,11 @@ 
     {
         $this->operators = $this->operands = array();
 
-        foreach($tokens as $token) {
-            if($this->tokenType->isOperator($token)) {
+        foreach ($tokens as $token) {
+            if ($this->tokenType->isOperator($token)) {
                 $this->operators[] = $token;
             }
-            else if($this->tokenType->isOperand($token)) {
+            else if ($this->tokenType->isOperand($token)) {
                 $this->operands[] = $token;
             }
         }
@@ -93,23 +93,23 @@ 
         $this->inventory($class->getTokens());
         $result = new Result;
 
-        $uniqueOperators = array_map( 'unserialize', array_unique( array_map( 'serialize', $this->operators ) ) );
-        $uniqueOperands = array_map( 'unserialize', array_unique( array_map( 'serialize', $this->operands ) ) );
+        $uniqueOperators = array_map('unserialize', array_unique(array_map('serialize', $this->operators)));
+        $uniqueOperands = array_map('unserialize', array_unique(array_map('serialize', $this->operands)));
 
         $n1 = sizeof($uniqueOperators, COUNT_NORMAL);
         $n2 = sizeof($uniqueOperands, COUNT_NORMAL);
         $N1 = sizeof($this->operators, COUNT_NORMAL);
         $N2 = sizeof($this->operands, COUNT_NORMAL);
 
-        if(($n2 == 0)||($N2 == 0)) {
+        if (($n2 == 0) || ($N2 == 0)) {
             // files without operators
             $V = $n1 = $n2 = $N1 = $N2 = $E = $D = $B = $T = $I = $L = 0;
         } else {
             $devAbility = 3000;
             $N = $N1 + $N2;
             $n = $n1 + $n2;
-            $V = $N * log($n ,2);
-            $L = (2 / max(1,$n1)) * ($n2 / $N2);
+            $V = $N * log($n, 2);
+            $L = (2 / max(1, $n1)) * ($n2 / $N2);
             $D = ($n1 / 2) * ($N2 / $n2);
             $E = $V * $D;
             $B = $V / $devAbility;
@@ -120,13 +120,13 @@ 
         $result
             ->setLength($N1 + $N2)
             ->setVocabulary($n1 + $n2)
-            ->setVolume(round($V,2))
-            ->setDifficulty(round($D,2))
-            ->setEffort(round($E,2))
+            ->setVolume(round($V, 2))
+            ->setDifficulty(round($D, 2))
+            ->setEffort(round($E, 2))
             ->setLevel(round($L, 2))
             ->setBugs(round($B, 2))
             ->setTime(round($T))
-            ->setIntelligentContent(round($I,2))
+            ->setIntelligentContent(round($I, 2))
             ->setNumberOfOperators($N1)
             ->setNumberOfOperands($N2)
             ->setNumberOfUniqueOperators($n1)

src/Hal/Component/Token/Tokenizer.php

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
         $code = preg_replace('!(\}|\)|;)\?!', '$1 ?', $code);
 
         // remove one line comments
-        $code = preg_replace('!((\/\/|#).*\n)!', Token::T_COMMENT . ' ', $code);
+        $code = preg_replace('!((\/\/|#).*\n)!', Token::T_COMMENT.' ', $code);
 
         // remove EOL
         $code = preg_replace('!(\s+)!', ' ', $code);
@@ -37,6 +37,6 @@ 
         $code = preg_replace('!return;!i', Token::T_RETURN_VOID, $code);
 
         // split tokens
-        return preg_split('!\s|;|,|(\{|\}|\(|\))!', $code, null, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
+        return preg_split('!\s|;|,|(\{|\}|\(|\))!', $code, null, PREG_SPLIT_DELIM_CAPTURE|PREG_SPLIT_NO_EMPTY);
     }
 }
\ No newline at end of file

src/Hal/Component/Token/TokenType.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
      * @var array
      */
     private $operators = array(
-        ';', '*', '/', '%', '-','+',
+        ';', '*', '/', '%', '-', '+',
         '!', '!=', '%', '%=', '&', '&&', 'OR', 'AND', '||', '&=', '(', ')',
         '[', ']', '*', '*=', '+', '++', '+=', ',',
         '-', '--', '-=->', '.', '...', '/', '/=', ':', '::',

src/Hal/Component/Tree/Graph.php

Spacing +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
      */
     public function insert(Node $node)
     {
-        if($this->has($node->getKey())) {
+        if ($this->has($node->getKey())) {
             throw new GraphException(sprintf('node %s is already present', $node->getKey()));
         }
         $this->datas[$node->getKey()] = $node;
@@ -41,10 +41,10 @@ 
      */
     public function addEdge(Node $from, Node $to)
     {
-        if(!$this->has($from->getKey())) {
+        if (!$this->has($from->getKey())) {
             throw new GraphException('from is not is in the graph');
         }
-        if(!$this->has($to->getKey())) {
+        if (!$this->has($to->getKey())) {
             throw new GraphException('to is not is in the graph');
         }
 

src/Hal/Component/Tree/GraphFactory.php

Spacing +5 added lines, -5 removed lines

@@ -23,9 +23,9 @@ 
         $graph = new Graph();
 
         // insert all required nodes in graph
-        foreach($hash as $node) {
-            foreach($node->getData()->getDependencies() as $dependencyName) {
-                if(!$hash->has($dependencyName)) {
+        foreach ($hash as $node) {
+            foreach ($node->getData()->getDependencies() as $dependencyName) {
+                if (!$hash->has($dependencyName)) {
                     // dependency is not registered (example: external dependency from vendors)
                     $adjacent = new Node($dependencyName, new Klass($dependencyName));
                     $graph->insert($adjacent);
@@ -35,8 +35,8 @@ 
         }
 
         // relations
-        foreach($hash as $from) {
-            foreach($from->getData()->getDependencies() as $dependencyName) {
+        foreach ($hash as $from) {
+            foreach ($from->getData()->getDependencies() as $dependencyName) {
                 $to = $graph->get($dependencyName);
                 $graph->addEdge($from, $to);
             }

src/Hal/Component/Tree/Node.php

Spacing +5 added lines, -5 removed lines

@@ -56,12 +56,12 @@
     public function getAdjacents()
     {
         $adjacents = [];
-        foreach($this->edges as $edge) {
-            if($edge->getFrom()->getKey() != $this->getKey()) {
-                $adjacents[$edge->getFrom()->getKey()] =  $edge->getFrom();
+        foreach ($this->edges as $edge) {
+            if ($edge->getFrom()->getKey() != $this->getKey()) {
+                $adjacents[$edge->getFrom()->getKey()] = $edge->getFrom();
             }
-            if($edge->getTo()->getKey() != $this->getKey()) {
-                $adjacents[$edge->getTo()->getKey()] =  $edge->getTo();
+            if ($edge->getTo()->getKey() != $this->getKey()) {
+                $adjacents[$edge->getTo()->getKey()] = $edge->getTo();
             }
         }
         return $adjacents;

src/Hal/Component/Parser/CodeParser/CallsParser.php

Spacing +3 added lines, -3 removed lines

@@ -74,7 +74,7 @@ 
 
             // $instance->foo();
             if (Token::T_NEW == $token) {
-                if(!isset($tokens[$i + 1]) || Token::T_BRACE_CLOSE === $tokens[$i + 1]) {
+                if (!isset($tokens[$i + 1]) || Token::T_BRACE_CLOSE === $tokens[$i + 1]) {
                     throw new IncorrectSyntaxException('"new" is not followed by classname');
                 }
 
@@ -99,10 +99,10 @@ 
             }
 
             // $this->foo();
-            if(preg_match('!^\$this\->(.+)!', $token, $matches)) {
+            if (preg_match('!^\$this\->(.+)!', $token, $matches)) {
                 list(, $methodName) = $matches;
                 // next token should be "("
-                if(isset($tokens[$i + 1]) &&Token::T_PARENTHESIS_OPEN === $tokens[$i + 1]) {
+                if (isset($tokens[$i + 1]) && Token::T_PARENTHESIS_OPEN === $tokens[$i + 1]) {
                     $call = new Call(null, $methodName);
                     $call->setIsItself(true);
                     array_push($calls, $call);

src/Hal/Component/Parser/CodeParser/MethodUsageParser.php

Spacing +6 added lines, -6 removed lines

@@ -47,23 +47,23 @@
 
         $start = $this->searcher->getNext($method->getTokens(), 0, '{') + 1;
         $len = sizeof($method->getTokens());
-        $tokens = array_slice($method->getTokens(), $start,  ($len - $start) - 1);
+        $tokens = array_slice($method->getTokens(), $start, ($len - $start) - 1);
 
-        foreach($tokens as $n => $token) {
+        foreach ($tokens as $n => $token) {
             // replace $this->aaa by "class_attribute
-            if(preg_match('!^\$this\->\w+$!', $token)) {
+            if (preg_match('!^\$this\->\w+$!', $token)) {
                 $tokens[$n] = 'class_attribute';
             }
 
             // replace vars by "var"
-            if(preg_match('!^\$\w+$!', $token) && $token != '$this') {
+            if (preg_match('!^\$\w+$!', $token) && $token != '$this') {
                 $tokens[$n] = 'var';
             }
         }
-        switch($tokens) {
+        switch ($tokens) {
             // getters
             case array('return', 'cast', 'class_attribute'):
-            case array('return','class_attribute'):
+            case array('return', 'class_attribute'):
                 return MethodUsage::USAGE_GETTER;
                 break;
 

src/Hal/Component/Parser/CodeParser/ArgumentsParser.php

Spacing +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
                     $i = $i + 2;
                     // look for default value
                     if (!isset($tokens[$i]) || Token::T_PARENTHESIS_CLOSE == $tokens[$i]) {
-                        throw new IncorrectSyntaxException('not default value found for parameter ' . $token);
+                        throw new IncorrectSyntaxException('not default value found for parameter '.$token);
                     }
                     $value = $tokens[$i];