Test Failed
Push — master ( e3c39f...fe570d )
by Mihail
07:20
created

Loader/Console/index.php (2 issues)

1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 2 and the first side effect is on line 9.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
define('env_name', 'Console');
3
define('env_type', 'cli');
4
5
use Ffcms\Core\Helper\Type\Str;
6
use Ffcms\Core\Helper\FileSystem\File;
0 ignored issues
show
This use statement conflicts with another class in this namespace, File. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
7
8
if (PHP_SAPI !== 'cli' || !defined('root')) {
9
    die();
10
}
11
12
require_once(root . '/Loader/Autoload.php');
13
14
// initialize console app
15
$app = new Symfony\Component\Console\Application('FFCMS', '3.0.0');
16
17
// list classmap and add existing commands
18
$classMap = $loader->getPrefixes();
19
foreach ($classMap['Apps\\'] as $path) {
20
    $path .= '/Apps/Console';
21
    $files = File::listFiles($path, ['.php'], true);
22
    foreach ($files as $file) {
23
        $class = Str::cleanExtension($file);
24
        $namespace = 'Apps\Console\\' . $class;
25
        if (class_exists($namespace) && is_a($namespace, 'Symfony\Component\Console\Command\Command', true)) {
26
            $cmd = new $namespace;
27
            $app->add($cmd);
28
            $cmd = null;
29
        }
30
    }
31
}
32