Test Failed
Push — master ( e3c39f...fe570d )
by Mihail
07:20
created

View/Front/default/_core/form/button/submit.php (2 issues)

1
<?php
2
/** @var \Ffcms\Templex\Template\Template $this */
3
4
/** @var string|null $text */
5
/** @var array|null $properties */
6
7
$properties['type'] = 'submit';
8
$properties['value'] = $text;
9
?>
10
11
<?= (new \Ffcms\Templex\Helper\Html\Dom())->input($properties) ?>
0 ignored issues
show
It is not recommended to use PHP's closing tag ?> in files other than templates.

Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore.

A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever.

Loading history...
It seems like $properties can also be of type array; however, parameter $obj of Ffcms\Templex\Helper\Html\Dom::input() does only seem to accept Closure, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

11
<?= (new \Ffcms\Templex\Helper\Html\Dom())->input(/** @scrutinizer ignore-type */ $properties) ?>
Loading history...