for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
Check that return values of null are not used.
<?php
use Ffcms\Templex\Url\Url;
/** @var Apps\Model\Admin\Profile\FormFieldUpdate $model */
/** @var \Ffcms\Templex\Template\Template $this */
$this->layout('_layouts/default', [
'title' => __('Field delete'),
'breadcrumbs' => [
Url::to('main/index') => __('Main'),
Url::to('application/index') => __('Applications'),
Url::to('profile/index') => __('Profile list'),
Url::to('profile/fieldlist') => __('Profile fields'),
__('Field delete')
]
]);
?>
<?php $this->start('body') ?>
<?= $this->insert('profile/_tabs') ?>
$this->insert('profile/_tabs')
League\Plates\Template\Template::insert()
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
<h1><?= __('Field delete') ?></h1>
<p><?= __('Are you sure to delete this custom field?') ?></p>
<div class="table-responsive">
<?= $this->table(['class' => 'table'])
->row([
['text' => $model->getLabel('name')],
['text' => $model->name[\App::$Request->getLanguage()]]
])->row([
['text' => $model->getLabel('type')],
['text' => $model->type]
['text' => $model->getLabel('reg_exp')],
['text' => ($model->reg_cond == 0 ? '!' : null) . 'preg_match("'.$model->reg_exp.'", $input)']
])->display();
</div>
<?php $form = $this->form($model) ?>
<?= $form->start() ?>
<?= $form->button()->submit(__('Delete'), ['class' => 'btn btn-danger']) ?>
<?= $form->button()->cancel(__('Cancel'), ['link' => ['profile/fieldlist'], 'class' => 'btn btn-secondary']) ?>
<?= $form->stop(false) ?>
<?php $this->stop() ?>
phpffcms /
ffcms
zenn
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.