Test Failed
Push — master ( e3c39f...fe570d )
by Mihail
07:20
created

Apps/View/Admin/default/main/files.php (1 issue)

Check for conflicting imported classes with local classes.

Bug Major
1
<?php
2
3
use Ffcms\Templex\Url\Url;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Url. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
4
5
/** @var $connector string */
6
/** @var \Ffcms\Templex\Template\Template $this */
7
/** @var \Apps\Model\Admin\Main\FormSettings $model */
8
9
$this->layout('_layouts/default', [
10
    'title' => __('Files'),
11
    'breadcrumbs' => [
12
        Url::to('main/index') => __('Main'),
13
        __('Files')
14
    ]
15
]);
16
?>
17
<?php $this->push('css') ?>
18
<link rel="stylesheet" href="<?= \App::$Alias->scriptUrl ?>/vendor/components/jqueryui/themes/base/jquery-ui.min.css" />
19
<link rel="stylesheet" href="<?= \App::$Alias->scriptUrl ?>/vendor/studio-42/elfinder/css/elfinder.min.css" />
20
<?php $this->stop() ?>
21
22
<?php $this->start('body') ?>
23
<h1><?= __('File management') ?></h1>
24
<div class="row">
25
    <div class="col-md-12">
26
        <div id="elfinder"></div>
27
    </div>
28
</div>
29
<?php $this->stop() ?>
30
31
<?php $this->push('javascript'); ?>
32
<script src="<?= \App::$Alias->scriptUrl ?>/vendor/components/jqueryui/jquery-ui.min.js"></script>
33
<script src="<?= \App::$Alias->scriptUrl ?>/vendor/studio-42/elfinder/js/elfinder.min.js"></script>
34
<?php if (\App::$Request->getLanguage() !== 'en'): ?>
35
    <script src="<?= \App::$Alias->scriptUrl ?>/vendor/studio-42/elfinder/js/i18n/elfinder.<?= \App::$Request->getLanguage() ?>.js"></script>
36
<?php endif; ?>
37
<script>
38
    $(document).ready(function(){
39
        var elf = $('#elfinder').elfinder({
40
            url: '<?=$connector?>',
41
            lang: '<?= \App::$Request->getLanguage() ?>'
42
        }).elfinder('instance');
43
    })
44
</script>
45
<?php $this->stop(); ?>