Test Failed
Push — master ( e3c39f...fe570d )
by Mihail
07:20
created

Apps/View/Admin/default/comments/edit.php (1 issue)

Check for conflicting imported classes with local classes.

Bug Major
1
<?php
2
3
use Ffcms\Templex\Url\Url;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Url. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
4
5
/** @var \Ffcms\Templex\Template\Template $this */
6
/** @var Apps\Model\Admin\Comments\FormCommentUpdate $model */
7
/** @var string $type */
8
9
$this->layout('_layouts/default', [
10
    'title' => __('Edit comment'),
11
    'breadcrumbs' => [
12
        Url::to('main/index') => __('Main'),
13
        Url::to('widget/index') => __('Widgets'),
14
        Url::to('comments/index') => __('Comments'),
15
        __('Edit comment or answer')
16
    ]
17
]);
18
?>
19
20
<?php $this->start('body') ?>
21
22
<?= $this->insert('comments/_tabs') ?>
23
24
<h1><?= __('Edit comment/answer') ?></h1>
25
<?php $form = $this->form($model) ?>
26
<?= $form->start() ?>
27
28
<?= $form->fieldset()->text('guestName', null, __('Guest name for this comment or answer if defined')) ?>
29
<?= $form->fieldset()->textarea('message', ['class' => 'form-control wysiwyg', 'html' => true], __('Comment message text')) ?>
30
31
<?= $form->button()->submit(__('Save'), ['class' => 'btn btn-primary'])?>
32
33
<?= Url::a(['comments/read', [$model->getCommentId()]], __('Back'), ['class' => 'btn btn-light'])?>
34
35
<?= $form->stop() ?>
36
37
<?php $this->stop() ?>
38
39
<?php $this->push('javascript') ?>
40
<?= \Widgets\Tinymce\Tinymce::widget([
41
    'config' => 'small'
42
]); ?>
43
<?php $this->stop() ?>
44