phpffcms / ffcms

Apps/Controller/Admin/Profile/ActionFieldUpdate.php

<?php

namespace Apps\Controller\Admin\Profile;

use Apps\ActiveRecord\ProfileField;
use Apps\Model\Admin\Profile\FormFieldUpdate;
use Ffcms\Core\App;
use Ffcms\Core\Arch\View;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;

/**
 * Trait ActionFieldUpdate
 * @package Apps\Controller\Admin\Profile
 * @property Request $request
 * @property Response $response
 * @property View $view
 */
trait ActionFieldUpdate
{

    /**
     * Add new or edit exist additional fields for user profiles
     * @param string|null $id
     * @return string
     * @throws \Ffcms\Core\Exception\SyntaxException
     */
    public function profileFieldUpdate($id = null)
    {
        // get current record or new and init form DI
        $record = ProfileField::findOrNew($id);
        $model = new FormFieldUpdate($record);

It seems like $record can also be of type null; however, parameter $record of Apps\Model\Admin\Profile\FormFieldUpdate::__construct() does only seem to accept Apps\ActiveRecord\ProfileField, maybe add an additional type check?

        // check if form is submitted
        if ($model->send() && $model->validate()) {
            $model->save();
            if ($record->id) {
                $this->response->redirect('profile/fieldlist');
            }
            App::$Session->getFlashBag()->add('success', __('Profile field was successful updated'));
        }

        return $this->view->render('profile/field_update', [
            'model' => $model
        ]);
    }
}