for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Apps\Controller\Admin\Feedback;
use Apps\Model\Admin\Feedback\FormSettings;
use Ffcms\Core\App;
use Ffcms\Core\Arch\View;
use Ffcms\Core\Network\Request;
use Ffcms\Core\Network\Response;
/**
* Trait ActionSettings
* @package Apps\Controller\Admin\Feedback
* @property Request $request
* @property Response $response
* @property View $view
*/
trait ActionSettings
{
* @return string|null
* @throws \Ffcms\Core\Exception\SyntaxException
public function settings(): ?string
// initialize model and pass configs
$model = new FormSettings($this->getConfigs());
// check if form is submited to save data
if ($model->send()) {
// is validation passed?
if ($model->validate()) {
// save properties
$this->setConfigs($model->getAllProperties());
$model->getAllProperties()
Ffcms\Core\Arch\Model::getAllProperties()
This check looks for function or method calls that always return null and whose return value is used.
class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) {
The method getObject() can return nothing but null, so it makes no sense to use the return value.
getObject()
The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.
App::$Session->getFlashBag()->add('success', __('Settings is successful updated'));
$this->response->redirect('feedback/index');
} else {
App::$Session->getFlashBag()->add('error', __('Form validation is failed'));
}
// render view
return $this->view->render('feedback/settings', [
'model' => $model
]);
phpffcms /
ffcms
Mihail
This check looks for function or method calls that always return null and whose return value is used.
The method
getObject()can return nothing but null, so it makes no sense to use the return value.The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.