phpDocumentor / phpDocumentor

src/phpDocumentor/Descriptor/Builder/Reflector/Tags/DeprecatedAssembler.php

<?php
declare(strict_types=1);

/**
 * This file is part of phpDocumentor.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author    Mike van Riel <mike.vanriel@naenius.com>
 * @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Descriptor\Builder\Reflector\Tags;

use phpDocumentor\Descriptor\Builder\Reflector\AssemblerAbstract;
use phpDocumentor\Descriptor\Tag\DeprecatedDescriptor;
use phpDocumentor\Reflection\DocBlock\Tags\Deprecated;

/**
 * Constructs a new descriptor from the Reflector for an `@deprecated` tag.
 *
 * This object will read the reflected information for the `@deprecated` tag and create a {@see DeprecatedDescriptor}
 * object that can be used in the rest of the application and templates.
 */
class DeprecatedAssembler extends AssemblerAbstract
{
    /**
     * Creates a new Descriptor from the given Reflector.
     *
     * @param Deprecated $data
     *
     * @return DeprecatedDescriptor
     */
    public function create($data)
    {
        $descriptor = new DeprecatedDescriptor($data->getName());
        $descriptor->setDescription($data->getDescription());

It seems like $data->getDescription() targeting phpDocumentor\Reflection\DocBlock\Tags\BaseTag::getDescription() can also be of type null or object<phpDocumentor\Reflection\DocBlock\Description>; however, phpDocumentor\Descriptor\TagDescriptor::setDescription() does only seem to accept string, maybe add an additional type check?

        $descriptor->setVersion($data->getVersion());

        return $descriptor;
    }
}