Issues in FactoryTest.php - Fixed Issues - Inspection of "Delete Scrybe" - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8eb671...133594 )

by Mike

created 2019-06-14 08:00 UTC

Plugin/Scrybe/Template/FactoryTest.php (1 issue)

Showing only issues like (Show All)

mismatching argument types.

Documentation Minor

Jaapio 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * phpDocumentor
 *
 * PHP Version 5.3
 *
 * @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Plugin\Scrybe\Template;

use Mockery as m;

/**
 * Test for the Template\Factory class of phpDocumentor Scrybe.
 */
class FactoryTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
{
    /**
     * Tests whether a Template can be registered using the constructor.
     *
     * @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::__construct
     */
    public function testRegisterTemplateEngineViaConstructor()
    {
        $factory = new Factory(
            ['Mock' => m::mock('\phpDocumentor\Plugin\Scrybe\Template\Mock\Template')]
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->assertInstanceOf(
            '\phpDocumentor\Plugin\Scrybe\Template\Mock\Template',
            $factory->get('Mock')
        );
    }

    /**
     * Tests whether a Template could be registered using the register method.
     *
     * @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::register
     */
    public function testRegisterTemplateEngine()
    {
        $factory = new Factory();
        $factory->register('Mock', m::mock('\phpDocumentor\Plugin\Scrybe\Template\Mock\Template'));
        $this->assertInstanceOf(
            '\phpDocumentor\Plugin\Scrybe\Template\Mock\Template',
            $factory->get('Mock')
        );
    }

    /**
     * @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::register
     * @expectedException \InvalidArgumentException
     */
    public function testRegisterInvalidName()
    {
        $factory = new Factory();
        $factory->register('', m::mock('\phpDocumentor\Plugin\Scrybe\Template\Mock\Template'));
    }

    /**
     * @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::get
     * @expectedException \InvalidArgumentException
     */
    public function testGetUnknownTemplateEngine()
    {
        $factory = new Factory();
        $factory->get('Mock');
    }
}


1			<?php
2			/**
3			* phpDocumentor
4			*
5			* PHP Version 5.3
6			*
7			* @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
8			* @license http://www.opensource.org/licenses/mit-license.php MIT
9			* @link http://phpdoc.org
10			*/
11
12			namespace phpDocumentor\Plugin\Scrybe\Template;
13
14			use Mockery as m;
15
16			/**
17			* Test for the Template\Factory class of phpDocumentor Scrybe.
18			*/
19			class FactoryTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
20			{
21			/**
22			* Tests whether a Template can be registered using the constructor.
23			*
24			* @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::__construct
25			*/
26			public function testRegisterTemplateEngineViaConstructor()
27			{
28			$factory = new Factory(
29			['Mock' => m::mock('\phpDocumentor\Plugin\Scrybe\Template\Mock\Template')]
			0 ignored issues – show Documentation introduced 2017-05-29 18:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('Mock' => \Mockery...late\\Mock\\Template'))` is of type `array<string,object<Mock...kery\\MockInterface>"}>`, but the function expects a `array<integer,object<php...ate\TemplateInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			);
31
32			$this->assertInstanceOf(
33			'\phpDocumentor\Plugin\Scrybe\Template\Mock\Template',
34			$factory->get('Mock')
35			);
36			}
37
38			/**
39			* Tests whether a Template could be registered using the register method.
40			*
41			* @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::register
42			*/
43			public function testRegisterTemplateEngine()
44			{
45			$factory = new Factory();
46			$factory->register('Mock', m::mock('\phpDocumentor\Plugin\Scrybe\Template\Mock\Template'));
47			$this->assertInstanceOf(
48			'\phpDocumentor\Plugin\Scrybe\Template\Mock\Template',
49			$factory->get('Mock')
50			);
51			}
52
53			/**
54			* @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::register
55			* @expectedException \InvalidArgumentException
56			*/
57			public function testRegisterInvalidName()
58			{
59			$factory = new Factory();
60			$factory->register('', m::mock('\phpDocumentor\Plugin\Scrybe\Template\Mock\Template'));
61			}
62
63			/**
64			* @covers \phpDocumentor\Plugin\Scrybe\Template\Factory::get
65			* @expectedException \InvalidArgumentException
66			*/
67			public function testGetUnknownTemplateEngine()
68			{
69			$factory = new Factory();
70			$factory->get('Mock');
71			}
72			}
73

phpDocumentor / phpDocumentor

Push — develop ( 8eb671...133594 )

Plugin/Scrybe/Template/FactoryTest.php (1 issue)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like