Issues in AppKernel.php - New Issues - Inspection of "Merge pull request #2 from php-translation/base-bu..." - php-translation/cli - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e64fb1...54dcab )

by Tobias

created 2017-08-20 14:06 UTC

app/AppKernel.php (1 issue)

Labels

Best Practice 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\Config\Loader\LoaderInterface;

class AppKernel extends Kernel
{
    private $projectDir;

    public function registerBundles()
    {
        $bundles = [
            new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
            new \Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
            new \Symfony\Bundle\TwigBundle\TwigBundle(),
            new \Symfony\Bundle\WebServerBundle\WebServerBundle(),
            new \Translation\Bundle\TranslationBundle(),
            new \AppBundle\AppBundle(),

            new \Translation\PlatformAdapter\Loco\Bridge\Symfony\TranslationAdapterLocoBundle(),
            new \Translation\PlatformAdapter\Flysystem\Bridge\Symfony\TranslationAdapterFlysystemBundle(),
            new \Translation\PlatformAdapter\PhraseApp\Bridge\Symfony\TranslationAdapterPhraseAppBundle(),
            new \Http\HttplugBundle\HttplugBundle(),
        ];

        return $bundles;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getRootDir()
    {
        return __DIR__;
    }

    public function getCacheDir()
    {
        return sys_get_temp_dir().'/php-translation/var/cache/'.$this->getEnvironment();
    }

    public function getLogDir()
    {
        return sys_get_temp_dir().'/php-translation/var/logs';
    }

    public function registerContainerConfiguration(LoaderInterface $loader)
    {
        $loader->load($this->getRootDir().'/config/config_'.$this->getEnvironment().'.yml');
        $config = getcwd().'/translation.yml';
        if (file_exists($config)) {
            $loader->load($config);
        }
    }

    /**
     * Gets the application root dir (path of the project's LICENSE file).
     *
     * @return string The project root dir
     */
    public function getProjectDir()
    {
        if (null === $this->projectDir) {
            $r = new \ReflectionObject($this);
            $dir = $rootDir = dirname($r->getFileName());
            while (!file_exists($dir.'/LICENSE')) {
                if ($dir === dirname($dir)) {
                    return $this->projectDir = parent::getProjectDir();
                }
                $dir = dirname($dir);
            }
            $this->projectDir = $dir;
        }

        return $this->projectDir;
    }
}


1			<?php
2
3			use Symfony\Component\HttpKernel\Kernel;
4			use Symfony\Component\Config\Loader\LoaderInterface;
5
6			class AppKernel extends Kernel
7			{
8			private $projectDir;
9
10			public function registerBundles()
11			{
12			$bundles = [
13			new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
14			new \Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
15			new \Symfony\Bundle\TwigBundle\TwigBundle(),
16			new \Symfony\Bundle\WebServerBundle\WebServerBundle(),
17			new \Translation\Bundle\TranslationBundle(),
18			new \AppBundle\AppBundle(),
19
20			new \Translation\PlatformAdapter\Loco\Bridge\Symfony\TranslationAdapterLocoBundle(),
21			new \Translation\PlatformAdapter\Flysystem\Bridge\Symfony\TranslationAdapterFlysystemBundle(),
22			new \Translation\PlatformAdapter\PhraseApp\Bridge\Symfony\TranslationAdapterPhraseAppBundle(),
23			new \Http\HttplugBundle\HttplugBundle(),
24			];
25
26			return $bundles;
			0 ignored issues – show Best Practice introduced 2017-08-20 14:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $bundles;` seems to be an `array`, but some of its elements' types (`Http\HttplugBundle\HttplugBundle`) are incompatible with the return type declared by the interface `Symfony\Component\HttpKe...erface::registerBundles` of type `Symfony\Component\HttpKe...undle\BundleInterface[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
27			}
28
29			public function getRootDir()
30			{
31			return __DIR__;
32			}
33
34			public function getCacheDir()
35			{
36			return sys_get_temp_dir().'/php-translation/var/cache/'.$this->getEnvironment();
37			}
38
39			public function getLogDir()
40			{
41			return sys_get_temp_dir().'/php-translation/var/logs';
42			}
43
44			public function registerContainerConfiguration(LoaderInterface $loader)
45			{
46			$loader->load($this->getRootDir().'/config/config_'.$this->getEnvironment().'.yml');
47			$config = getcwd().'/translation.yml';
48			if (file_exists($config)) {
49			$loader->load($config);
50			}
51			}
52
53			/**
54			* Gets the application root dir (path of the project's LICENSE file).
55			*
56			* @return string The project root dir
57			*/
58			public function getProjectDir()
59			{
60			if (null === $this->projectDir) {
61			$r = new \ReflectionObject($this);
62			$dir = $rootDir = dirname($r->getFileName());
63			while (!file_exists($dir.'/LICENSE')) {
64			if ($dir === dirname($dir)) {
65			return $this->projectDir = parent::getProjectDir();
66			}
67			$dir = dirname($dir);
68			}
69			$this->projectDir = $dir;
70			}
71
72			return $this->projectDir;
73			}
74			}
75

php-translation / cli

Push — master ( e64fb1...54dcab )

app/AppKernel.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like