phone2action / ym-api

src/Core/Request.php

Doc Comments +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
      * @method buildBasePayload
      * @author PA
      * @date   2017-01-09
-     * @return SimpleXMLElement  XML Envelope with necessary credential parameters
+     * @return \SimpleXMLElement  XML Envelope with necessary credential parameters
      */
     public function buildBasePayload() : \SimpleXMLElement
     {
@@ -107,8 +107,8 @@ 
      * @method sxmlAppend
      * @author PA
      * @date   2017-01-09
-     * @param  SimpleXMLElement $to
-     * @param  SimpleXMLElement $from
+     * @param  \SimpleXMLElement $to
+     * @param  \SimpleXMLElement $from
      */
     private function sxmlAppend(\SimpleXMLElement $to, \SimpleXMLElement $from)  {
         $toDom = dom_import_simplexml($to);

Spacing +5 added lines, -5 removed lines

@@ -67,10 +67,10 @@ 
     {
 
         $call = new \SimpleXMLElement('<Call></Call>');
-        $call->addAttribute('method',$method);
+        $call->addAttribute('method', $method);
 
         foreach ($arguments as $key => $value) {
-            $call->addChild($key,$value);
+            $call->addChild($key, $value);
         }
 
         return $call;
@@ -79,9 +79,9 @@ 
     public function buildXMLPayload(string $method, array $arguments) : \SimpleXMLElement
     {
         $xml = $this->buildBasePayload();
-        $callPayload = $this->createCallPayload($method,$arguments);
+        $callPayload = $this->createCallPayload($method, $arguments);
 
-        $this->sxmlAppend($xml,$callPayload);
+        $this->sxmlAppend($xml, $callPayload);
 
         return $xml;
     }
@@ -110,7 +110,7 @@ 
      * @param  SimpleXMLElement $to
      * @param  SimpleXMLElement $from
      */
-    private function sxmlAppend(\SimpleXMLElement $to, \SimpleXMLElement $from)  {
+    private function sxmlAppend(\SimpleXMLElement $to, \SimpleXMLElement $from) {
         $toDom = dom_import_simplexml($to);
         $fromDom = dom_import_simplexml($from);
         $toDom->appendChild($toDom->ownerDocument->importNode($fromDom, true));

tests/unit/Core/RequestTest.php

Spacing +8 added lines, -8 removed lines

@@ -11,7 +11,7 @@ 
 
     protected function _before()
     {
-        require_once (__DIR__ . '/../../../vendor/autoload.php'); // Autoload files using Composer autoload
+        require_once (__DIR__.'/../../../vendor/autoload.php'); // Autoload files using Composer autoload
     }
 
     protected function _after()
@@ -22,14 +22,14 @@ 
     public function testBuildBasePayload() {
 
         $apiKey = 'A';
-        $saPasscode  ='B';
+        $saPasscode = 'B';
         $request = new Request($apiKey, $saPasscode);
 
-        $xml =  $request->buildBasePayload();
+        $xml = $request->buildBasePayload();
 
         $this->assertEquals(Request::$API_VERSION, $xml->Version, 'Versions Do Not Match');
         $this->assertEquals($apiKey, $xml->ApiKey, 'API Key Does not Match');
-        $this->assertEquals($saPasscode, $xml->SaPasscode,'Sa Passcode Does not match');
+        $this->assertEquals($saPasscode, $xml->SaPasscode, 'Sa Passcode Does not match');
         $this->assertEquals('1', $xml->CallID, 'Call ID does not match');
 
         codecept_debug($xml->asXML());
@@ -40,7 +40,7 @@ 
     {
         //Setup
         $apiKey = 'A';
-        $saPasscode  ='B';
+        $saPasscode = 'B';
         $method = 'testMethod';
         $arguments = ['arg1' => 'value1', 'arg2' => 'value2'];
         $request = new Request($apiKey, $saPasscode);
@@ -67,17 +67,17 @@ 
     public function testBuildXMLPayload() {
 
         $apiKey = 'A';
-        $saPasscode  ='B';
+        $saPasscode = 'B';
         $method = 'testMethod';
         $arguments = ['arg1' => 'value1', 'arg2' => 'value2'];
         $request = new Request($apiKey, $saPasscode);
 
-        $xml = $request->buildXMLPayload($method,$arguments);
+        $xml = $request->buildXMLPayload($method, $arguments);
         codecept_debug($xml->asXML());
         //Verify
         $this->assertEquals(Request::$API_VERSION, $xml->Version, 'Versions Do Not Match');
         $this->assertEquals($apiKey, $xml->ApiKey, 'API Key Does not Match');
-        $this->assertEquals($saPasscode, $xml->SaPasscode,'Sa Passcode Does not match');
+        $this->assertEquals($saPasscode, $xml->SaPasscode, 'Sa Passcode Does not match');
         $this->assertEquals('1', $xml->CallID, 'Call ID does not match');
 
 

tests/_support/FunctionalTester.php

Indentation +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@
 {
     use _generated\FunctionalTesterActions;
 
-   /**
-    * Define custom actions here
-    */
+    /**
+     * Define custom actions here
+     */
 }

tests/_support/AcceptanceTester.php

Indentation +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@
 {
     use _generated\AcceptanceTesterActions;
 
-   /**
-    * Define custom actions here
-    */
+    /**
+     * Define custom actions here
+     */
 }

tests/_support/UnitTester.php

Indentation +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@
 {
     use _generated\UnitTesterActions;
 
-   /**
-    * Define custom actions here
-    */
+    /**
+     * Define custom actions here
+     */
 }