ProfileController::show() - Code Metrics - Inspection of "Refactor the remote controller into its own page" - phanan/koel - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 8171e5...dc7c6b )

by Phan

created 2017-08-27 15:53 UTC

ProfileController::show() A

↳ Parent: ProfileController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

namespace App\Http\Controllers\API;

use App\Http\Requests\API\ProfileUpdateRequest;
use Hash;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use RuntimeException;

class ProfileController extends Controller
{
    /**
     * Get the current user's profile.
     *
     * @param Request $request
     * 
     * @return JsonResponse
     */
    public function show(Request $request)
    {
        return response()->json($request->user());
    }

    /**
     * Update the current user's profile.
     *
     * @param ProfileUpdateRequest $request
     *
     * @throws RuntimeException
     *
     * @return JsonResponse
     */
    public function update(ProfileUpdateRequest $request)

    {
        $data = $request->only('name', 'email');

        if ($request->password) {
            $data['password'] = Hash::make($request->password);
        }

        return response()->json($request->user()->update($data));
    }
}


1		<?php
2
3		namespace App\Http\Controllers\API;
4
5		use App\Http\Requests\API\ProfileUpdateRequest;
6		use Hash;
7		use Illuminate\Http\JsonResponse;
8		use Illuminate\Http\Request;
9		use RuntimeException;
10
11		class ProfileController extends Controller
12		{
13		/**
14		* Get the current user's profile.
15		*
16		* @param Request $request
17		*
18		* @return JsonResponse
19		*/
20		public function show(Request $request)
21		{
22		return response()->json($request->user());
23		}
24
25		/**
26		* Update the current user's profile.
27		*
28		* @param ProfileUpdateRequest $request
29		*
30		* @throws RuntimeException
31		*
32		* @return JsonResponse
33		*/
34	View Code Duplication	public function update(ProfileUpdateRequest $request)
		0 ignored issues – show Duplication introduced 2017-08-02 07:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$data = $request->only('name', 'email');
37
38		if ($request->password) {
39		$data['password'] = Hash::make($request->password);
40		}
41
42		return response()->json($request->user()->update($data));
43		}
44		}
45

phanan / koel

Push — master ( 8171e5...dc7c6b )

ProfileController::show() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like