patrickpr / trapdirector

library/Trapdirector/Tables/HandlerTable.php

Spacing +16 added lines, -16 removed lines

@@ -28,16 +28,16 @@ 
     
     public function getCurrentURL()
     {
-        return Url::fromPath($this->urlPath . '/handler');
+        return Url::fromPath($this->urlPath.'/handler');
     }
     
     public function renderLine($row)
       {
-          $html = '';
-          $firstCol = true;
+          $html='';
+          $firstCol=true;
                
-          $titleNames = array_keys($this->titles);
-          foreach ($titleNames as $rowkey )
+          $titleNames=array_keys($this->titles);
+          foreach ($titleNames as $rowkey)
           {        
               // Check missing value
               if (property_exists($row, $rowkey))
@@ -52,53 +52,53 @@ 
                           
                           if ($this->doTranslate === true)
                           {
-                              $oidName = $this->MIB->translateOID($row->$rowkey);
+                              $oidName=$this->MIB->translateOID($row->$rowkey);
                               if (isset($oidName['name']))
                               {
                                   $val=$oidName['name'];
                               }
                               else
                               {
-                                  $val = $row->$rowkey;
+                                  $val=$row->$rowkey;
                               }
                           }
                           else
                           {
-                              $val = $row->$rowkey;
+                              $val=$row->$rowkey;
                           }
                           break;
                       case 'host_name': // switch to hostgroup if name is null
                           if ($row->$rowkey == null)
                           {
-                              $val = $row->host_group_name;
+                              $val=$row->host_group_name;
                           }
                           else
                           {
-                              $val = $row->$rowkey;
+                              $val=$row->$rowkey;
                           }
                           break;
                       default:
-                          $val = $row->$rowkey;
+                          $val=$row->$rowkey;
                   }
-                  if ($rowkey == 'trap_oid' && $this->doTranslate===true)
+                  if ($rowkey == 'trap_oid' && $this->doTranslate === true)
                   {
                       
                   }
               } else {
-                  $val = '-';
+                  $val='-';
               }
               if ($firstCol === true) { // Put link in first column for trap detail.
-                  $html .= '<td>'
+                  $html.='<td>'
                       . $this->view->qlink(
                           $this->view->escape($val),
                           Url::fromPath(
-                              $this->urlPath . '/handler/add',
+                              $this->urlPath.'/handler/add',
                               array('ruleid' => $row->id)
                               )
                           )
                           . '</td>';
               } else {
-                  $html .= '<td>' . $this->view->escape($val) . '</td>';
+                  $html.='<td>'.$this->view->escape($val).'</td>';
               }
               $firstCol=false;
               

library/Trapdirector/Tables/TrapDirectorTable.php

Spacing +86 added lines, -86 removed lines

@@ -10,16 +10,16 @@ 
 abstract class TrapDirectorTable
 {
     /** @var array $titles table titles (name, display value) */
-    protected $titles = null;
+    protected $titles=null;
 
     /** @var array $content table content  (name, sb column name). name index must be the same as $titles*/
-    protected $content = null;
+    protected $content=null;
     
     /** @var array $columnNames names of columns for filtering */
-    protected $columnNames = array();
+    protected $columnNames=array();
     
     /** @var Selectable $dbConn connection to database  */
-    protected $dbConn = null;
+    protected $dbConn=null;
     
     /** Current view **/
     protected $view;
@@ -28,39 +28,39 @@ 
     
     // Database stuff
    /** @var array $table (db ref, name) */
-    protected $table = array();
+    protected $table=array();
     
     /** @var Queryable  $query Query in database; */
-    protected $query = null;
+    protected $query=null;
     
     /** @var array $order : (db column, 'ASC' | 'DESC') */
-    protected $order = array();
-    protected $orderQuery = '';
+    protected $order=array();
+    protected $orderQuery='';
     
     /********* Filter ********/
     /** @var string $filterString : string filter for db columns */
-    protected $filterString = '';
+    protected $filterString='';
     
     /** @var array $filterColumn : columns to apply filter to */
-    protected $filterColumn = array();
+    protected $filterColumn=array();
     
     protected $filterQuery='';
     
     /*************** Paging *************/
-    protected $maxPerPage = 25;
+    protected $maxPerPage=25;
     
-    protected $currentPage = 0;
+    protected $currentPage=0;
     
-    function __construct(array $table,array $titles, array $columns, array $columnNames, $dbConn , $view, $urlPath)
+    function __construct(array $table, array $titles, array $columns, array $columnNames, $dbConn, $view, $urlPath)
     {
-        $this->table = $table;
-        $this->titles = $titles;
-        $this->content = $columns;
-        $this->columnNames = $columnNames;
-        $this->dbConn = $dbConn;
+        $this->table=$table;
+        $this->titles=$titles;
+        $this->content=$columns;
+        $this->columnNames=$columnNames;
+        $this->dbConn=$dbConn;
         
-        $this->view = $view;
-        $this->urlPath = $urlPath;
+        $this->view=$view;
+        $this->urlPath=$urlPath;
         
         return $this;
     }
@@ -80,19 +80,19 @@ 
     
     protected function getCurrentURLAndQS(string $caller)
     {
-        $actionURL = $this->getCurrentURL() . '?' ;
+        $actionURL=$this->getCurrentURL().'?';
         $QSList=array();
         if ($caller != 'filter' && $this->curFilterQuery() != '')
-            array_push($QSList , $this->curFilterQuery());
+            array_push($QSList, $this->curFilterQuery());
         
         if ($caller != 'paging' && $caller != 'filter' && $this->curPagingQuery() != '')
-            array_push($QSList , $this->curPagingQuery());
+            array_push($QSList, $this->curPagingQuery());
  
         if ($caller != 'order' && $this->curOrderQuery() != '')
-            array_push($QSList , $this->curOrderQuery());
+            array_push($QSList, $this->curOrderQuery());
         
         if (count($QSList) != 0)
-            $actionURL .=  implode('&', $QSList);
+            $actionURL.=implode('&', $QSList);
         
         return $actionURL;
     }
@@ -104,8 +104,8 @@ 
      */
     public function getBaseQuery()
     {
-        $this->query = $this->dbConn->select();
-        $this->query = $this->query->from(
+        $this->query=$this->dbConn->select();
+        $this->query=$this->query->from(
             $this->table,
             $this->content
             );
@@ -137,7 +137,7 @@ 
         {
             if ($filter != "") $filter.=' OR ';
             //$filter .= "'" . $column . "' LIKE '%" . $this->filterString. "%'";
-            $filter .= $column  . " LIKE '%" . $this->filterString. "%'";
+            $filter.=$column." LIKE '%".$this->filterString."%'";
         }
         //echo $filter;
         
@@ -148,8 +148,8 @@ 
 
     public function setFilter(string $filter, array $filterCol)
     {
-        $this->filterString = $filter;
-        $this->filterColumn = $filterCol;
+        $this->filterString=$filter;
+        $this->filterColumn=$filterCol;
         return $this;
     }
 
@@ -172,7 +172,7 @@ 
     {
         if (isset($getVars['f']))
         {
-            $this->filterQuery = $getVars['f'];
+            $this->filterQuery=$getVars['f'];
             $this->setFilter(html_entity_decode($getVars['f']), $this->columnNames);
         }
     }
@@ -195,16 +195,16 @@ 
         {
             if ($orderSQL != "") $orderSQL.=',';
             
-            $orderSQL .= $column . ' ' . $direction;
+            $orderSQL.=$column.' '.$direction;
         }
-        $this->query = $this->query->order($orderSQL);
+        $this->query=$this->query->order($orderSQL);
         
         return $this;
     }
     
     public function setOrder(array $order)
     {
-        $this->order = $order;
+        $this->order=$order;
         return $this;
     }
     
@@ -212,7 +212,7 @@ 
     {
         if (isset($getVars['o']))
         {
-            $this->orderQuery = $getVars['o'];
+            $this->orderQuery=$getVars['o'];
             // TODO
         }
     }
@@ -226,8 +226,8 @@ 
     /*****************  Paging and counting *********/
     public function countQuery()
     {
-        $this->query = $this->dbConn->select();
-        $this->query = $this->query
+        $this->query=$this->dbConn->select();
+        $this->query=$this->query
             ->from(
                 $this->table,
                 array('COUNT(*)')
@@ -243,14 +243,14 @@ 
     
     public function setMaxPerPage(int $max)
     {
-        $this->maxPerPage = $max;
+        $this->maxPerPage=$max;
     }
     
     protected function getPagingQuery(array $getVars)
     {
         if (isset($getVars['page']))
         {
-            $this->currentPage = $getVars['page'];
+            $this->currentPage=$getVars['page'];
         }
     }
 
@@ -262,22 +262,22 @@ 
     
     public function renderPagingHeader()
     {
-        $count = $this->count();
-        if ($count <= $this->maxPerPage )
+        $count=$this->count();
+        if ($count <= $this->maxPerPage)
         {
-            return  'count : ' . $this->count() . '<br>';
+            return  'count : '.$this->count().'<br>';
         }
         
-        if ($this->currentPage == 0) $this->currentPage = 1;
+        if ($this->currentPage == 0) $this->currentPage=1;
         
-        $numPages = intdiv($count , $this->maxPerPage);
-        if ($count % $this->maxPerPage != 0 ) $numPages++;
+        $numPages=intdiv($count, $this->maxPerPage);
+        if ($count % $this->maxPerPage != 0) $numPages++;
         
-        $html = '<div class="pagination-control" role="navigation">';
-        $html .= '<ul class="nav tab-nav">';
-        if ($this->currentPage <=1)
+        $html='<div class="pagination-control" role="navigation">';
+        $html.='<ul class="nav tab-nav">';
+        if ($this->currentPage <= 1)
         {
-            $html .= '
+            $html.='
                 <li class="nav-item disabled" aria-hidden="true">
                     <span class="previous-page">
                             <span class="sr-only">Previous page</span>
@@ -288,24 +288,24 @@ 
         }
         else 
         {
-            $html .= '
+            $html.='
                 <li class="nav-item">
-                    <a href="'. $this->getCurrentURLAndQS('paging') .'&page='. ($this->currentPage - 1 ).'" class="previous-page" >
+                    <a href="'. $this->getCurrentURLAndQS('paging').'&page='.($this->currentPage - 1).'" class="previous-page" >
                             <i aria-hidden="true" class="icon-angle-double-left"></i>            
                      </a>
                 </li>
             ';
         }
         
-        for ($i=1; $i <= $numPages ; $i++)
+        for ($i=1; $i <= $numPages; $i++)
         {
-            $active = ($this->currentPage == $i) ? 'active' : '';
-            $first = ($i-1)*$this->maxPerPage+1;
-            $last = $i * $this->maxPerPage;
-            if ($last > $count) $last = $count;
-            $display = 'Show rows '. $first . ' to '. $last .' of '. $count;
-            $html .= '<li class="' . $active . ' nav-item">
-                    <a href="'. $this->getCurrentURLAndQS('paging') .'&page='. $i .'" title="' . $display . '" aria-label="' . $display . '">
+            $active=($this->currentPage == $i) ? 'active' : '';
+            $first=($i - 1) * $this->maxPerPage + 1;
+            $last=$i * $this->maxPerPage;
+            if ($last > $count) $last=$count;
+            $display='Show rows '.$first.' to '.$last.' of '.$count;
+            $html.='<li class="'.$active.' nav-item">
+                    <a href="'. $this->getCurrentURLAndQS('paging').'&page='.$i.'" title="'.$display.'" aria-label="'.$display.'">
                     '.$i.'                
                     </a>
                 </li>';
@@ -313,7 +313,7 @@ 
         
         if ($this->currentPage == $numPages)
         {
-            $html .= '
+            $html.='
                 <li class="nav-item disabled" aria-hidden="true">
                     <span class="previous-page">
                             <span class="sr-only">Previous page</span>
@@ -324,18 +324,18 @@ 
         }
         else
         {
-            $html .= '
+            $html.='
                 <li class="nav-item">
-                    <a href="'. $this->getCurrentURLAndQS('paging') .'&page='. ($this->currentPage + 1 ).'" class="next-page">
+                    <a href="'. $this->getCurrentURLAndQS('paging').'&page='.($this->currentPage + 1).'" class="next-page">
                             <i aria-hidden="true" class="icon-angle-double-right"></i>
                      </a>
                 </li>
             ';
         }
         
-        $html .= '</ul> </div>';
+        $html.='</ul> </div>';
         
-        $htmlOLD = '
+        $htmlOLD='
             <ul class="nav tab-nav">
 
                 <li class="active nav-item">
@@ -360,60 +360,60 @@ 
     
     public function applyPaging()
     {
-        $this->query->limitPage($this->currentPage,$this->maxPerPage);
+        $this->query->limitPage($this->currentPage, $this->maxPerPage);
         return $this;
     }
     
     /*************** Rendering *************************/
     public function renderTitles()
     {
-        $html = "<thead>\n<tr>\n";
+        $html="<thead>\n<tr>\n";
         foreach ($this->titles as $values)
         {
-            $html .= '<th>' . $values . '</th>';            
+            $html.='<th>'.$values.'</th>';            
         }
-        $html .= "</tr>\n</thead>\n";
+        $html.="</tr>\n</thead>\n";
         return $html;
     }
     
-    public function renderLine( $value)
+    public function renderLine($value)
     {
-        $html = '';
-        $titleNames = array_keys($this->titles);
-        foreach ($titleNames as $name )
+        $html='';
+        $titleNames=array_keys($this->titles);
+        foreach ($titleNames as $name)
         {
-            $html .= '<td>';
-            $html .= $value->$name;
-            $html .= "</td>\n";
+            $html.='<td>';
+            $html.=$value->$name;
+            $html.="</td>\n";
         }
         return $html;
     }
     
     public function renderTable(array $values)
     {
-       $html = '<tbody id="obj_table_body">';
-       foreach($values as $value)
+       $html='<tbody id="obj_table_body">';
+       foreach ($values as $value)
        {
-           $html .= "<tr>\n";
-           $html .= $this->renderLine($value);
-           $html .= "</tr>\n";
+           $html.="<tr>\n";
+           $html.=$this->renderLine($value);
+           $html.="</tr>\n";
        }
-       $html .= '</tbody>';
+       $html.='</tbody>';
        return $html;
     }
     
     public function render()
     {
-        $html = '';
+        $html='';
         
         
-        $values = $this->fullQuery();
+        $values=$this->fullQuery();
         
         $html.="<table class='simple common-table table-row-selectable'>\n";
         
-        $html .= $this->renderTitles();
-        $html .= $this->renderTable($values);
-        $html .= '</table>'; 
+        $html.=$this->renderTitles();
+        $html.=$this->renderTable($values);
+        $html.='</table>'; 
         
 
         return $html;

application/controllers/HandlerController.php

Spacing +83 added lines, -83 removed lines

@@ -24,10 +24,10 @@ 
 		$this->checkReadPermission();
 		$this->prepareTabs()->activate('status');
 
-		$dbConn = $this->getUIDatabase()->getDb();
+		$dbConn=$this->getUIDatabase()->getDb();
 		if ($dbConn === null) throw new \ErrorException('uncatched db error');
 		
-		$this->view->handlerTable = new HandlerTable(
+		$this->view->handlerTable=new HandlerTable(
 		      $this->moduleConfig->getTrapRuleName(),
 		      $this->moduleConfig->getHandlerListTitles(),
 		      $this->moduleConfig->getHandlerListDisplayColumns(),
@@ -36,7 +36,7 @@ 
 		      $this->view,
 		      $this->moduleConfig->urlPath());
 		
-		$getVars = $this->getRequest()->getParams();		
+		$getVars=$this->getRequest()->getParams();		
 		$this->view->handlerTable->getParams($getVars);
 		
 		//$this->view->handlerTable->setFilter('127.0.0.1',array('ip4'));
@@ -48,10 +48,10 @@ 
 		$this->getHandlerListTable()->setConnection($dbConn);
 		$this->getHandlerListTable()->setMibloader($this->getMIB());
 		// Apply pagination limits 
-		$this->view->table=$this->applyPaginationLimits($this->getHandlerListTable(),$this->getModuleConfig()->itemListDisplay());		
+		$this->view->table=$this->applyPaginationLimits($this->getHandlerListTable(), $this->getModuleConfig()->itemListDisplay());		
 		
 		// Set Filter
-		$this->view->filterEditor = $this->getHandlerListTable()->getFilterEditor($this->getRequest());		
+		$this->view->filterEditor=$this->getHandlerListTable()->getFilterEditor($this->getRequest());		
 	
 		//$this->displayExitError('Handler/indexAction','Not implemented');
 	}
@@ -61,7 +61,7 @@ 
 	public function testruleAction()
 	{
 	    $this->checkReadPermission();
-	    $this->getTabs()->add('get',array(
+	    $this->getTabs()->add('get', array(
 	        'active'	=> true,
 	        'label'		=> $this->translate('Test Rule'),
 	        'url'		=> Url::fromRequest()
@@ -70,7 +70,7 @@ 
 
 	    if ($this->params->get('rule') !== null) 
 	    {
-	        $this->view->rule= $this->params->get('rule');
+	        $this->view->rule=$this->params->get('rule');
 	    }
 	    else
 	    {
@@ -129,12 +129,12 @@ 
 	    }
 	    catch (Exception $e)
 	    {
-	        $this->displayExitError('Add handler : get host by IP/Name ',$e->getMessage());
+	        $this->displayExitError('Add handler : get host by IP/Name ', $e->getMessage());
 	    }
 	    
 	    
 	    // if one unique host found -> put id text input
-	    if (count($hosts)==1) {
+	    if (count($hosts) == 1) {
 	        $this->view->hostname=$hosts[0]->name;
 	        //$hostid=$hosts[0]->id;
 	        // Tell JS to get services when page is loaded
@@ -143,9 +143,9 @@ 
 	    }
 	    else
 	    {
-	        foreach($hosts as $key=>$val)
+	        foreach ($hosts as $key=>$val)
 	        {
-	            array_push($this->view->hostlist,$hosts[$key]->name);
+	            array_push($this->view->hostlist, $hosts[$key]->name);
 	        }
 	    }
 	    
@@ -184,18 +184,18 @@ 
 	            $currentObjectTypeEnum
 	        );
 	        $oid_index++;
-	        array_push($this->view->objectList,$currentObject);
+	        array_push($this->view->objectList, $currentObject);
 	        // set currrent object to null in allObjects
 	        if (isset($allObjects[$val->oid]))
 	        {
 	            $allObjects[$val->oid]=null;
 	        }
 	    }
-	    if ($allObjects!=null) // in case trap doesn't have objects or is not resolved
+	    if ($allObjects != null) // in case trap doesn't have objects or is not resolved
 	    {
 	        foreach ($allObjects as $key => $val)
 	        {
-	            if ($val==null) { continue; }
+	            if ($val == null) { continue; }
 	            array_push($this->view->objectList, array(
 	                $oid_index,
 	                $key,
@@ -223,9 +223,9 @@ 
 	    // Check if hostname still exists
 	    $host_get=$this->getUIDatabase()->getHostByName($this->view->hostname);
 	    
-	    if (count($host_get)==0)
+	    if (count($host_get) == 0)
 	    {
-	        $this->view->warning_message='Host '.$this->view->hostname. ' doesn\'t exists anymore';
+	        $this->view->warning_message='Host '.$this->view->hostname.' doesn\'t exists anymore';
 	        $this->view->serviceGet=false;
 	    }
 	    else
@@ -233,10 +233,10 @@ 
 	        // Tell JS to get services when page is loaded
 	        $this->view->serviceGet=true;
 	        // get service id for form to set :
-	        $serviceID=$this->getUIDatabase()->getServiceIDByName($this->view->hostname,$ruleDetail->service_name);
-	        if (count($serviceID) ==0)
+	        $serviceID=$this->getUIDatabase()->getServiceIDByName($this->view->hostname, $ruleDetail->service_name);
+	        if (count($serviceID) == 0)
 	        {
-	            $this->view->warning_message=' Service '.$ruleDetail->service_name. ' doesn\'t exists anymore';
+	            $this->view->warning_message=' Service '.$ruleDetail->service_name.' doesn\'t exists anymore';
 	        }
 	        else
 	        {
@@ -253,9 +253,9 @@ 
 	{
 	    // Check if groupe exists
 	    $group_get=$this->getUIDatabase()->getHostGroupByName($this->view->hostgroupname);
-	    if (count($group_get)==0)
+	    if (count($group_get) == 0)
 	    {
-	        $this->view->warning_message='HostGroup '.$this->view->hostgroupname. ' doesn\'t exists anymore';
+	        $this->view->warning_message='HostGroup '.$this->view->hostgroupname.' doesn\'t exists anymore';
 	        $this->view->serviceGroupGet=false;
 	    }
 	    else
@@ -273,9 +273,9 @@ 
 	        
 	        // Tell JS to get services when page is loaded
 	        $this->view->serviceGroupGet=true;
-	        if ($foundGrpService==0)
+	        if ($foundGrpService == 0)
 	        {
-	            $this->view->warning_message.=' Service '.$ruleDetail->service_name. ' doesn\'t exists anymore';
+	            $this->view->warning_message.=' Service '.$ruleDetail->service_name.' doesn\'t exists anymore';
 	        }
 	    }
 	}
@@ -293,12 +293,12 @@ 
 	    $index=1;
 	    // check in display & rule for : OID(<oid>)
 	    $matches=array();
-	    while ( preg_match('/_OID\(([\.0-9\*]+)\)/',$display,$matches) ||
-	        preg_match('/_OID\(([\.0-9\*]+)\)/',$rule,$matches))
+	    while (preg_match('/_OID\(([\.0-9\*]+)\)/', $display, $matches) ||
+	        preg_match('/_OID\(([\.0-9\*]+)\)/', $rule, $matches))
 	    {
 	        $curOid=$matches[1];
 	        
-	        if ( (preg_match('/\*/',$curOid) == 0 ) 
+	        if ((preg_match('/\*/', $curOid) == 0) 
 	            && ($object=$this->getMIB()->translateOID($curOid)) != null)
 	        {
 	            array_push($curObjectList, array(
@@ -323,9 +323,9 @@ 
 	                'not found'
 	            ));
 	        }
-	        $curOid = preg_replace('/\*/','\*',$curOid);
-	        $display=preg_replace('/_OID\('.$curOid.'\)/','\$'.$index.'\$',$display);
-	        $rule=preg_replace('/_OID\('.$curOid.'\)/','\$'.$index.'\$',$rule);
+	        $curOid=preg_replace('/\*/', '\*', $curOid);
+	        $display=preg_replace('/_OID\('.$curOid.'\)/', '\$'.$index.'\$', $display);
+	        $rule=preg_replace('/_OID\('.$curOid.'\)/', '\$'.$index.'\$', $rule);
 	        $index++;
 	    }
 	    return $curObjectList;
@@ -340,7 +340,7 @@ 
 		$this->checkConfigPermission();
 		// set up tab
 		$this->prepareTabs();
-		$this->getTabs()->add('get',array(
+		$this->getTabs()->add('get', array(
 			'active'	=> true,
 			'label'		=> $this->translate('Add handler'),
 			'url'		=> Url::fromRequest()
@@ -353,7 +353,7 @@ 
 		
 		//$this->view->trapvalues=false; // Set to true to display 'value' colum in objects
 		
-		if (($trapid = $this->params->get('fromid')) !== null) {
+		if (($trapid=$this->params->get('fromid')) !== null) {
 		    /********** Setup from existing trap ***************/
             $this->add_from_existing($trapid);
 			return;
@@ -373,7 +373,7 @@ 
 			$this->view->setRuleMatch=$ruleDetail->action_match;
 			$this->view->setRuleNoMatch=$ruleDetail->action_nomatch;
 			$this->view->hostgroupname=$ruleDetail->host_group_name;
-			$this->view->modified=gmdate("Y-m-d\TH:i:s\Z",$ruleDetail->modified);
+			$this->view->modified=gmdate("Y-m-d\TH:i:s\Z", $ruleDetail->modified);
 			$this->view->modifier=$ruleDetail->modifier;
 			
 			// Warning message if host/service don't exists anymore
@@ -425,26 +425,26 @@ 
 	
 		$params=array(
 			// id (also db) => 	array('post' => post id, 'val' => default val, 'db' => send to table)
-			'hostgroup'		=>	array('post' => 'hostgroup',                    'db'=>false),
-			'db_rule'		=>	array('post' => 'db_rule',                      'db'=>false),
-			'hostid'		=>	array('post' => 'hostid',                       'db'=>false),
-			'host_name'		=>	array('post' => 'hostname',      'val' => null,  'db'=>true),
-			'host_group_name'=>	array('post' => null,            'val' => null,  'db'=>true),
-			'serviceid'		=>	array('post' => 'serviceid',                     'db'=>false),
-			'service_name'	=>	array('post' => 'serviceName',                    'db'=>true),
-			'trap_oid'		=>	array('post' => 'oid',                            'db'=>true),
-			'revert_ok'		=>	array('post' => 'revertOK',      'val' => 0,      'db'=>true),
-			'display'		=>	array('post' => 'display',        'val' => '',     'db'=>true),
-			'rule'			=>	array('post' => 'rule',          'val' => '',        'db'=>true),			
-			'action_match'	=>	array('post' => 'ruleMatch',       'val' => -1,    'db'=>true),
-			'action_nomatch'=>	array('post' => 'ruleNoMatch',    'val' => -1,    'db'=>true),					
-			'ip4'			=>	array('post' => null,             'val' => null,  'db'=>true),
-			'ip6'			=>	array('post' => null,             'val' => null,  'db'=>true),
-		    'action_form'	=>	array('post' => 'action_form',    'val' => null, 'db'=>false)
+			'hostgroup'		=>	array('post' => 'hostgroup', 'db'=>false),
+			'db_rule'		=>	array('post' => 'db_rule', 'db'=>false),
+			'hostid'		=>	array('post' => 'hostid', 'db'=>false),
+			'host_name'		=>	array('post' => 'hostname', 'val' => null, 'db'=>true),
+			'host_group_name'=>	array('post' => null, 'val' => null, 'db'=>true),
+			'serviceid'		=>	array('post' => 'serviceid', 'db'=>false),
+			'service_name'	=>	array('post' => 'serviceName', 'db'=>true),
+			'trap_oid'		=>	array('post' => 'oid', 'db'=>true),
+			'revert_ok'		=>	array('post' => 'revertOK', 'val' => 0, 'db'=>true),
+			'display'		=>	array('post' => 'display', 'val' => '', 'db'=>true),
+			'rule'			=>	array('post' => 'rule', 'val' => '', 'db'=>true),			
+			'action_match'	=>	array('post' => 'ruleMatch', 'val' => -1, 'db'=>true),
+			'action_nomatch'=>	array('post' => 'ruleNoMatch', 'val' => -1, 'db'=>true),					
+			'ip4'			=>	array('post' => null, 'val' => null, 'db'=>true),
+			'ip6'			=>	array('post' => null, 'val' => null, 'db'=>true),
+		    'action_form'	=>	array('post' => 'action_form', 'val' => null, 'db'=>false)
 		);
 		
 		if (isset($postData[$params['action_form']['post']]) 
-			&& $postData[$params['action_form']['post']] == 'delete' )
+			&& $postData[$params['action_form']['post']] == 'delete')
 		{
 			try
 			{
@@ -464,16 +464,16 @@ 
 		}		
 		foreach (array_keys($params) as $key)
 		{
-			if ($params[$key]['post']==null) continue; // data not sent in post vars
-			if (! isset($postData[$params[$key]['post']]))
+			if ($params[$key]['post'] == null) continue; // data not sent in post vars
+			if (!isset($postData[$params[$key]['post']]))
 			{
 				// should not happen as the js checks data
-				$this->_helper->json(array('status'=>'No ' . $key));
+				$this->_helper->json(array('status'=>'No '.$key));
 			}
 			else
 			{
 				$data=$postData[$params[$key]['post']];
-				if ($data!=null && $data !="")
+				if ($data != null && $data != "")
 				{
 					$params[$key]['val']=$postData[$params[$key]['post']];
 				}
@@ -482,8 +482,8 @@ 
 
 		try 
 		{
-			$isHostGroup=($params['hostgroup']['val'] == 1)?true:false;
-			if (! $isHostGroup ) 
+			$isHostGroup=($params['hostgroup']['val'] == 1) ?true:false;
+			if (!$isHostGroup) 
 			{  // checks if selection by host 
 			    $hostAddr=$this->getUIDatabase()->getHostInfoByID($params['hostid']['val']);
 				$params['ip4']['val']=$hostAddr->ip4;
@@ -496,7 +496,7 @@ 
 				}
 				if (!is_numeric($params['serviceid']['val']))
 				{
-				    $this->_helper->json(array('status'=>"Invalid service id ". $params['serviceid']['val']));
+				    $this->_helper->json(array('status'=>"Invalid service id ".$params['serviceid']['val']));
 				    return;
 				}
 				$serviceName=$this->getUIDatabase()->getObjectNameByid($params['serviceid']['val']);
@@ -515,15 +515,15 @@ 
 					return;					
 				}
 				// Put param in correct column (group_name)
-				$params['host_group_name']['val'] = $params['host_name']['val'];
+				$params['host_group_name']['val']=$params['host_name']['val'];
 				$params['host_name']['val']=null;
 			}
 			$dbparams=array();
 			foreach ($params as $key=>$val)
 			{
-				if ($val['db']==true )
+				if ($val['db'] == true)
 				{
-					$dbparams[$key] = $val['val'];
+					$dbparams[$key]=$val['val'];
 				}
 			}
 			// echo '<br>';	print_r($dbparams);echo '<br>';
@@ -534,7 +534,7 @@ 
 			}
 			else
 			{
-			    $this->getUIDatabase()->updateHandlerRule($dbparams,$params['db_rule']['val']);
+			    $this->getUIDatabase()->updateHandlerRule($dbparams, $params['db_rule']['val']);
 				$ruleID=$params['db_rule']['val'];
 			}
 		}
@@ -553,10 +553,10 @@ 
 	*/
 	protected function getTrapDetail($trapid) 
 	{
-		if (!preg_match('/^[0-9]+$/',$trapid)) { throw new Exception('Invalid id');  }
+		if (!preg_match('/^[0-9]+$/', $trapid)) { throw new Exception('Invalid id'); }
 		$queryArray=$this->getModuleConfig()->trapDetailQuery();
 		
-		$dbConn = $this->getUIDatabase()->getDbConn();
+		$dbConn=$this->getUIDatabase()->getDbConn();
 		if ($dbConn === null) throw new \ErrorException('uncatched db error');
 		// ***************  Get main data
 		// extract columns and titles;
@@ -566,19 +566,19 @@ 
 		}
 		try
 		{		
-		    $query = $dbConn->select()
-				->from($this->getModuleConfig()->getTrapTableName(),$elmts)
-				->where('id=?',$trapid);
+		    $query=$dbConn->select()
+				->from($this->getModuleConfig()->getTrapTableName(), $elmts)
+				->where('id=?', $trapid);
 				$trapDetail=$dbConn->fetchRow($query);
-			if ( $trapDetail == null ) 
+			if ($trapDetail == null) 
 			{
-			    $trapDetail = 'NULL';
+			    $trapDetail='NULL';
 			    throw new Exception('No traps was found with id = '.$trapid);
 			}
 		}
 		catch (Exception $e)
 		{
-			$this->displayExitError('Add handler : get trap detail returning : '.print_r($trapDetail,true),$e->getMessage());
+			$this->displayExitError('Add handler : get trap detail returning : '.print_r($trapDetail, true), $e->getMessage());
 			return;
 		}
 
@@ -592,10 +592,10 @@ 
 	*/
 	protected function getTrapobjects($trapid)
 	{	
-		if (!preg_match('/^[0-9]+$/',$trapid)) { throw new Exception('Invalid id');  }
+		if (!preg_match('/^[0-9]+$/', $trapid)) { throw new Exception('Invalid id'); }
 		$queryArrayData=$this->getModuleConfig()->trapDataDetailQuery();
 		
-		$dbConn = $this->getUIDatabase()->getDbConn();
+		$dbConn=$this->getUIDatabase()->getDbConn();
 		if ($dbConn === null) throw new \ErrorException('uncatched db error');
 		// ***************  Get object data
 		// extract columns and titles;
@@ -605,15 +605,15 @@ 
 		}
 		try
 		{		
-		    $query = $dbConn->select()
-				->from($this->moduleConfig->getTrapDataTableName(),$data_elmts)
-				->where('trap_id=?',$trapid);
+		    $query=$dbConn->select()
+				->from($this->moduleConfig->getTrapDataTableName(), $data_elmts)
+				->where('trap_id=?', $trapid);
 				$trapDetail=$dbConn->fetchAll($query);
 			// if ( $trapDetail == null ) throw new Exception('No traps was found with id = '.$trapid);
 		}
 		catch (Exception $e)
 		{
-			$this->displayExitError('Add handler : get trap data detail : ',$e->getMessage());
+			$this->displayExitError('Add handler : get trap data detail : ', $e->getMessage());
 			return array();
 		}
 
@@ -627,24 +627,24 @@ 
 	*/
 	protected function getRuleDetail($ruleid) 
 	{
-		if (!preg_match('/^[0-9]+$/',$ruleid)) { throw new Exception('Invalid id');  }
+		if (!preg_match('/^[0-9]+$/', $ruleid)) { throw new Exception('Invalid id'); }
 		$queryArray=$this->getModuleConfig()->ruleDetailQuery();
 		
-		$dbConn = $this->getUIDatabase()->getDbConn();
+		$dbConn=$this->getUIDatabase()->getDbConn();
 		if ($dbConn === null) throw new \ErrorException('uncatched db error');
 		// ***************  Get main data
 		try
 		{		
-		    $query = $dbConn->select()
-				->from($this->getModuleConfig()->getTrapRuleName(),$queryArray)
-				->where('id=?',$ruleid);
+		    $query=$dbConn->select()
+				->from($this->getModuleConfig()->getTrapRuleName(), $queryArray)
+				->where('id=?', $ruleid);
 			$ruleDetail=$dbConn->fetchRow($query);
-			if ( $ruleDetail == null ) throw new Exception('No rule was found with id = '.$ruleid);
+			if ($ruleDetail == null) throw new Exception('No rule was found with id = '.$ruleid);
 		}
 		catch (Exception $e)
 		{
-			$this->displayExitError('Update handler : get rule detail',$e->getMessage());
-			throw new Exception('Error : ' . $e->getMessage());
+			$this->displayExitError('Update handler : get rule detail', $e->getMessage());
+			throw new Exception('Error : '.$e->getMessage());
 		}
 
 		return $ruleDetail;
@@ -657,7 +657,7 @@ 
 	{
 		return $this->getTabs()->add('status', array(
 			'label' => $this->translate('Trap handlers'),
-			'url'   => $this->getModuleConfig()->urlPath() . '/handler')
+			'url'   => $this->getModuleConfig()->urlPath().'/handler')
 		);
 	}