pamil / Sylius

tests/Controller/CustomerApiTest.php

Spacing +9 added lines, -9 removed lines

@@ -187,7 +187,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('GET', '/api/customers/'.$customers['customer_Barry']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/customers/' . $customers['customer_Barry']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/show_response', Response::HTTP_OK);
@@ -201,7 +201,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('GET', '/api/customers/'.$customers['customer_Roy']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/customers/' . $customers['customer_Roy']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/show_with_user_response', Response::HTTP_OK);
@@ -239,7 +239,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('PUT', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('PUT', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/update_validation_fail_response', Response::HTTP_BAD_REQUEST);
@@ -263,12 +263,12 @@ 
         }
 EOT;
 
-        $this->client->request('PUT', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
+        $this->client->request('PUT', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/update_response', Response::HTTP_OK);
@@ -303,12 +303,12 @@ 
         }
 EOT;
 
-        $this->client->request('PATCH', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
+        $this->client->request('PATCH', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'customer/partial_update_response', Response::HTTP_OK);
@@ -346,12 +346,12 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $customers = $this->loadFixturesFromFile('resources/customers.yml');
 
-        $this->client->request('DELETE', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('DELETE', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/customers/' . $customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -73,7 +73,7 @@ 
                 "enabled": "true"
             }
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/customers/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -96,7 +96,7 @@ 
             "email": "john.diggle@yahoo.com",
             "gender": "m"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/customers/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -122,7 +122,7 @@ 
                 "plainPassword" : "testPassword"
             }
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/api/customers/', [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -261,7 +261,7 @@ 
             "email": "john.diggle@example.com",
             "gender": "m"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
@@ -301,7 +301,7 @@ 
             "firstName": "John",
             "lastName": "Doe"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', '/api/customers/'.$customers['customer_Oliver']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 

tests/Controller/LocaleApiTest.php

Spacing +3 added lines, -3 removed lines

@@ -62,7 +62,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $locales = $this->loadFixturesFromFile('resources/locales.yml');
 
-        $this->client->request('GET', '/api/locales/'.$locales['locale_en']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/locales/' . $locales['locale_en']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'locale/show_response', Response::HTTP_OK);
@@ -130,12 +130,12 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $locales = $this->loadFixturesFromFile('resources/locales.yml');
 
-        $this->client->request('DELETE', '/api/locales/'.$locales['locale_en']->getId(), [], [], static::$authorizedHeaderWithContentType, []);
+        $this->client->request('DELETE', '/api/locales/' . $locales['locale_en']->getId(), [], [], static::$authorizedHeaderWithContentType, []);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/locales/'.$locales['locale_en']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/locales/' . $locales['locale_en']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -91,6 +91,6 @@
 
   <info>php %command.full_name% web --symlink --relative</info>
 
-EOT;
+eot;
     }
 }

tests/Controller/CurrencyApiTest.php

Spacing +8 added lines, -8 removed lines

@@ -122,7 +122,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $currencies = $this->loadFixturesFromFile('resources/currencies.yml');
 
-        $this->client->request('GET', '/api/currencies/'.$currencies['currency_1']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/currencies/' . $currencies['currency_1']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'currency/show_response', Response::HTTP_OK);
@@ -151,7 +151,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $currencies = $this->loadFixturesFromFile('resources/currencies.yml');
 
-        $this->client->request('PUT', '/api/currencies/'.$currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('PUT', '/api/currencies/' . $currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
 
@@ -172,12 +172,12 @@ 
         }
 EOT;
 
-        $this->client->request('PUT', '/api/currencies/'.$currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
+        $this->client->request('PUT', '/api/currencies/' . $currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/currencies/'.$currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/currencies/' . $currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'currency/update_response', Response::HTTP_OK);
@@ -206,12 +206,12 @@ 
         }
 EOT;
 
-        $this->client->request('PATCH', '/api/currencies/'.$currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
+        $this->client->request('PATCH', '/api/currencies/' . $currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithContentType, $data);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/currencies/'.$currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/currencies/' . $currencies['currency_2']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'currency/update_response', Response::HTTP_OK);
@@ -232,12 +232,12 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $currencies = $this->loadFixturesFromFile('resources/currencies.yml');
 
-        $this->client->request('DELETE', '/api/currencies/'.$currencies['currency_1']->getId(), [], [], static::$authorizedHeaderWithContentType, []);
+        $this->client->request('DELETE', '/api/currencies/' . $currencies['currency_1']->getId(), [], [], static::$authorizedHeaderWithContentType, []);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/currencies/'.$currencies['currency_1']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/currencies/' . $currencies['currency_1']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
             },
             "author": "Christie Golden"
         }
-EOT;
+eot;
 
         $this->client->request('POST', '/books/', [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -61,7 +61,7 @@ 
             },
             "author": "Christie Golden"
         }
-EOT;
+eot;
 
         $this->client->request('PUT', '/books/'. $objects["book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();
@@ -80,7 +80,7 @@ 
         {
             "author": "Christie Golden"
         }
-EOT;
+eot;
 
         $this->client->request('PATCH', '/books/'. $objects["book1"]->getId(), [], [], ['CONTENT_TYPE' => 'application/json'], $data);
         $response = $this->client->getResponse();

tests/Controller/ProvinceApiTest.php

Spacing +3 added lines, -3 removed lines

@@ -40,7 +40,7 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $countryData = $this->loadFixturesFromFile('resources/countries.yml');
 
-        $this->client->request('GET', '/api/countries/'.$countryData['country_BE']->getId().'/provinces/'.$countryData['province_BE_limburg']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('GET', '/api/countries/' . $countryData['country_BE']->getId() . '/provinces/' . $countryData['province_BE_limburg']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'province/show_response', Response::HTTP_OK);
@@ -51,12 +51,12 @@ 
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $countryData = $this->loadFixturesFromFile('resources/countries.yml');
 
-        $this->client->request('DELETE', '/api/countries/'.$countryData['country_BE']->getId().'/provinces/'.$countryData['province_BE_limburg']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('DELETE', '/api/countries/' . $countryData['country_BE']->getId() . '/provinces/' . $countryData['province_BE_limburg']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponseCode($response, Response::HTTP_NO_CONTENT);
 
-        $this->client->request('GET', '/api/countries/'.$countryData['country_BE']->getId().'/provinces/'.$countryData['province_BE_limburg']->getId(), [], [], static::$authorizedHeaderWithContentType);
+        $this->client->request('GET', '/api/countries/' . $countryData['country_BE']->getId() . '/provinces/' . $countryData['province_BE_limburg']->getId(), [], [], static::$authorizedHeaderWithContentType);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'error/not_found_response', Response::HTTP_NOT_FOUND);

tests/Controller/CountryApiTest.php

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
         $this->loadFixturesFromFile('authentication/api_administrator.yml');
         $countries = $this->loadFixturesFromFile('resources/countries.yml');
 
-        $this->client->request('GET', '/api/countries/'.$countries['country_NL']->getId(), [], [], static::$authorizedHeaderWithAccept);
+        $this->client->request('GET', '/api/countries/' . $countries['country_NL']->getId(), [], [], static::$authorizedHeaderWithAccept);
 
         $response = $this->client->getResponse();
         $this->assertResponse($response, 'country/show_response', Response::HTTP_OK);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -91,6 +91,6 @@
 
   <info>php %command.full_name% web --symlink --relative</info>
 
-EOT;
+eot;
     }
 }

src/Sylius/Behat/Context/Setup/OrderContext.php

Spacing +3 added lines, -3 removed lines

@@ -310,7 +310,7 @@ 
     {
         $customer = $user->getCustomer();
         for ($i = 0; $i < $numberOfOrders; $i++) {
-            $order = $this->createOrder($customer, '#00000'.$i);
+            $order = $this->createOrder($customer, '#00000' . $i);
             $order->setPaymentState(PaymentInterface::STATE_COMPLETED);
             $order->setCompletedAt(new \DateTime());
 
@@ -358,7 +358,7 @@ 
         $total = $this->getPriceFromString($total);
 
         for ($i = 0; $i < $numberOfOrders; $i++) {
-            $order = $this->createOrder($customers[rand(0, $numberOfCustomers - 1)], '#'.uniqid());
+            $order = $this->createOrder($customers[rand(0, $numberOfCustomers - 1)], '#' . uniqid());
             $order->setPaymentState(PaymentInterface::STATE_COMPLETED);
             $order->setCompletedAt(new \DateTime());
 
@@ -502,7 +502,7 @@ 
             $customer = $this->customerFactory->createNew();
             $customer->setEmail(sprintf('john%s@doe.com', uniqid()));
             $customer->setFirstname('John');
-            $customer->setLastname('Doe'.$i);
+            $customer->setLastname('Doe' . $i);
 
             $customers[] = $customer;
 

Unused Use Statements +8 added lines, -9 removed lines

@@ -14,30 +14,29 @@
 use Behat\Behat\Context\Context;
 use Doctrine\Common\Persistence\ObjectManager;
 use SM\Factory\FactoryInterface as StateMachineFactoryInterface;
+use Sylius\Behat\Service\SharedStorageInterface;
 use Sylius\Component\Core\Currency\CurrencyStorageInterface;
-use Sylius\Component\Core\Model\ChannelInterface;
-use Sylius\Component\Core\Model\PromotionCouponInterface;
-use Sylius\Component\Core\OrderCheckoutTransitions;
-use Sylius\Component\Order\Processor\OrderProcessorInterface;
-use Sylius\Component\Order\Modifier\OrderItemQuantityModifierInterface;
 use Sylius\Component\Core\Model\AddressInterface;
+use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Core\Model\OrderInterface;
 use Sylius\Component\Core\Model\OrderItemInterface;
 use Sylius\Component\Core\Model\ProductInterface;
 use Sylius\Component\Core\Model\ProductVariantInterface;
+use Sylius\Component\Core\Model\PromotionCouponInterface;
 use Sylius\Component\Core\Model\ShippingMethodInterface;
+use Sylius\Component\Core\OrderCheckoutTransitions;
 use Sylius\Component\Core\Repository\OrderRepositoryInterface;
-use Sylius\Behat\Service\SharedStorageInterface;
+use Sylius\Component\Customer\Model\CustomerInterface;
+use Sylius\Component\Order\Modifier\OrderItemQuantityModifierInterface;
 use Sylius\Component\Order\OrderTransitions;
-use Sylius\Component\Payment\Model\PaymentInterface;
+use Sylius\Component\Order\Processor\OrderProcessorInterface;
 use Sylius\Component\Payment\Model\PaymentMethodInterface;
 use Sylius\Component\Payment\PaymentTransitions;
+use Sylius\Component\Product\Resolver\ProductVariantResolverInterface;
 use Sylius\Component\Resource\Factory\FactoryInterface;
 use Sylius\Component\Resource\Repository\RepositoryInterface;
 use Sylius\Component\Shipping\ShipmentTransitions;
-use Sylius\Component\Customer\Model\CustomerInterface;
 use Sylius\Component\User\Model\UserInterface;
-use Sylius\Component\Product\Resolver\ProductVariantResolverInterface;
 
 /**
  * @author Łukasz Chruściel <lukasz.chrusciel@lakion.com>

src/Sylius/Behat/Context/Setup/TaxationContext.php

Spacing +1 added lines, -1 removed lines

@@ -212,6 +212,6 @@
      */
     private function getCodeFromNameAndZoneCode($taxRateName, $zoneCode)
     {
-        return $this->getCodeFromName($taxRateName).'_'.strtolower($zoneCode);
+        return $this->getCodeFromName($taxRateName) . '_' . strtolower($zoneCode);
     }
 }

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      *
      * @throws \RuntimeException
      *
-     * @return string
+     * @return integer
      */
     private function tryToMapPaymentMethodName($paymentMethodName)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -15,9 +15,9 @@
 use Sylius\Behat\Page\Admin\Channel\IndexPageInterface;
 use Sylius\Behat\Page\Admin\Channel\UpdatePageInterface;
 use Sylius\Behat\Page\Shop\HomePageInterface;
+use Sylius\Behat\Service\SharedStorageInterface;
 use Sylius\Bundle\ThemeBundle\Model\ThemeInterface;
 use Sylius\Component\Core\Model\ChannelInterface;
-use Sylius\Behat\Service\SharedStorageInterface;
 use Webmozart\Assert\Assert;
 
 /**

src/Sylius/Behat/Context/Ui/CheckoutContext.php

Spacing +3 added lines, -3 removed lines

@@ -530,7 +530,7 @@ 
      */
     public function iShouldSeeThisShippingAddressAsShippingAddress($fullName)
     {
-        $address = $this->sharedStorage->get('shipping_address_'.StringInflector::nameToLowercaseCode($fullName));
+        $address = $this->sharedStorage->get('shipping_address_' . StringInflector::nameToLowercaseCode($fullName));
         Assert::true(
             $this->summaryPage->hasShippingAddress($address),
             'Shipping address is improper.'
@@ -542,7 +542,7 @@ 
      */
     public function iShouldSeeThisBillingAddressAsBillingAddress($fullName)
     {
-        $address = $this->sharedStorage->get('billing_address_'.StringInflector::nameToLowercaseCode($fullName));
+        $address = $this->sharedStorage->get('billing_address_' . StringInflector::nameToLowercaseCode($fullName));
         Assert::true(
             $this->summaryPage->hasBillingAddress($address),
             'Billing address is improper.'
@@ -622,7 +622,7 @@ 
     {
         Assert::true(
             $this->summaryPage->hasShippingTotal($price),
-            sprintf('The shipping total should be %s, but it is not.',$price)
+            sprintf('The shipping total should be %s, but it is not.', $price)
         );
     }
 

Indentation +1 added lines, -1 removed lines

@@ -1261,7 +1261,7 @@
     {
         Assert::true(
             $this->selectPaymentPage->isNextStepButtonUnavailable(),
-           'The "next step" button should be disabled.'
+            'The "next step" button should be disabled.'
         );
     }
 

src/Sylius/Behat/Context/Cli/InstallerContext.php

Spacing +2 added lines, -2 removed lines

@@ -200,7 +200,7 @@ 
     {
         $this->dialog = $this->command->getHelper('dialog');
         $inputString = join(PHP_EOL, $this->inputChoices);
-        $this->dialog->setInputStream($this->getInputStream($inputString.PHP_EOL));
+        $this->dialog->setInputStream($this->getInputStream($inputString . PHP_EOL));
 
         $this->tester->execute(['command' => $name]);
     }
@@ -211,7 +211,7 @@ 
     private function iExecuteCommandAndConfirm($name)
     {
         $this->dialog = $this->command->getHelper('dialog');
-        $inputString = 'y'.PHP_EOL;
+        $inputString = 'y' . PHP_EOL;
         $this->dialog->setInputStream($this->getInputStream($inputString));
 
         $this->tester->execute(['command' => $name]);