IndexPage::getField() - Code Metrics - Inspection of "Allow no default tax zone in channel fixtures" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — allow-no-default-tax-zone-in-c... ( 67cea0 )

by Kamil

created 2019-10-18 14:41 UTC

IndexPage::getField() A

↳ Parent: IndexPage

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Behat\Page\Admin\Shipment;

use Behat\Mink\Element\NodeElement;
use Sylius\Behat\Page\Admin\Crud\IndexPage as BaseIndexPage;

class IndexPage extends BaseIndexPage implements IndexPageInterface
{
    public function chooseStateToFilter(string $shipmentState): void
    {
        $this->getElement('filter_state')->selectOption($shipmentState);
    }

    public function shipShipmentOfOrderWithNumber(string $orderNumber): void
    {
        $this->getField($orderNumber, 'actions')->pressButton('Ship');
    }

    public function getShipmentStatusByOrderNumber(string $orderNumber): string
    {
        return $this->getField($orderNumber, 'state')->getText();
    }

    private function getField(string $orderNumber, string $fieldName): NodeElement
    {
        $tableAccessor = $this->getTableAccessor();
        $table = $this->getElement('table');

        $row = $tableAccessor->getRowWithFields($table, ['number' => $orderNumber]);

        return $field = $tableAccessor->getFieldFromRow($table, $row, $fieldName);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function showOrderPageForNthShipment(int $shipmentNumber): void
    {
        $this->getActionsForRow($shipmentNumber)->clickLink('Show order details');
    }

    protected function getDefinedElements(): array
    {
        return array_merge(parent::getDefinedElements(), [
            'filter_state' => '#criteria_state',
        ]);
    }

    private function getActionsForRow(int $shipmentNumber): NodeElement
    {
        $tableAccessor = $this->getTableAccessor();
        $table = $this->getElement('table');

        $row = $tableAccessor->getRowsWithFields($table, [])[$shipmentNumber];

        return $field = $tableAccessor->getFieldFromRow($table, $row, 'actions');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Sylius\Behat\Page\Admin\Shipment;
15
16			use Behat\Mink\Element\NodeElement;
17			use Sylius\Behat\Page\Admin\Crud\IndexPage as BaseIndexPage;
18
19			class IndexPage extends BaseIndexPage implements IndexPageInterface
20			{
21			public function chooseStateToFilter(string $shipmentState): void
22			{
23			$this->getElement('filter_state')->selectOption($shipmentState);
24			}
25
26			public function shipShipmentOfOrderWithNumber(string $orderNumber): void
27			{
28			$this->getField($orderNumber, 'actions')->pressButton('Ship');
29			}
30
31			public function getShipmentStatusByOrderNumber(string $orderNumber): string
32			{
33			return $this->getField($orderNumber, 'state')->getText();
34			}
35
36			private function getField(string $orderNumber, string $fieldName): NodeElement
37			{
38			$tableAccessor = $this->getTableAccessor();
39			$table = $this->getElement('table');
40
41			$row = $tableAccessor->getRowWithFields($table, ['number' => $orderNumber]);
42
43			return $field = $tableAccessor->getFieldFromRow($table, $row, $fieldName);
			0 ignored issues – show Unused Code introduced 2019-04-15 10:20 UTC by Report Bug Copy Issue Report `$field` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
44			}
45
46			public function showOrderPageForNthShipment(int $shipmentNumber): void
47			{
48			$this->getActionsForRow($shipmentNumber)->clickLink('Show order details');
49			}
50
51			protected function getDefinedElements(): array
52			{
53			return array_merge(parent::getDefinedElements(), [
54			'filter_state' => '#criteria_state',
55			]);
56			}
57
58			private function getActionsForRow(int $shipmentNumber): NodeElement
59			{
60			$tableAccessor = $this->getTableAccessor();
61			$table = $this->getElement('table');
62
63			$row = $tableAccessor->getRowsWithFields($table, [])[$shipmentNumber];
64
65			return $field = $tableAccessor->getFieldFromRow($table, $row, 'actions');
			0 ignored issues – show Unused Code introduced 2019-05-07 16:59 UTC by Report Bug Copy Issue Report `$field` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
66			}
67			}
68

pamil / Sylius

Push — allow-no-default-tax-zone-in-c... ( 67cea0 )

IndexPage::getField() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like