pamil / Sylius

src/Sylius/Bundle/ReviewBundle/DependencyInjection/Configuration.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,8 +16,8 @@
 use Sylius\Bundle\ReviewBundle\Doctrine\ORM\ReviewRepository;
 use Sylius\Bundle\ReviewBundle\Form\Type\ReviewType;
 use Sylius\Component\Resource\Factory\Factory;
-use Sylius\Component\Review\Model\ReviewerInterface;
 use Sylius\Component\Review\Model\ReviewInterface;
+use Sylius\Component\Review\Model\ReviewerInterface;
 use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;

src/Sylius/Bundle/ReviewBundle/Remover/ReviewerReviewsRemover.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
      * @param ReviewInterface $review
      * @param ReviewableInterface[] $reviewSubjectsToRecalculate
      *
-     * @return array
+     * @return ReviewableInterface[]
      */
     private function removeReviewsAndExtractSubject(ReviewInterface $review, array $reviewSubjectsToRecalculate)
     {

Unused Use Statements +1 added lines, -2 removed lines

@@ -14,10 +14,9 @@
 use Doctrine\Common\Persistence\ObjectManager;
 use Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepository;
 use Sylius\Bundle\ReviewBundle\Updater\ReviewableRatingUpdaterInterface;
-use Sylius\Component\Review\Calculator\ReviewableRatingCalculatorInterface;
+use Sylius\Component\Review\Model\ReviewInterface;
 use Sylius\Component\Review\Model\ReviewableInterface;
 use Sylius\Component\Review\Model\ReviewerInterface;
-use Sylius\Component\Review\Model\ReviewInterface;
 
 /**
  * @author Grzegorz Sadowski <grzegorz.sadowski@lakion.com>

src/Sylius/Bundle/SearchBundle/Finder/ElasticsearchFinder.php

Doc Comments +9 added lines, -9 removed lines

@@ -191,8 +191,8 @@ 
     /**
      * @param null $facets
      * @param $configuration
-     * @param $taxon
-     * @param null $types
+     * @param string $taxon
+     * @param string[] $types
      *
      * @return mixed
      */
@@ -231,11 +231,11 @@ 
     }
 
     /**
-     * @param      $searchTerm
+     * @param      string $searchTerm
      * @param null $appliedFilters
      * @param      $configuration
-     * @param      $preSearchTaxonFilter
-     * @param      $types
+     * @param      string $preSearchTaxonFilter
+     * @param      string[] $types
      *
      * @return mixed
      */
@@ -276,7 +276,7 @@ 
     }
 
     /**
-     * @param      $elasticaQuery
+     * @param      Query $elasticaQuery
      * @param null $appliedFilters
      * @param      $configuration
      *
@@ -416,10 +416,10 @@ 
     /**
      * @param $facets
      * @param $appliedFilters
-     * @param $rangeFilters
+     * @param BoolOr $rangeFilters
      * @param $termFilters
      * @param $aggregations
-     * @param $boolFilter
+     * @param BoolFilter $boolFilter
      *
      * @return array
      */
@@ -525,7 +525,7 @@ 
     }
 
     /**
-     * @param $filterSetName
+     * @param string $filterSetName
      */
     private function initializeFacetGroup($filterSetName)
     {

Unused Use Statements +8 added lines, -8 removed lines

@@ -14,25 +14,25 @@
 use Elastica\Aggregation\Filter;
 use Elastica\Aggregation\Range as AggregationRange;
 use Elastica\Aggregation\Terms as AggregationTerms;
-use Elastica\Query;
-use Elastica\Query\BoolQuery;
-use Elastica\Query\Filtered;
-use Elastica\Query\QueryString;
-use Elastica\Query\Range as QueryRange;
-use Elastica\Query\Term as QueryTerm;
 use Elastica\Filter\BoolFilter;
 use Elastica\Filter\BoolOr;
 use Elastica\Filter\Missing;
 use Elastica\Filter\Nested;
 use Elastica\Filter\Range as FilterRange;
-use Elastica\Filter\Type;
 use Elastica\Filter\Term as FilterTerm;
 use Elastica\Filter\Terms as FilterTerms;
+use Elastica\Filter\Type;
+use Elastica\Query;
+use Elastica\Query\BoolQuery;
+use Elastica\Query\Filtered;
+use Elastica\Query\QueryString;
+use Elastica\Query\Range as QueryRange;
+use Elastica\Query\Term as QueryTerm;
 use Sylius\Bundle\SearchBundle\Doctrine\ORM\SearchIndexRepository;
+use Sylius\Bundle\SearchBundle\QueryLogger\QueryLoggerInterface;
 use Sylius\Bundle\SearchBundle\Query\Query as SyliusSearchQuery;
 use Sylius\Bundle\SearchBundle\Query\SearchStringQuery;
 use Sylius\Bundle\SearchBundle\Query\TaxonQuery;
-use Sylius\Bundle\SearchBundle\QueryLogger\QueryLoggerInterface;
 use Sylius\Component\Channel\Context\ChannelContextInterface;
 
 /**

Spacing +21 added lines, -21 removed lines

@@ -330,7 +330,7 @@ 
         }
 
         foreach ($facets as &$facet) {
-            $facet = array_filter($facet, function($v){
+            $facet = array_filter($facet, function ($v) {
                 return $v["doc_count"] != 0;
             });
         }
@@ -385,29 +385,29 @@ 
         foreach ($configuration['filters']['facets'] as $name => $facet) {
             // terms facet creation
             if ($facet['type'] === 'terms') {
-                ${$name.'AggregationFilter'} = new Filter($name);
+                ${$name . 'AggregationFilter'} = new Filter($name);
 
-                ${$name.'Aggregation'} = new AggregationTerms($name);
-                ${$name.'Aggregation'}->setField($name);
-                ${$name.'Aggregation'}->setSize(550);
+                ${$name . 'Aggregation'} = new AggregationTerms($name);
+                ${$name . 'Aggregation'}->setField($name);
+                ${$name . 'Aggregation'}->setSize(550);
 
-                ${$name.'AggregationFilter'}->addAggregation(${$name.'Aggregation'});
+                ${$name . 'AggregationFilter'}->addAggregation(${$name . 'Aggregation'});
             } // range facet creation
             elseif ('range' === $facet['type']) {
-                ${$name.'AggregationFilter'} = new Filter($name);
+                ${$name . 'AggregationFilter'} = new Filter($name);
 
-                ${$name.'Aggregation'} = new AggregationRange($name);
+                ${$name . 'Aggregation'} = new AggregationRange($name);
                 foreach ($facet['values'] as $value) {
-                    ${$name.'Aggregation'}
+                    ${$name . 'Aggregation'}
                         ->setField($name)
                         ->addRange($value['from'], $value['to']);
                 }
 
-                ${$name.'AggregationFilter'}->addAggregation(${$name.'Aggregation'});
+                ${$name . 'AggregationFilter'}->addAggregation(${$name . 'Aggregation'});
             }
 
-            $aggregations[$name]['aggregation'] = ${$name.'Aggregation'};
-            $aggregations[$name]['aggregation_filter'] = ${$name.'AggregationFilter'};
+            $aggregations[$name]['aggregation'] = ${$name . 'Aggregation'};
+            $aggregations[$name]['aggregation_filter'] = ${$name . 'AggregationFilter'};
         }
 
         return $aggregations;
@@ -428,20 +428,20 @@ 
         foreach ($facets as $name => $facet) {
             $normName = key($facet);
 
-            ${$normName.'BoolFilter'} = new BoolFilter();
+            ${$normName . 'BoolFilter'} = new BoolFilter();
 
             foreach ($appliedFilters as $value) {
                 if (is_array($value[key($value)])) {
-                    ${$normName.'RangeFilter'} = new FilterRange();
+                    ${$normName . 'RangeFilter'} = new FilterRange();
 
                     foreach ($value as $range) {
-                        ${$normName.'RangeFilter'}->addField($name, ['gte' => $range['range'][0], 'lte' => $range['range'][1]]);
-                        ${$normName.'BoolFilter'}->addMust($rangeFilters);
+                        ${$normName . 'RangeFilter'}->addField($name, ['gte' => $range['range'][0], 'lte' => $range['range'][1]]);
+                        ${$normName . 'BoolFilter'}->addMust($rangeFilters);
                     }
                 } else {
-                    ${$normName.'TermFilter'} = new FilterTerm();
-                    ${$normName.'TermFilter'}->setTerm($name, $value[key($value)]);
-                    ${$normName.'BoolFilter'}->addMust($termFilters);
+                    ${$normName . 'TermFilter'} = new FilterTerm();
+                    ${$normName . 'TermFilter'}->setTerm($name, $value[key($value)]);
+                    ${$normName . 'BoolFilter'}->addMust($termFilters);
                 }
             }
         }
@@ -451,8 +451,8 @@ 
                 if (count($facets) >= count($this->config['filters']['facets'])) {
                     $aggregations[$name]['aggregation_filter']->setFilter($boolFilter);
                 } elseif ($name != key($value)) {
-                    if (isset(${key($value).'BoolFilter'})) {
-                        $aggregations[$name]['aggregation_filter']->setFilter(${key($value).'BoolFilter'});
+                    if (isset(${key($value) . 'BoolFilter'})) {
+                        $aggregations[$name]['aggregation_filter']->setFilter(${key($value) . 'BoolFilter'});
                     }
                 }
             }

Braces +1 added lines, -1 removed lines

@@ -330,7 +330,7 @@
         }
 
         foreach ($facets as &$facet) {
-            $facet = array_filter($facet, function($v){
+            $facet = array_filter($facet, function($v) {
                 return $v["doc_count"] != 0;
             });
         }

src/Sylius/Bundle/SearchBundle/Finder/OrmFinder.php

Doc Comments +1 added lines, -1 removed lines

@@ -421,7 +421,7 @@
     /**
      * This functions unsets the configured filters based on the facet groups
      *
-     * @param $filterSetName
+     * @param string $filterSetName
      */
     private function initializeFacetGroup($filterSetName)
     {

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,10 +16,10 @@
 use Pagerfanta\Pagerfanta;
 use Sylius\Bundle\SearchBundle\Doctrine\ORM\SearchIndexRepository;
 use Sylius\Bundle\SearchBundle\Model\SearchIndex;
+use Sylius\Bundle\SearchBundle\QueryLogger\QueryLoggerInterface;
 use Sylius\Bundle\SearchBundle\Query\Query;
 use Sylius\Bundle\SearchBundle\Query\SearchStringQuery;
 use Sylius\Bundle\SearchBundle\Query\TaxonQuery;
-use Sylius\Bundle\SearchBundle\QueryLogger\QueryLoggerInterface;
 use Sylius\Component\Channel\Context\ChannelContextInterface;
 
 /**

src/Sylius/Bundle/SearchBundle/Indexer/OrmIndexer.php

Doc Comments +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
     }
 
     /**
-     * @param $message
+     * @param string $message
      */
     private function addToOutput($message)
     {

Spacing +4 added lines, -4 removed lines

@@ -77,7 +77,7 @@ 
      */
     private function addToOutput($message)
     {
-        $this->output .= $message.PHP_EOL;
+        $this->output .= $message . PHP_EOL;
     }
 
     /**
@@ -122,7 +122,7 @@ 
     {
         $fieldNames = array_keys($fields);
         foreach ($fieldNames as &$value) {
-            $value = 'u.'.$value;
+            $value = 'u.' . $value;
         }
 
         $this->addToOutput(sprintf('Populating index table with "%s" data', $entity));
@@ -241,10 +241,10 @@ 
         // TODO maybe I can use the property accessor here
         $content = '';
         foreach (array_keys(array_slice($fields, 1)) as $field) {
-            $func = 'get'.ucfirst($field);
+            $func = 'get' . ucfirst($field);
 
             if (method_exists($element, $func)) {
-                $content .= $element->$func().self::SPACER;
+                $content .= $element->$func() . self::SPACER;
             }
         }
 

src/Sylius/Bundle/SearchBundle/Listener/ElasticaProductListener.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -14,9 +14,9 @@
 use Doctrine\Common\EventSubscriber;
 use Doctrine\ORM\Event\LifecycleEventArgs;
 use FOS\ElasticaBundle\Persister\ObjectPersister;
+use Sylius\Component\Core\Model\ProductTranslation;
 use Sylius\Component\Product\Model\AttributeValueInterface;
 use Sylius\Component\Product\Model\ProductInterface;
-use Sylius\Component\Core\Model\ProductTranslation;
 use Sylius\Component\Variation\Model\VariantInterface;
 
 /**

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getRecipients()
     {

src/Sylius/Bundle/SearchBundle/spec/Finder/OrmFinderSpec.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Doctrine\ORM\AbstractQuery;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\EntityManagerInterface;
-use Doctrine\ORM\Query;
 use PhpSpec\ObjectBehavior;
 use Prophecy\Argument;
 use Sylius\Bundle\SearchBundle\Doctrine\ORM\SearchIndexRepository;

src/Sylius/Bundle/SettingsBundle/Controller/SettingsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
      *
      * @param string $schemaAlias
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isGrantedOr403($schemaAlias)
     {

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Sylius\Bundle\SettingsBundle\Manager\SettingsManagerInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\OptionsResolver\Exception\MissingOptionsException;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Symfony\Component\Translation\TranslatorInterface;
 use Symfony\Component\Validator\Exception\ValidatorException;

src/Sylius/Bundle/SettingsBundle/Exception/ParameterNotFoundException.php

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     /**
      * @param string $parameter
      * @param int $code
-     * @param Exception $previous
+     * @param \Exception $previous
      */
     public function __construct($parameter, $code = 0, \Exception $previous = null)
     {