pamil / Sylius

src/Sylius/Bundle/FlowBundle/Process/Coordinator/CoordinatorInterface.php

Doc Comments +3 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
      * @param string       $stepName
      * @param ParameterBag $queryParameters
      *
-     * @return Response|View
+     * @return RedirectResponse
      */
     public function display($scenarioAlias, $stepName, ParameterBag $queryParameters = null);
 
@@ -53,7 +53,7 @@ 
      * @param string $scenarioAlias
      * @param string $stepName
      *
-     * @return Response|View
+     * @return RedirectResponse
      */
     public function forward($scenarioAlias, $stepName);
 
@@ -62,6 +62,7 @@ 
      *
      * @param string                   $alias
      * @param ProcessScenarioInterface $scenario
+     * @return void
      */
     public function registerScenario($alias, ProcessScenarioInterface $scenario);
 

src/Sylius/Bundle/FlowBundle/Validator/ProcessValidator.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
     /**
      * Set validation.
      *
-     * @param callable $validation
+     * @param \Closure $validation
      *
      * @return $this
      */

src/Sylius/Bundle/GridBundle/Doctrine/ORM/ExpressionBuilder.php

Doc Comments +1 added lines

@@ -187,6 +187,7 @@
 
     /**
      * {@inheritdoc}
+     * @param string $field
      */
     private function getFieldName($field)
     {

Spacing +7 added lines, -7 removed lines

@@ -76,7 +76,7 @@ 
     {
         $this->queryBuilder->setParameter($field, $value);
 
-        return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':'.$field);
+        return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':' . $field);
     }
 
     /**
@@ -86,7 +86,7 @@ 
     {
         $this->queryBuilder->setParameter($field, $value);
 
-        return $this->queryBuilder->expr()->neq($this->getFieldName($field), ':'.$field);
+        return $this->queryBuilder->expr()->neq($this->getFieldName($field), ':' . $field);
     }
 
     /**
@@ -94,7 +94,7 @@ 
      */
     public function lessThan($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' < :'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' < :' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -102,7 +102,7 @@ 
      */
     public function lessThanOrEqual($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' =< :'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' =< :' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -110,7 +110,7 @@ 
      */
     public function greaterThan($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' > :'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' > :' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -118,7 +118,7 @@ 
      */
     public function greaterThanOrEqual($field, $value)
     {
-        $this->queryBuilder->andWhere($this->getFieldName($field).' => :%s'.$field)->setParameter($field, $value);
+        $this->queryBuilder->andWhere($this->getFieldName($field) . ' => :%s' . $field)->setParameter($field, $value);
     }
 
     /**
@@ -191,7 +191,7 @@ 
     private function getFieldName($field)
     {
         if (false === strpos($field, '.')) {
-            return $this->queryBuilder->getRootAlias().'.'.$field;
+            return $this->queryBuilder->getRootAlias() . '.' . $field;
         }
 
         return $field;

src/Sylius/Bundle/GridBundle/Doctrine/PHPCRODM/ExpressionVisitor.php

Doc Comments +3 added lines

@@ -175,6 +175,9 @@
         return Driver::QB_SOURCE_ALIAS . '.' . $field;
     }
 
+    /**
+     * @param string $field
+     */
     private function getInConstraint(AbstractNode $parentNode, $field, array $values)
     {
         $orNode = $parentNode->orx();

Unused Use Statements +3 added lines, -4 removed lines

@@ -11,14 +11,13 @@
 
 namespace Sylius\Bundle\GridBundle\Doctrine\PHPCRODM;
 
-use Sylius\Component\Grid\Data\ExpressionBuilderInterface;
-use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
-use Doctrine\Common\Collections\Expr\CompositeExpression;
 use Doctrine\Common\Collections\Expr\Comparison;
+use Doctrine\Common\Collections\Expr\CompositeExpression;
+use Doctrine\Common\Collections\Expr\Expression;
 use Doctrine\Common\Collections\Expr\Value;
 use Doctrine\ODM\PHPCR\Query\Builder\AbstractNode;
 use Doctrine\ODM\PHPCR\Query\Builder\OperandFactory;
-use Doctrine\Common\Collections\Expr\Expression;
+use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExtraComparison;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
      */
     public function walkCompositeExpression(CompositeExpression $expr, AbstractNode $parentNode)
     {
-        switch($expr->getType()) {
+        switch ($expr->getType()) {
             case CompositeExpression::TYPE_AND:
                 $node = $parentNode->andX();
                 break;
@@ -128,7 +128,7 @@ 
                 break;
             }
 
-            switch($expr->getType()) {
+            switch ($expr->getType()) {
                 case CompositeExpression::TYPE_AND:
                     $parentNode = $parentNode->andX();
                     break;

src/Sylius/Bundle/GridBundle/spec/Doctrine/PHPCRODM/DriverSpec.php

Unused Use Statements +3 added lines, -4 removed lines

@@ -11,14 +11,13 @@
 
 namespace spec\Sylius\Bundle\GridBundle\Doctrine\PHPCRODM;
 
-use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
-use Sylius\Component\Grid\Data\DriverInterface;
-use Sylius\Component\Grid\Parameters;
 use Doctrine\ODM\PHPCR\DocumentManagerInterface;
 use Doctrine\ODM\PHPCR\DocumentRepository;
 use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
+use PhpSpec\ObjectBehavior;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\DataSource;
+use Sylius\Component\Grid\Data\DriverInterface;
+use Sylius\Component\Grid\Parameters;
 
 /**
  * @mixin Driver

src/Sylius/Bundle/GridBundle/spec/Doctrine/PHPCRODM/ExpressionBuilderSpec.php

Unused Use Statements +2 added lines, -3 removed lines

@@ -11,11 +11,10 @@
 
 namespace spec\Sylius\Bundle\GridBundle\Doctrine\PHPCRODM;
 
-use PhpSpec\ObjectBehavior;
-use Prophecy\Argument;
+use Doctrine\Common\Collections\Expr\Comparison;
 use Doctrine\Common\Collections\ExpressionBuilder as CollectionsExpressionBuilder;
+use PhpSpec\ObjectBehavior;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExpressionBuilder;
-use Doctrine\Common\Collections\Expr\Comparison;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExtraComparison;
 
 class ExpressionBuilderSpec extends ObjectBehavior

Braces +10 added lines, -20 removed lines

@@ -33,8 +33,7 @@ 
     function it_builds_andx(
         Comparison $comparison,
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->andX([$comparison]);
         $expressionBuilder->andX([$comparison])->shouldHaveBeenCalled();
     }
@@ -42,64 +41,56 @@ 
     function it_builds_orx(
         Comparison $comparison,
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->orX([$comparison]);
         $expressionBuilder->orX([$comparison])->shouldHaveBeenCalled();
     }
 
     function it_builds_equals(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->equals('o.foo', 'value');
         $expressionBuilder->eq('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_not_equals(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->notEquals('o.foo', 'value');
         $expressionBuilder->neq('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_less_than_or_equal(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->lessThanOrEqual('o.foo', 'value');
         $expressionBuilder->lte('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_greater_than(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->greaterThan('o.foo', 'value');
         $expressionBuilder->gt('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_greater_than_or_equal(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->greaterThanOrequal('o.foo', 'value');
         $expressionBuilder->gte('o.foo', 'value')->shouldHaveBeenCalled();
     }
 
     function it_builds_in(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->in('o.foo', ['value']);
         $expressionBuilder->in('o.foo', ['value'])->shouldHaveBeenCalled();
     }
 
     function it_builds_not_in(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->notIn('o.foo', ['value']);
         $expressionBuilder->notIn('o.foo', ['value'])->shouldHaveBeenCalled();
     }
@@ -120,8 +111,7 @@ 
 
     function it_builds_like(
         CollectionsExpressionBuilder $expressionBuilder
-    )
-    {
+    ) {
         $this->like('o.foo', 'value');
         $expressionBuilder->contains('o.foo', 'value')->shouldHaveBeenCalled();
     }

src/Sylius/Bundle/GridBundle/Tests/Doctrine/PHPCRODM/ExpressionVisitorTest.php

Unused Use Statements +3 added lines, -6 removed lines

@@ -11,15 +11,12 @@
 
 namespace Sylius\Bundle\GridBundle\Tests\DependencyInjection;
 
-use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
-use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExpressionVisitor;
 use Doctrine\Common\Collections\Expr\Comparison;
-use Doctrine\ODM\PHPCR\Query\Builder\AbstractNode;
-use Doctrine\ODM\PHPCR\Query\Builder\AbstractLeafNode;
+use Doctrine\Common\Collections\Expr\CompositeExpression;
 use Doctrine\ODM\PHPCR\Query\Builder\OperandDynamicField;
-use Doctrine\ODM\PHPCR\Query\Builder\ConstraintComparison;
 use Doctrine\ODM\PHPCR\Query\Builder\OperandStaticLiteral;
-use Doctrine\Common\Collections\Expr\CompositeExpression;
+use Doctrine\ODM\PHPCR\Query\Builder\QueryBuilder;
+use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExpressionVisitor;
 use Sylius\Bundle\GridBundle\Doctrine\PHPCRODM\ExtraComparison;
 
 require(__DIR__ . '/QueryBuilderWalker.php');

Spacing +10 added lines, -10 removed lines

@@ -108,17 +108,17 @@ 
         return [
             [
                 Comparison::IN,
-                [ 'one' ],
+                ['one'],
                 'ConstraintOrx ( jcr.operator.equal.to ( OperandDynamicField(o.hello) OperandStaticLiteral("one") ) )'
             ],
             [
                 Comparison::IN,
-                [ 'one', 'two', 'three' ],
+                ['one', 'two', 'three'],
                 'ConstraintOrx ( jcr.operator.equal.to ( OperandDynamicField(o.hello) OperandStaticLiteral("one") ) jcr.operator.equal.to ( OperandDynamicField(o.hello) OperandStaticLiteral("two") ) jcr.operator.equal.to ( OperandDynamicField(o.hello) OperandStaticLiteral("three") ) )',
             ],
             [
                 Comparison::NIN,
-                [ 'one' ],
+                ['one'],
                 'ConstraintNot ( ConstraintOrx ( jcr.operator.equal.to ( OperandDynamicField(o.hello) OperandStaticLiteral("one") ) ) )'
             ],
         ];
@@ -133,7 +133,7 @@ 
         $expr2 = new Comparison('number', Comparison::GT, 8);
         $expr = new CompositeExpression(
             $type,
-            [ $expr1, $expr2 ]
+            [$expr1, $expr2]
         );
 
         $this->visitor->dispatch($expr);
@@ -153,8 +153,8 @@ 
     public function provideComposite()
     {
         return [
-            [ CompositeExpression::TYPE_AND, 'ConstraintAndx' ],
-            [ CompositeExpression::TYPE_OR, 'ConstraintOrx' ]
+            [CompositeExpression::TYPE_AND, 'ConstraintAndx'],
+            [CompositeExpression::TYPE_OR, 'ConstraintOrx']
         ];
     }
 
@@ -166,7 +166,7 @@ 
         $expr3 = new Comparison('date', Comparison::GT, '2015-12-10');
         $expr = new CompositeExpression(
             $type,
-            [ $expr1, $expr2, $expr3 ]
+            [$expr1, $expr2, $expr3]
         );
 
         $this->visitor->dispatch($expr);
@@ -197,12 +197,12 @@ 
         $expr4 = new Comparison('date', Comparison::LT, '2016-12-10');
         $expr5 = new Comparison('date', Comparison::NEQ, '2016-12-10');
 
-        $comp2 = new CompositeExpression(CompositeExpression::TYPE_AND, [ $expr2, $expr5 ]);
-        $comp1 = new CompositeExpression(CompositeExpression::TYPE_OR, [ $expr1, $comp2 ]);
+        $comp2 = new CompositeExpression(CompositeExpression::TYPE_AND, [$expr2, $expr5]);
+        $comp1 = new CompositeExpression(CompositeExpression::TYPE_OR, [$expr1, $comp2]);
 
         $expr = new CompositeExpression(
             $type,
-            [ $comp1, $expr3, $expr4 ]
+            [$comp1, $expr3, $expr4]
         );
 
         $this->visitor->dispatch($expr);

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -146,7 +146,7 @@ 
         OperandDynamicField(o.number) OperandStaticLiteral("8") 
     ) 
 )
-EOT
+eot
         );
     }
 
@@ -184,7 +184,7 @@ 
         )
     ) 
 )
-EOT
+eot
         );
     }
 
@@ -230,7 +230,7 @@ 
         )
     ) 
 )
-EOT
+eot
         );
     }
 

src/Sylius/Bundle/GridBundle/Twig/GridExtension.php

Doc Comments -3 removed lines

@@ -51,7 +51,6 @@ 
     /**
      * @param GridView $gridView
      * @param string $template
-     * @param array $variables
      *
      * @return mixed
      */
@@ -84,8 +83,6 @@ 
 
     /**
      * @param GridView $gridView
-     * @param Action $action
-     * @param mixed $data
      */
     public function renderFilter(GridView $gridView, Filter $filter)
     {

src/Sylius/Bundle/InstallerBundle/Command/AbstractInstallCommand.php

Doc Comments +7 added lines, -7 removed lines

@@ -46,7 +46,7 @@ 
     }
 
     /**
-     * @param $id
+     * @param string $id
      *
      * @return object
      */
@@ -72,7 +72,7 @@ 
     }
 
     /**
-     * @param array $headers
+     * @param string[] $headers
      * @param array $rows
      * @param OutputInterface $output
      */
@@ -144,9 +144,9 @@ 
     /**
      * @param OutputInterface $output
      * @param string          $question
-     * @param array           $constraints
+     * @param \Symfony\Component\Validator\Constraints\NotBlank[]           $constraints
      *
-     * @return mixed
+     * @return string
      */
     protected function askHidden(OutputInterface $output, $question, array $constraints = [])
     {
@@ -159,7 +159,7 @@ 
      * @param array $constraints
      * @param mixed $default
      *
-     * @return mixed
+     * @return string
      */
     protected function ask(OutputInterface $output, $question, array $constraints = [], $default = null)
     {
@@ -167,7 +167,7 @@ 
     }
 
     /**
-     * @param mixed $value
+     * @param string $value
      * @param array $constraints
      *
      * @return bool
@@ -195,7 +195,7 @@ 
      * @param string          $default
      * @param bool         $hidden
      *
-     * @return mixed
+     * @return string
      */
     private function proceedAskRequest(OutputInterface $output, $question, array $constraints = [], $default = null, $hidden = false)
     {