view/frontend/web/js/view/payment/method-renderer/paylater.js - Code Metrics - Inspection of "Merge pull request #5 from PagaMasTarde/v7.0.1" - pagantis/magento-2X - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1137b9...97c77e )

unknown

created 2018-10-01 10:20 UTC

view/frontend/web/js/view/payment/method-renderer/paylater.js A

↳ Parent: Project

Complexity

Total Complexity	19
Complexity/F	1.27

Size

Lines of Code	97
Function Count	15

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	0
eloc	61
c	4
b	0
f	0
nc	3
dl	0
loc	97
rs	10
wmc	19
mnd	2
bc	17
fnc	15
bpm	1.1333
cpm	1.2666
noi	2

1 Function

Rating	Name	Duplication	Size	Complexity
B	paylater.js ➔ define	0	81	1

define(
    [
        'jquery',
        'Magento_Checkout/js/view/payment/default',
        'mage/url',
        'Magento_Customer/js/customer-data',
        'Magento_Checkout/js/model/error-processor',
        'Magento_Checkout/js/model/full-screen-loader',
        'Magento_Checkout/js/model/quote',
        '//cdn.pagamastarde.com/pmt-js-client-sdk/3/js/client-sdk.min.js',
        'Magento_Checkout/js/action/select-payment-method',
        'Magento_Checkout/js/checkout-data',
        'Magento_Checkout/js/model/totals',
        'Magento_Catalog/js/price-utils'
    ],
    function ($, Component, url, customerData, errorProcessor, fullScreenLoader, quote, pmtClient, selectPaymentMethodAction, checkoutData, totals, priceUtils) {
        'use strict';

        window.checkoutConfig.payment.paylater.guestEmail = quote.guestEmail;

        window.pmtClient = pmtClient;

        return Component.extend({
                defaults: {
                    template: 'DigitalOrigin_Pmt/payment/checkout-form'
                },

                redirectAfterPlaceOrder: false,

                loadSimulator: function ()
                {
                    setTimeout(function(){
                        if (window.checkoutConfig.payment.paylater.pmtType  !='0' &&
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                            window.checkoutConfig.payment.paylater.publicKey!=''  &&
                            window.checkoutConfig.payment.paylater.secretKey!='')
                        {
                            if (typeof window.pmtClient !== 'undefined')
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                            {
                                window.pmtClient.setPublicKey(window.checkoutConfig.payment.paylater.publicKey);
                                window.pmtClient.simulator.reload();
                                return true;
                            }
                        }
                    }, 3000);
                },

                getSubtitle: function () {
                    return window.checkoutConfig.payment.paylater.subtitle
                },

                getPmtNumQuota: function () {
                    return window.checkoutConfig.payment.paylater.pmtNumQuota
                },

                dataPmtMaxIns: function () {
                    return window.checkoutConfig.payment.paylater.pmtMaxIns
                },

                getPmtType: function () {
                    return window.checkoutConfig.payment.paylater.pmtType
                },

                getPmtTotal: function () {
                    return priceUtils.formatPrice(totals.totals().grand_total, quote.getPriceFormat());
                },

                getPublicKey: function () {
                    return window.checkoutConfig.payment.paylater.publicKey
                },

                getSecretKey: function () {
                    return window.checkoutConfig.payment.paylater.secretKey
                },

                getDisplayMode: function () {
                    return window.checkoutConfig.payment.paylater.displayMode
                },

                selectPaymentMethod: function() {
                    selectPaymentMethodAction(this.getData());
                    checkoutData.setSelectedPaymentMethod(this.item.method);
                    return true;
                },

                placeOrder: function () {
                    var paymentUrl = url.build('paylater/Payment');
                    $.post(paymentUrl, { email: window.checkoutConfig.payment.paylater.guestEmail }, 'json')
                        .done(function (response) {
                            window.location.replace(response);
                        })
                        .fail(function (response) {
                            window.location.replace(response);
                        })
                },
            });
    }
);


1			define(
2			[
3			'jquery',
4			'Magento_Checkout/js/view/payment/default',
5			'mage/url',
6			'Magento_Customer/js/customer-data',
7			'Magento_Checkout/js/model/error-processor',
8			'Magento_Checkout/js/model/full-screen-loader',
9			'Magento_Checkout/js/model/quote',
10			'//cdn.pagamastarde.com/pmt-js-client-sdk/3/js/client-sdk.min.js',
11			'Magento_Checkout/js/action/select-payment-method',
12			'Magento_Checkout/js/checkout-data',
13			'Magento_Checkout/js/model/totals',
14			'Magento_Catalog/js/price-utils'
15			],
16			function ($, Component, url, customerData, errorProcessor, fullScreenLoader, quote, pmtClient, selectPaymentMethodAction, checkoutData, totals, priceUtils) {
17			'use strict';
18
19			window.checkoutConfig.payment.paylater.guestEmail = quote.guestEmail;
20
21			window.pmtClient = pmtClient;
22
23			return Component.extend({
24			defaults: {
25			template: 'DigitalOrigin_Pmt/payment/checkout-form'
26			},
27
28			redirectAfterPlaceOrder: false,
29
30			loadSimulator: function ()
31			{
32			setTimeout(function(){
33			if (window.checkoutConfig.payment.paylater.pmtType !='0' &&
			0 ignored issues – show Complexity Best Practice introduced 2018-09-28 09:10 UTC by Report Bug Copy Issue Report There is no return statement if `window.checkoutConfig.pa...aylater.secretKey != ""` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
34			window.checkoutConfig.payment.paylater.publicKey!='' &&
35			window.checkoutConfig.payment.paylater.secretKey!='')
36			{
37			if (typeof window.pmtClient !== 'undefined')
			0 ignored issues – show Complexity Best Practice introduced 2018-09-28 09:10 UTC by Report Bug Copy Issue Report There is no return statement if `typeof window.pmtClient !== "undefined"` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
38			{
39			window.pmtClient.setPublicKey(window.checkoutConfig.payment.paylater.publicKey);
40			window.pmtClient.simulator.reload();
41			return true;
42			}
43			}
44			}, 3000);
45			},
46
47			getSubtitle: function () {
48			return window.checkoutConfig.payment.paylater.subtitle
49			},
50
51			getPmtNumQuota: function () {
52			return window.checkoutConfig.payment.paylater.pmtNumQuota
53			},
54
55			dataPmtMaxIns: function () {
56			return window.checkoutConfig.payment.paylater.pmtMaxIns
57			},
58
59			getPmtType: function () {
60			return window.checkoutConfig.payment.paylater.pmtType
61			},
62
63			getPmtTotal: function () {
64			return priceUtils.formatPrice(totals.totals().grand_total, quote.getPriceFormat());
65			},
66
67			getPublicKey: function () {
68			return window.checkoutConfig.payment.paylater.publicKey
69			},
70
71			getSecretKey: function () {
72			return window.checkoutConfig.payment.paylater.secretKey
73			},
74
75			getDisplayMode: function () {
76			return window.checkoutConfig.payment.paylater.displayMode
77			},
78
79			selectPaymentMethod: function() {
80			selectPaymentMethodAction(this.getData());
81			checkoutData.setSelectedPaymentMethod(this.item.method);
82			return true;
83			},
84
85			placeOrder: function () {
86			var paymentUrl = url.build('paylater/Payment');
87			$.post(paymentUrl, { email: window.checkoutConfig.payment.paylater.guestEmail }, 'json')
88			.done(function (response) {
89			window.location.replace(response);
90			})
91			.fail(function (response) {
92			window.location.replace(response);
93			})
94			},
95			});
96			}
97			);
98

pagantis / magento-2X

Push — master ( 1137b9...97c77e )

view/frontend/web/js/view/payment/method-renderer/paylater.js A

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like