ZanoxEx - Code Metrics - Inspection of "CHANGE service provider" - padosoft/laravel-affiliate-network - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f7fdc3...1fc303 )

unknown

created 2017-01-23 10:12 UTC

ZanoxEx A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	24.14 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	1
dl	14
loc	58
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	invokeMethod()	7	7	1
A	invokeProperty()	7	7	1
A	getSales()	0	15	3

How to fix Duplicated Code

<?php
/**
 * Copyright (c) Padosoft.com 2017.
 */


namespace Padosoft\AffiliateNetwork\Networks;
use Oara\Network\Publisher\Zanox;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class ZanoxEx extends Zanox
{
    /**
     * Call protected/private method of a class.
     *
     * @param object &$object    Instantiated object that we will run method on.
     * @param string $methodName Method name to call
     * @param array  $parameters Array of parameters to pass into method.
     *
     * @return mixed Method return.
     */
    public function invokeMethod(&$object,$methodName, array $parameters = array())

    {
        $reflection = new \ReflectionClass(get_class($object));
        $method = $reflection->getMethod($methodName);
        $method->setAccessible(true);
        return $method->invokeArgs($object, $parameters);
    }

    /**
     * Call protected/private property of a class.
     * @param $object
     * @param $propertyName
     *
     * @return mixed
     */
    public function invokeProperty(&$object,$propertyName)

    {
        $reflection = new \ReflectionClass(get_class($object));
        $property = $reflection->getProperty($propertyName);
        $property->setAccessible(true);
        return $property->getValue($object);
    }
    /**
     * get Sales updated/created on the date passed
     * @param $date
     * @param $page
     * @param $pageSize
     * @param int $iteration
     *
     * @return array
     */
    private function getSales($date, $page, $pageSize, $iteration = 0)

    {
        $transactionList = array();
        try {
            $transactionList = $this->invokeProperty( $this, '_apiClient' )->getSales($date, 'modifiedDate', null, null, null, $page, $pageSize, $iteration);
        } catch (\Exception $e) {
            $iteration++;
            if ($iteration < 5) {
                $transactionList = self::getSales($date, $page, $pageSize, $iteration);
            }

        }
        return $transactionList;

    }
}

1		<?php
2		/**
3		* Copyright (c) Padosoft.com 2017.
4		*/
5
6
7		namespace Padosoft\AffiliateNetwork\Networks;
8		use Oara\Network\Publisher\Zanox;
		0 ignored issues – show Bug introduced 2017-01-23 10:14 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Padosoft\AffiliateNetwork\Networks\Zanox`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9
10		class ZanoxEx extends Zanox
11		{
12		/**
13		* Call protected/private method of a class.
14		*
15		* @param object &$object Instantiated object that we will run method on.
16		* @param string $methodName Method name to call
17		* @param array $parameters Array of parameters to pass into method.
18		*
19		* @return mixed Method return.
20		*/
21	View Code Duplication	public function invokeMethod(&$object,$methodName, array $parameters = array())
		0 ignored issues – show Duplication introduced 2017-01-23 10:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		$reflection = new \ReflectionClass(get_class($object));
24		$method = $reflection->getMethod($methodName);
25		$method->setAccessible(true);
26		return $method->invokeArgs($object, $parameters);
27		}
28
29		/**
30		* Call protected/private property of a class.
31		* @param $object
32		* @param $propertyName
33		*
34		* @return mixed
35		*/
36	View Code Duplication	public function invokeProperty(&$object,$propertyName)
		0 ignored issues – show Duplication introduced 2017-01-23 10:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$reflection = new \ReflectionClass(get_class($object));
39		$property = $reflection->getProperty($propertyName);
40		$property->setAccessible(true);
41		return $property->getValue($object);
42		}
43		/**
44		* get Sales updated/created on the date passed
45		* @param $date
46		* @param $page
47		* @param $pageSize
48		* @param int $iteration
49		*
50		* @return array
51		*/
52		private function getSales($date, $page, $pageSize, $iteration = 0)
		0 ignored issues – show Bug introduced 2017-01-23 10:14 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history... Unused Code introduced 2017-01-23 10:14 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
53		{
54		$transactionList = array();
55		try {
56		$transactionList = $this->invokeProperty( $this, '_apiClient' )->getSales($date, 'modifiedDate', null, null, null, $page, $pageSize, $iteration);
57		} catch (\Exception $e) {
58		$iteration++;
59		if ($iteration < 5) {
60		$transactionList = self::getSales($date, $page, $pageSize, $iteration);
61		}
62
63		}
64		return $transactionList;
65
66		}
67		}

padosoft / laravel-affiliate-network

Push — master ( f7fdc3...1fc303 )

ZanoxEx A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like