owncloud / security

lib/Hooks.php

Doc Comments -1 removed lines

@@ -81,7 +81,6 @@
 
     /**
      * @param string $uid
-     * @param Throttle $throttle
      */
     public function failedLoginCallback($uid) {
         $this->throttle->addFailedLoginAttempt($uid, $this->request->getRemoteAddress());

tests/PasswordValidatorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
 	}

 

 	/**

-	 * @param array $mockedMethods

+	 * @param string[] $mockedMethods

 	 * @return PasswordValidator | \PHPUnit_Framework_MockObject_MockObject

 	 */

 	private function getMockInstance($mockedMethods = []) {

tests/SecurityConfigTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 	}

 

 	/**

-	 * @param array $mockedMethods

+	 * @param string[] $mockedMethods

 	 * @return SecurityConfig | \PHPUnit_Framework_MockObject_MockObject

 	 */

 	private function getMockInstance($mockedMethods = []) {

templates/settings-admin.php

Braces +16 added lines, -4 removed lines

@@ -26,7 +26,10 @@ 
 <div id="brute-force-protection">

 	<div>

 		<input type="checkbox" class="checkbox" id="security-brute-force-protection-enabled"

-			<?php if ($_['isBruteForceProtectionEnabled']) p("checked");?> >

+			<?php if ($_['isBruteForceProtectionEnabled']) {
+    p("checked");
+}
+?> >

 		<label for="security-brute-force-protection-enabled"><?php p($l->t('Activate Brute Force Protection')) ?></label>

 	</div>

 </div>

@@ -41,17 +44,26 @@ 
 	</div>

 	<div>

 		<input type="checkbox" class="checkbox" id="security-enforce-upper-lower-case"

-			<?php if ($_['isUpperLowerCaseEnforced']) p("checked");?> >

+			<?php if ($_['isUpperLowerCaseEnforced']) {
+    p("checked");
+}
+?> >

 		<label for="security-enforce-upper-lower-case"><?php p($l->t('Enforce at least one upper and one lower case character on passwords')) ?></label>

 	</div>

 	<div>

 		<input type="checkbox" class="checkbox" id="security-enforce-numerical-characters"

-			<?php if ($_['isNumericalCharsEnforced']) p("checked");?> >

+			<?php if ($_['isNumericalCharsEnforced']) {
+    p("checked");
+}
+?> >

 		<label for="security-enforce-numerical-characters"><?php p($l->t('Enforce at least one numerical characters on passwords')) ?></label>

 	</div>

 	<div>

 		<input type="checkbox" class="checkbox" id="security-enforce-special-characters"

-			<?php if ($_['isSpecialCharsEnforced']) p("checked");?> >

+			<?php if ($_['isSpecialCharsEnforced']) {
+    p("checked");
+}
+?> >

 		<label for="security-enforce-special-characters"><?php p($l->t('Enforce at least one special characters on passwords')) ?></label>

 	</div>

 </div>
\ No newline at end of file

templates/settings-personal.php

Braces +15 added lines, -6 removed lines

@@ -29,11 +29,20 @@
 	<ul class="pass-info">

 		<?php print_unescaped(

 			"<li class='pass-info-element'>". $l->t('be at least 8 characters long ', $_['minPasswordLength']). "</li>");?>

-		<?php if ($_['isUpperLowerCaseEnforced']) print_unescaped(

-			"<li class='pass-info-element'>". $l->t('contain at least one uppercase letter and at least one lowercase letter '). "</li>");?>

-		<?php if ($_['isNumericalCharsEnforced']) print_unescaped(

-			"<li class='pass-info-element'>". $l->t('contain at least one numerical character'). "</li>");?>

-		<?php if ($_['isSpecialCharsEnforced']) print_unescaped(

-			"<li class='pass-info-element'>". $l->t('contain at least one special character'). "</li>");?>

+		<?php if ($_['isUpperLowerCaseEnforced']) {
+    print_unescaped(

+			"<li class='pass-info-element'>". $l->t('contain at least one uppercase letter and at least one lowercase letter '). "</li>");
+}
+?>

+		<?php if ($_['isNumericalCharsEnforced']) {
+    print_unescaped(

+			"<li class='pass-info-element'>". $l->t('contain at least one numerical character'). "</li>");
+}
+?>

+		<?php if ($_['isSpecialCharsEnforced']) {
+    print_unescaped(

+			"<li class='pass-info-element'>". $l->t('contain at least one special character'). "</li>");
+}
+?>

 	</ul>

 </div>