owncloud / security

tests/Controller/SettingsControllerTest.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -20,9 +20,9 @@
  */

 namespace OCA\Security\Tests\Controller;

 

-use OCA\Security\Controller\SettingsController;

-use OCA\Security\SecurityConfig;

-use OCP\IRequest;

+use OCA\Security\Controller\SettingsController;
+use OCA\Security\SecurityConfig;
+use OCP\IRequest;
 use Test\TestCase;

 

 class SettingsControllerTest extends TestCase {

tests/Db/DbServiceTest.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -22,9 +22,9 @@
 

 namespace OCA\Security\Tests\Db;

 

-use OCA\Security\Db\DbService;

-use OC\AppFramework\Utility\TimeFactory;

-use OCP\IDBConnection;

+use OCA\Security\Db\DbService;
+use OC\AppFramework\Utility\TimeFactory;
+use OCP\IDBConnection;
 use Test\TestCase;

 

 /**

tests/PasswordValidatorTest.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -19,10 +19,10 @@
  *

  */

 namespace OCA\Password_Policy\Tests;

-use OC\HintException;

-use OCA\Security\SecurityConfig;

-use OCA\Security\PasswordValidator;

-use OCP\IL10N;

+use OC\HintException;
+use OCA\Security\SecurityConfig;
+use OCA\Security\PasswordValidator;
+use OCP\IL10N;
 use Test\TestCase;

 class PasswordValidatorTest extends TestCase {

 

tests/SecurityConfigTest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -20,8 +20,8 @@
  */

 namespace OCA\Security\Tests;

 

-use OCA\Security\SecurityConfig;

-use OCP\IConfig;

+use OCA\Security\SecurityConfig;
+use OCP\IConfig;
 use Test\TestCase;

 class SecurityConfigTest extends TestCase {

 	/** @var  IConfig|\PHPUnit_Framework_MockObject_MockObject */

templates/settings-admin.php

Braces +16 added lines, -4 removed lines

@@ -26,7 +26,10 @@ 
 <div id="brute-force-protection">

 	<div>

 		<input type="checkbox" class="checkbox" id="security-brute-force-protection-enabled"

-			<?php if ($_['isBruteForceProtectionEnabled']) p("checked");?> >

+			<?php if ($_['isBruteForceProtectionEnabled']) {
+    p("checked");
+}
+?> >

 		<label for="security-brute-force-protection-enabled"><?php p($l->t('Activate Brute Force Protection')) ?></label>

 	</div>

 </div>

@@ -41,17 +44,26 @@ 
 	</div>

 	<div>

 		<input type="checkbox" class="checkbox" id="security-enforce-upper-lower-case"

-			<?php if ($_['isUpperLowerCaseEnforced']) p("checked");?> >

+			<?php if ($_['isUpperLowerCaseEnforced']) {
+    p("checked");
+}
+?> >

 		<label for="security-enforce-upper-lower-case"><?php p($l->t('Enforce at least one upper and one lower case character on passwords')) ?></label>

 	</div>

 	<div>

 		<input type="checkbox" class="checkbox" id="security-enforce-numerical-characters"

-			<?php if ($_['isNumericalCharsEnforced']) p("checked");?> >

+			<?php if ($_['isNumericalCharsEnforced']) {
+    p("checked");
+}
+?> >

 		<label for="security-enforce-numerical-characters"><?php p($l->t('Enforce at least one numerical characters on passwords')) ?></label>

 	</div>

 	<div>

 		<input type="checkbox" class="checkbox" id="security-enforce-special-characters"

-			<?php if ($_['isSpecialCharsEnforced']) p("checked");?> >

+			<?php if ($_['isSpecialCharsEnforced']) {
+    p("checked");
+}
+?> >

 		<label for="security-enforce-special-characters"><?php p($l->t('Enforce at least one special characters on passwords')) ?></label>

 	</div>

 </div>
\ No newline at end of file

templates/settings-personal.php

Braces +15 added lines, -6 removed lines

@@ -29,11 +29,20 @@
 	<ul class="pass-info">

 		<?php print_unescaped(

 			"<li class='pass-info-element'>". $l->t('be at least 8 characters long ', $_['minPasswordLength']). "</li>");?>

-		<?php if ($_['isUpperLowerCaseEnforced']) print_unescaped(

-			"<li class='pass-info-element'>". $l->t('contain at least one uppercase letter and at least one lowercase letter '). "</li>");?>

-		<?php if ($_['isNumericalCharsEnforced']) print_unescaped(

-			"<li class='pass-info-element'>". $l->t('contain at least one numerical character'). "</li>");?>

-		<?php if ($_['isSpecialCharsEnforced']) print_unescaped(

-			"<li class='pass-info-element'>". $l->t('contain at least one special character'). "</li>");?>

+		<?php if ($_['isUpperLowerCaseEnforced']) {
+    print_unescaped(

+			"<li class='pass-info-element'>". $l->t('contain at least one uppercase letter and at least one lowercase letter '). "</li>");
+}
+?>

+		<?php if ($_['isNumericalCharsEnforced']) {
+    print_unescaped(

+			"<li class='pass-info-element'>". $l->t('contain at least one numerical character'). "</li>");
+}
+?>

+		<?php if ($_['isSpecialCharsEnforced']) {
+    print_unescaped(

+			"<li class='pass-info-element'>". $l->t('contain at least one special character'). "</li>");
+}
+?>

 	</ul>

 </div>