owncloud / core

lib/private/Repair/RepairMismatchFileCachePath.php

Doc Comments +14 added lines, -1 removed lines

@@ -97,7 +97,7 @@ 
 	 * @param string $wrongPath wrong path of the entry to fix
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
 	 * @param string $correctPath value to which to set the path of the entry 
-	 * @return bool true for success
+	 * @return boolean|null true for success
 	 */
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
 		// delete target if exists
@@ -122,6 +122,9 @@ 
 		$out->advance(1, $text);
 	}
 
+	/**
+	 * @param IQueryBuilder $qb
+	 */
 	private function addQueryConditionsParentIdWrongPath($qb) {
 		// thanks, VicDeo!
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -161,6 +164,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IQueryBuilder $qb
+	 */
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
 		// Subquery for parent existence
 		$qbe = $this->connection->getQueryBuilder();
@@ -190,6 +196,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -200,6 +209,9 @@ 
 		return $count;
 	}
 
+	/**
+	 * @param integer $storageNumericId
+	 */
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
 		$qb = $this->connection->getQueryBuilder();
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -350,6 +362,7 @@ 
 	 *
 	 * @param int $storageId storage id
 	 * @param string $path path for which to create the parent entry
+	 * @param integer $reuseFileId
 	 * @return int file id of the newly created parent
 	 */
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 
 namespace OC\Repair;
 
-use Doctrine\DBAL\Platforms\PostgreSqlPlatform;
-use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\Migration\IOutput;
 use OCP\Migration\IRepairStep;
 use Doctrine\DBAL\Platforms\MySqlPlatform;

lib/private/Files/Storage/CacheableFlysystem.php

Doc Comments +3 added lines

@@ -50,6 +50,9 @@
 		return $location;
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public function buildPath($path) {
 		$location = parent::buildPath($path);
 		if ($this->isCaseInsensitiveStorage) {

lib/private/Files/Node/Root.php

Doc Comments +4 added lines, -1 removed lines

@@ -174,7 +174,7 @@ 
 	 * @param string $path
 	 * @throws \OCP\Files\NotFoundException
 	 * @throws \OCP\Files\NotPermittedException
-	 * @return string
+	 * @return \OCP\Files\Node
 	 */
 	public function get($path) {
 		$path = $this->normalizePath($path);
@@ -371,6 +371,9 @@ 
 
 	}
 
+	/**
+	 * @param string $fullPath
+	 */
 	private function resolveVirtualNode($fullPath) {
 		$pieces = explode('/', $fullPath);
 		if ($pieces[1] !== 'meta') {

apps/dav/lib/DAV/FileCustomPropertiesBackend.php

Doc Comments +1 added lines, -1 removed lines

@@ -204,7 +204,7 @@
 
 	/**
 	 * @param string $path
-	 * @return INode|null
+	 * @return null|Node
 	 */
 	protected function getNodeForPath($path){
 		$node = parent::getNodeForPath($path);

lib/private/Files/Storage/DAV.php

Unused Use Statements -1 removed lines

@@ -47,7 +47,6 @@
 use OCP\Files\StorageNotAvailableException;
 use OCP\Util;
 use Sabre\DAV\Xml\Property\ResourceType;
-use Sabre\HTTP\ClientException;
 use Sabre\HTTP\ClientHttpException;
 use Sabre\DAV\Exception\InsufficientStorage;
 use OCA\DAV\Connector\Sabre\Exception\Forbidden;

lib/private/DB/Adapter.php

Doc Comments +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
 
 	/**
 	 * @param string $table name
-	 * @return int id of last insert statement
+	 * @return string id of last insert statement
 	 */
 	public function lastInsertId($table) {
 		return $this->conn->realLastInsertId($table);
@@ -118,7 +118,7 @@ 
 
 	/**
 	 * Inserts, or updates a row into the database. Returns the inserted or updated rows
-	 * @param $table string table name including **PREFIX**
+	 * @param string $table string table name including **PREFIX**
 	 * @param $input array the key=>value pairs to insert into the db row
 	 * @param $compare array columns that should be compared to look for existing arrays
 	 * @return int the number of rows affected by the operation

lib/private/User/Session.php

Doc Comments +9 added lines, -3 removed lines

@@ -304,7 +304,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -347,6 +347,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -790,7 +793,7 @@ 
 	/**
 	 * logout the user from the session
 	 *
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function logout() {
 
@@ -871,6 +874,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		foreach ($this->getAuthModules(true) as $module) {
 			$user = $module->auth($request);
@@ -890,7 +896,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

lib/private/Files/Storage/Wrapper/Encryption.php

Doc Comments +4 added lines, -4 removed lines

@@ -672,7 +672,7 @@ 
 	 * Set the flag to true, so that the file would be
 	 * in the decrypted state.
 	 *
-	 * @param $isDisabled bool
+	 * @param boolean $isDisabled bool
 	 */
 	public static function setDisableWriteEncryption($isDisabled) {
 		self::$disableWriteEncryption = $isDisabled;
@@ -929,7 +929,7 @@ 
 	/**
 	 * return header size of given file
 	 *
-	 * @param string|resource $path
+	 * @param string $path
 	 * @return int
 	 */
 	protected function getHeaderSize($path) {
@@ -980,7 +980,7 @@ 
 	/**
 	 * read header from file
 	 *
-	 * @param string|resource $path
+	 * @param string $path
 	 * @return array
 	 */
 	protected function getHeader($path) {
@@ -1076,7 +1076,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

lib/private/AllConfig.php

Doc Comments +1 added lines, -1 removed lines

@@ -449,7 +449,7 @@
 	 * In some environments the system config file is readonly. Find out if this
 	 * is the case.
 	 *
-	 * @return boolean
+	 * @return false|string
 	 * @since 10.0.3
 	 */
 	public function isSystemConfigReadOnly() {