Completed
Pull Request — stable8.2 (#24916)
by Joas
11:35
created
lib/private/diagnostics/querylogger.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 	}
54 54
 
55 55
 	/**
56
-	 * @return \OCP\Diagnostics\IQuery[]
56
+	 * @return Query[]
57 57
 	 */
58 58
 	public function getQueries() {
59 59
 		return $this->queries;
Please login to merge, or discard this patch.
lib/private/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/files.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -159,6 +159,8 @@  discard block
 block discarded – undo
159 159
 	/**
160 160
 	 * @param View $view
161 161
 	 * @param string $name
162
+	 * @param string $dir
163
+	 * @param boolean $onlyHeader
162 164
 	 */
163 165
 	private static function getSingleFile($view, $dir, $name, $onlyHeader) {
164 166
 		$filename = $dir . '/' . $name;
@@ -184,7 +186,7 @@  discard block
 block discarded – undo
184 186
 
185 187
 	/**
186 188
 	 * @param View $view
187
-	 * @param $dir
189
+	 * @param string $dir
188 190
 	 * @param string[]|string $files
189 191
 	 */
190 192
 	public static function lockFiles($view, $dir, $files) {
@@ -289,11 +291,11 @@  discard block
 block discarded – undo
289 291
 	}
290 292
 
291 293
 	/**
292
-	 * @param $dir
294
+	 * @param string $dir
293 295
 	 * @param $files
294
-	 * @param $getType
296
+	 * @param integer $getType
295 297
 	 * @param View $view
296
-	 * @param $filename
298
+	 * @param string $filename
297 299
 	 */
298 300
 	private static function unlockAllTheFiles($dir, $files, $getType, $view, $filename) {
299 301
 		if ($getType === self::FILE) {
Please login to merge, or discard this patch.
lib/private/files/fileinfo.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@
 block discarded – undo
185 185
 	}
186 186
 
187 187
 	/**
188
-	 * @return \OCP\Files\FileInfo::TYPE_FILE|\OCP\Files\FileInfo::TYPE_FOLDER
188
+	 * @return string
189 189
 	 */
190 190
 	public function getType() {
191 191
 		if (!isset($this->data['type'])) {
Please login to merge, or discard this patch.
lib/private/files/filesystem.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,6 @@
 block discarded – undo
58 58
 
59 59
 namespace OC\Files;
60 60
 
61
-use OC\Cache\File;
62 61
 use OC\Files\Config\MountProviderCollection;
63 62
 use OC\Files\Storage\StorageFactory;
64 63
 use OCP\Files\Config\IMountProvider;
Please login to merge, or discard this patch.
Doc Comments   +53 added lines, -1 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 	/**
222 222
 	 * Returns the storage factory
223 223
 	 *
224
-	 * @return \OCP\Files\Storage\IStorageFactory
224
+	 * @return \OCP\Files\Storage\IStorageFactory|null
225 225
 	 */
226 226
 	public static function getLoader() {
227 227
 		if (!self::$loader) {
@@ -335,6 +335,9 @@  discard block
 block discarded – undo
335 335
 		}
336 336
 	}
337 337
 
338
+	/**
339
+	 * @param string $root
340
+	 */
338 341
 	static public function init($user, $root) {
339 342
 		if (self::$defaultInstance) {
340 343
 			return false;
@@ -623,11 +626,15 @@  discard block
 block discarded – undo
623 626
 
624 627
 	/**
625 628
 	 * following functions are equivalent to their php builtin equivalents for arguments/return values.
629
+	 * @param string $path
626 630
 	 */
627 631
 	static public function mkdir($path) {
628 632
 		return self::$defaultInstance->mkdir($path);
629 633
 	}
630 634
 
635
+	/**
636
+	 * @param string $path
637
+	 */
631 638
 	static public function rmdir($path) {
632 639
 		return self::$defaultInstance->rmdir($path);
633 640
 	}
@@ -644,6 +651,9 @@  discard block
 block discarded – undo
644 651
 		return self::$defaultInstance->is_dir($path);
645 652
 	}
646 653
 
654
+	/**
655
+	 * @param string $path
656
+	 */
647 657
 	static public function is_file($path) {
648 658
 		return self::$defaultInstance->is_file($path);
649 659
 	}
@@ -656,6 +666,9 @@  discard block
 block discarded – undo
656 666
 		return self::$defaultInstance->filetype($path);
657 667
 	}
658 668
 
669
+	/**
670
+	 * @param string $path
671
+	 */
659 672
 	static public function filesize($path) {
660 673
 		return self::$defaultInstance->filesize($path);
661 674
 	}
@@ -668,6 +681,9 @@  discard block
 block discarded – undo
668 681
 		return self::$defaultInstance->isCreatable($path);
669 682
 	}
670 683
 
684
+	/**
685
+	 * @param string $path
686
+	 */
671 687
 	static public function isReadable($path) {
672 688
 		return self::$defaultInstance->isReadable($path);
673 689
 	}
@@ -680,6 +696,9 @@  discard block
 block discarded – undo
680 696
 		return self::$defaultInstance->isDeletable($path);
681 697
 	}
682 698
 
699
+	/**
700
+	 * @param string $path
701
+	 */
683 702
 	static public function isSharable($path) {
684 703
 		return self::$defaultInstance->isSharable($path);
685 704
 	}
@@ -688,37 +707,64 @@  discard block
 block discarded – undo
688 707
 		return self::$defaultInstance->file_exists($path);
689 708
 	}
690 709
 
710
+	/**
711
+	 * @param string $path
712
+	 */
691 713
 	static public function filemtime($path) {
692 714
 		return self::$defaultInstance->filemtime($path);
693 715
 	}
694 716
 
717
+	/**
718
+	 * @param string $path
719
+	 * @param integer $mtime
720
+	 */
695 721
 	static public function touch($path, $mtime = null) {
696 722
 		return self::$defaultInstance->touch($path, $mtime);
697 723
 	}
698 724
 
699 725
 	/**
726
+	 * @param string $path
700 727
 	 * @return string
701 728
 	 */
702 729
 	static public function file_get_contents($path) {
703 730
 		return self::$defaultInstance->file_get_contents($path);
704 731
 	}
705 732
 
733
+	/**
734
+	 * @param string $path
735
+	 * @param string $data
736
+	 */
706 737
 	static public function file_put_contents($path, $data) {
707 738
 		return self::$defaultInstance->file_put_contents($path, $data);
708 739
 	}
709 740
 
741
+	/**
742
+	 * @param string $path
743
+	 */
710 744
 	static public function unlink($path) {
711 745
 		return self::$defaultInstance->unlink($path);
712 746
 	}
713 747
 
748
+	/**
749
+	 * @param string $path1
750
+	 * @param string $path2
751
+	 */
714 752
 	static public function rename($path1, $path2) {
715 753
 		return self::$defaultInstance->rename($path1, $path2);
716 754
 	}
717 755
 
756
+	/**
757
+	 * @param string $path1
758
+	 * @param string $path2
759
+	 */
718 760
 	static public function copy($path1, $path2) {
719 761
 		return self::$defaultInstance->copy($path1, $path2);
720 762
 	}
721 763
 
764
+	/**
765
+	 * @param string $path
766
+	 * @param string $mode
767
+	 */
722 768
 	static public function fopen($path, $mode) {
723 769
 		return self::$defaultInstance->fopen($path, $mode);
724 770
 	}
@@ -734,6 +780,9 @@  discard block
 block discarded – undo
734 780
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
735 781
 	}
736 782
 
783
+	/**
784
+	 * @param string $path
785
+	 */
737 786
 	static public function getMimeType($path) {
738 787
 		return self::$defaultInstance->getMimeType($path);
739 788
 	}
@@ -746,6 +795,9 @@  discard block
 block discarded – undo
746 795
 		return self::$defaultInstance->free_space($path);
747 796
 	}
748 797
 
798
+	/**
799
+	 * @param string $query
800
+	 */
749 801
 	static public function search($query) {
750 802
 		return self::$defaultInstance->search($query);
751 803
 	}
Please login to merge, or discard this patch.
lib/private/files/node/folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -195,7 +195,7 @@
 block discarded – undo
195 195
 	/**
196 196
 	 * search for files by tag
197 197
 	 *
198
-	 * @param string|int $tag name or tag id
198
+	 * @param string $tag name or tag id
199 199
 	 * @param string $userId owner of the tags
200 200
 	 * @return Node[]
201 201
 	 */
Please login to merge, or discard this patch.
lib/private/files/node/root.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
 	 * @param string $path
170 170
 	 * @throws \OCP\Files\NotFoundException
171 171
 	 * @throws \OCP\Files\NotPermittedException
172
-	 * @return \OCP\Files\Node
172
+	 * @return string
173 173
 	 */
174 174
 	public function get($path) {
175 175
 		$path = $this->normalizePath($path);
Please login to merge, or discard this patch.
lib/private/files/stream/dir.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -58,6 +58,7 @@
 block discarded – undo
58 58
 
59 59
 	/**
60 60
 	 * @param string $path
61
+	 * @param string[] $content
61 62
 	 */
62 63
 	public static function register($path, $content) {
63 64
 		self::$dirs[$path] = $content;
Please login to merge, or discard this patch.
lib/private/files/stream/encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
 	 *
176 176
 	 * @param resource $source
177 177
 	 * @param string $mode
178
-	 * @param array $context
178
+	 * @param resource $context
179 179
 	 * @param string $protocol
180 180
 	 * @param string $class
181 181
 	 * @return resource
Please login to merge, or discard this patch.