Completed
Pull Request — master (#26112)
by Thomas
12:39
created
lib/public/Template.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
 /**
101 101
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
102 102
  * @param int $timestamp unix timestamp
103
- * @param boolean $dateOnly
104
- * @return \OC_L10N_String human readable interpretation of the timestamp
103
+ * @param integer $dateOnly
104
+ * @return string human readable interpretation of the timestamp
105 105
  *
106 106
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
107 107
  */
Please login to merge, or discard this patch.
core/Controller/LostController.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,6 +145,7 @@  discard block
 block discarded – undo
145 145
 	/**
146 146
 	 * @param string $userId
147 147
 	 * @param string $userId
148
+	 * @param string $token
148 149
 	 * @throws \Exception
149 150
 	 */
150 151
 	private function checkPasswordResetToken($token, $userId) {
@@ -166,7 +167,7 @@  discard block
 block discarded – undo
166 167
 	}
167 168
 
168 169
 	/**
169
-	 * @param $message
170
+	 * @param string $message
170 171
 	 * @param array $additional
171 172
 	 * @return array
172 173
 	 */
Please login to merge, or discard this patch.
lib/public/SystemTag/ISystemTagManager.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch
@@ -102,17 +102,19 @@  discard block
 block discarded – undo
102 102
 	 * with the same attributes
103 103
 	 *
104 104
 	 * @since 9.0.0
105
+	 * @return void
105 106
 	 */
106 107
 	public function updateTag($tagId, $newName, $userVisible, $userAssignable);
107 108
 
108 109
 	/**
109 110
 	 * Delete the given tags from the database and all their relationships.
110 111
 	 *
111
-	 * @param string|array $tagIds array of tag ids
112
+	 * @param string $tagIds array of tag ids
112 113
 	 *
113 114
 	 * @throws \OCP\SystemTag\TagNotFoundException if at least one tag did not exist
114 115
 	 *
115 116
 	 * @since 9.0.0
117
+	 * @return void
116 118
 	 */
117 119
 	public function deleteTags($tagIds);
118 120
 
@@ -123,7 +125,7 @@  discard block
 block discarded – undo
123 125
 	 * @param ISystemTag $tag tag to check permission for
124 126
 	 * @param IUser $user user to check permission for
125 127
 	 *
126
-	 * @return true if the user is allowed to assign/unassign the tag, false otherwise
128
+	 * @return boolean if the user is allowed to assign/unassign the tag, false otherwise
127 129
 	 *
128 130
 	 * @since 9.1.0
129 131
 	 */
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 	 * Checks whether the given user is allowed to see the tag with the given id.
134 136
 	 *
135 137
 	 * @param ISystemTag $tag tag to check permission for
136
-	 * @param IUser $user user to check permission for
138
+	 * @param IUser $userId user to check permission for
137 139
 	 *
138
-	 * @return true if the user can see the tag, false otherwise
140
+	 * @return boolean if the user can see the tag, false otherwise
139 141
 	 *
140 142
 	 * @since 9.1.0
141 143
 	 */
@@ -148,6 +150,7 @@  discard block
 block discarded – undo
148 150
 	 * @param string[] $groupIds group ids of groups that can assign/unassign the tag
149 151
 	 *
150 152
 	 * @since 9.1.0
153
+	 * @return void
151 154
 	 */
152 155
 	public function setTagGroups(ISystemTag $tag, $groupIds);
153 156
 
Please login to merge, or discard this patch.
lib/private/Files/View.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 	 * and does not take the chroot into account )
198 198
 	 *
199 199
 	 * @param string $path
200
-	 * @return \OCP\Files\Mount\IMountPoint
200
+	 * @return Mount\MountPoint|null
201 201
 	 */
202 202
 	public function getMount($path) {
203 203
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -960,7 +960,7 @@  discard block
 block discarded – undo
960 960
 
961 961
 	/**
962 962
 	 * @param string $path
963
-	 * @return bool|string
963
+	 * @return string|false
964 964
 	 * @throws \OCP\Files\InvalidPathException
965 965
 	 */
966 966
 	public function toTmpFile($path) {
@@ -1075,7 +1075,7 @@  discard block
 block discarded – undo
1075 1075
 	 * @param string $path
1076 1076
 	 * @param array $hooks (optional)
1077 1077
 	 * @param mixed $extraParam (optional)
1078
-	 * @return mixed
1078
+	 * @return string
1079 1079
 	 * @throws \Exception
1080 1080
 	 *
1081 1081
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing
@@ -2083,7 +2083,7 @@  discard block
 block discarded – undo
2083 2083
 
2084 2084
 	/**
2085 2085
 	 * @param string $filename
2086
-	 * @return array
2086
+	 * @return string[]
2087 2087
 	 * @throws \OC\User\NoUserException
2088 2088
 	 * @throws NotFoundException
2089 2089
 	 */
Please login to merge, or discard this patch.
apps/testing/locking/provisioning.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @return int
71
+	 * @return string
72 72
 	 */
73 73
 	static private function getRefreshInterval() {
74 74
 		//defaults to every hour
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 use OC\Files\Filesystem;
26 26
 use OC\Files\View;
27
-use OC\Lock\MemcacheLockingProvider;
28 27
 use OCP\Lock\ILockingProvider;
29 28
 
30 29
 class Locking extends TestCase {
Please login to merge, or discard this patch.
core/Controller/TokenController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 	/**
53 53
 	 * @param string $appName
54 54
 	 * @param IRequest $request
55
-	 * @param Manager $userManager
55
+	 * @param UserManager $userManager
56 56
 	 * @param DefaultTokenProvider $tokenProvider
57 57
 	 * @param ISecureRandom $secureRandom
58 58
 	 */
Please login to merge, or discard this patch.
apps/files_external/lib/Lib/Storage/Google.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -213,7 +213,7 @@
 block discarded – undo
213 213
 	 *
214 214
 	 * @param \Google_Service_Drive_DriveFile
215 215
 	 *
216
-	 * @return true if the file is a Google Doc file, false otherwise
216
+	 * @return boolean if the file is a Google Doc file, false otherwise
217 217
 	 */
218 218
 	private function isGoogleDocFile($file) {
219 219
 		return $this->getGoogleDocExtension($file->getMimeType()) !== '';
Please login to merge, or discard this patch.
lib/private/Repair/RemoveOldShares.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 	/**
21 21
 	 * RemoveOldCalendarShares constructor.
22 22
 	 *
23
-	 * @param IDBConnection $db
24 23
 	 */
25 24
 	public function __construct(IDBConnection $connection) {
26 25
 		$this->connection = $connection;
Please login to merge, or discard this patch.
apps/files_sharing/lib/Helper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -278,6 +278,7 @@
 block discarded – undo
278 278
 	 * get default share folder
279 279
 	 *
280 280
 	 * @param \OC\Files\View
281
+	 * @param View $view
281 282
 	 * @return string
282 283
 	 */
283 284
 	public static function getShareFolder($view = null) {
Please login to merge, or discard this patch.