Completed
Pull Request — master (#31547)
by Jörn Friedrich
47:11 queued 30:29
created
apps/dav/lib/Files/ZsyncPlugin.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -21,8 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Files;
22 22
 
23 23
 use OC\AppFramework\Http;
24
-use OCP\Files\NotFoundException;
25
-use OCP\Files\NotPermittedException;
26 24
 use Sabre\DAV\Server;
27 25
 use Sabre\DAV\ServerPlugin;
28 26
 use Sabre\DAV\PropFind;
Please login to merge, or discard this patch.
lib/private/User/Manager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -432,6 +432,9 @@
 block discarded – undo
432 432
 		}, $accounts);
433 433
 	}
434 434
 
435
+	/**
436
+	 * @param string $backendClass
437
+	 */
435 438
 	public function getBackend($backendClass) {
436 439
 		if (isset($this->backends[$backendClass])) {
437 440
 			return $this->backends[$backendClass];
Please login to merge, or discard this patch.
apps/files_trashbin/lib/Trashbin.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -218,6 +218,9 @@  discard block
 block discarded – undo
218 218
 
219 219
 	/**
220 220
 	 *
221
+	 * @param string $targetFilename
222
+	 * @param string $targetLocation
223
+	 * @param integer $timestamp
221 224
 	 */
222 225
 	public static function insertTrashEntry($user, $targetFilename, $targetLocation, $timestamp) {
223 226
 		$query = \OC_DB::prepare("INSERT INTO `*PREFIX*files_trash` (`id`,`timestamp`,`location`,`user`) VALUES (?,?,?,?)");
@@ -330,6 +333,7 @@  discard block
 block discarded – undo
330 333
 	 * @param string $ownerPath path relative to the owner's home storage
331 334
 	 * @param integer $timestamp when the file was deleted
332 335
 	 * @param bool $forceCopy true to only make a copy of the versions into the trashbin
336
+	 * @param \OC\Files\Storage\Storage $sourceStorage
333 337
 	 */
334 338
 	private static function retainVersions($filename, $owner, $ownerPath, $timestamp, $sourceStorage = null, $forceCopy = false) {
335 339
 		if (\OCP\App::isEnabled('files_versions') && !empty($ownerPath)) {
@@ -780,7 +784,7 @@  discard block
 block discarded – undo
780 784
 	 * if the size limit for the trash bin is reached, we delete the oldest
781 785
 	 * files in the trash bin until we meet the limit again
782 786
 	 *
783
-	 * @param array $files
787
+	 * @param \OCP\Files\FileInfo[] $files
784 788
 	 * @param string $user
785 789
 	 * @param int $availableSpace available disc space
786 790
 	 * @return int size of deleted files
@@ -808,7 +812,7 @@  discard block
 block discarded – undo
808 812
 	/**
809 813
 	 * delete files older then max storage time
810 814
 	 *
811
-	 * @param array $files list of files sorted by mtime
815
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
812 816
 	 * @param string $user
813 817
 	 * @return integer[] size of deleted files and number of deleted files
814 818
 	 */
@@ -878,6 +882,7 @@  discard block
 block discarded – undo
878 882
 	 *
879 883
 	 * @param string $filename name of the file which should be restored
880 884
 	 * @param int $timestamp timestamp when the file was deleted
885
+	 * @param string|boolean $user
881 886
 	 * @return array
882 887
 	 */
883 888
 	private static function getVersionsFromTrash($filename, $timestamp, $user) {
Please login to merge, or discard this patch.
lib/private/Share/Share.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2870,7 +2870,7 @@
 block discarded – undo
2870 2870
 	}
2871 2871
 
2872 2872
 	/**
2873
-	 * @param $user
2873
+	 * @param string|boolean $user
2874 2874
 	 * @return Group[]
2875 2875
 	 */
2876 2876
 	private static function getGroupsForUser($user) {
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -219,7 +219,8 @@  discard block
 block discarded – undo
219 219
 	}
220 220
 
221 221
 	/**
222
-	 * @param $addressBookUri
222
+	 * @param string $addressBookUri
223
+	 * @param string $principal
223 224
 	 * @return array|null
224 225
 	 */
225 226
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -909,6 +910,7 @@  discard block
 block discarded – undo
909 910
 	 *   * readOnly - boolean
910 911
 	 *   * summary - Optional, a description for the share
911 912
 	 *
913
+	 * @param integer $addressBookId
912 914
 	 * @return array
913 915
 	 */
914 916
 	public function getShares($addressBookId) {
@@ -1013,7 +1015,7 @@  discard block
 block discarded – undo
1013 1015
 
1014 1016
 	/**
1015 1017
 	 * For shared address books the sharee is set in the ACL of the address book
1016
-	 * @param $addressBookId
1018
+	 * @param integer $addressBookId
1017 1019
 	 * @param $acl
1018 1020
 	 * @return array
1019 1021
 	 */
@@ -1021,6 +1023,9 @@  discard block
 block discarded – undo
1021 1023
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
1022 1024
 	}
1023 1025
 
1026
+	/**
1027
+	 * @param boolean $toV2
1028
+	 */
1024 1029
 	private function convertPrincipal($principalUri, $toV2 = null) {
1025 1030
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
1026 1031
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
lib/private/L10N/L10N.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	/**
71 71
 	 * Translating
72 72
 	 * @param string $text The text we need a translation for
73
-	 * @param array $parameters default:array() Parameters for sprintf
73
+	 * @param string[] $parameters default:array() Parameters for sprintf
74 74
 	 * @return string Translation or the same text
75 75
 	 *
76 76
 	 * Returns the translation. If no translation is found, $text will be
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 * Returns an associative array with all translations
173 173
 	 *
174 174
 	 * Called by String
175
-	 * @return array
175
+	 * @return string[]
176 176
 	 */
177 177
 	public function getTranslations() {
178 178
 		return $this->translations;
Please login to merge, or discard this patch.
apps/dav/lib/Server.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@
 block discarded – undo
278 278
 	}
279 279
 
280 280
 	/**
281
-	 * @param string[] $subTree
281
+	 * @param string[] $subTrees
282 282
 	 * @return bool
283 283
 	 */
284 284
 	private function isRequestForSubtree(array $subTrees) {
Please login to merge, or discard this patch.
apps/files/lib/Command/Scan.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -311,6 +311,11 @@
 block discarded – undo
311 311
 		}
312 312
 	}
313 313
 
314
+	/**
315
+	 * @param InputInterface $input
316
+	 * @param OutputInterface $output
317
+	 * @param boolean $shouldRepairStoragesIndividually
318
+	 */
314 319
 	protected function processUserChunks($input, $output, $users, $inputPath, $shouldRepairStoragesIndividually, $group = null) {
315 320
 		# no messaging level option means: no full printout but statistics
316 321
 		# $quiet   means no print at all
Please login to merge, or discard this patch.
lib/private/Repair/RepairSubShares.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 namespace OC\Repair;
23 23
 
24 24
 use OCP\DB\QueryBuilder\IQueryBuilder;
25
-use OCP\IConfig;
26 25
 use OCP\IDBConnection;
27 26
 use OCP\Migration\IOutput;
28 27
 use OCP\Migration\IRepairStep;
Please login to merge, or discard this patch.