Completed
Pull Request — master (#23349)
by Lukas
14:26
created
apps/dav/lib/carddav/carddavbackend.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -817,6 +817,7 @@  discard block
 block discarded – undo
817 817
 	 *   * readOnly - boolean
818 818
 	 *   * summary - Optional, a description for the share
819 819
 	 *
820
+	 * @param integer $addressBookId
820 821
 	 * @return array
821 822
 	 */
822 823
 	public function getShares($addressBookId) {
@@ -922,6 +923,9 @@  discard block
 block discarded – undo
922 923
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
923 924
 	}
924 925
 
926
+	/**
927
+	 * @param boolean $toV2
928
+	 */
925 929
 	private function convertPrincipal($principalUri, $toV2) {
926 930
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
927 931
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.
apps/federatedfilesharing/lib/federatedshareprovider.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -463,7 +463,7 @@
 block discarded – undo
463 463
 	/**
464 464
 	 * get database row of a give share
465 465
 	 *
466
-	 * @param $id
466
+	 * @param integer $id
467 467
 	 * @return array
468 468
 	 * @throws ShareNotFound
469 469
 	 */
Please login to merge, or discard this patch.
apps/files_external/command/backends.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -22,18 +22,12 @@
 block discarded – undo
22 22
 namespace OCA\Files_External\Command;
23 23
 
24 24
 use OC\Core\Command\Base;
25
-use OCA\Files_External\Lib\Auth\AuthMechanism;
26 25
 use OCA\Files_External\Lib\Backend\Backend;
27 26
 use OCA\Files_External\Lib\DefinitionParameter;
28 27
 use OCA\Files_External\Service\BackendService;
29 28
 use Symfony\Component\Console\Command\Command;
30
-use Symfony\Component\Console\Helper\Table;
31
-use Symfony\Component\Console\Helper\TableHelper;
32
-use Symfony\Component\Console\Input\ArrayInput;
33 29
 use Symfony\Component\Console\Input\InputArgument;
34 30
 use Symfony\Component\Console\Input\InputInterface;
35
-use Symfony\Component\Console\Input\InputOption;
36
-use Symfony\Component\Console\Input\Input;
37 31
 use Symfony\Component\Console\Output\OutputInterface;
38 32
 
39 33
 class Backends extends Base {
Please login to merge, or discard this patch.
apps/files_external/command/create.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -30,18 +30,14 @@
 block discarded – undo
30 30
 use OCA\Files_external\Lib\StorageConfig;
31 31
 use OCA\Files_External\Service\BackendService;
32 32
 use OCA\Files_external\Service\GlobalStoragesService;
33
-use OCA\Files_external\Service\ImportLegacyStoragesService;
34 33
 use OCA\Files_external\Service\UserStoragesService;
35 34
 use OCP\IUserManager;
36 35
 use OCP\IUserSession;
37 36
 use Symfony\Component\Console\Command\Command;
38
-use Symfony\Component\Console\Helper\Table;
39
-use Symfony\Component\Console\Helper\TableHelper;
40 37
 use Symfony\Component\Console\Input\ArrayInput;
41 38
 use Symfony\Component\Console\Input\InputArgument;
42 39
 use Symfony\Component\Console\Input\InputInterface;
43 40
 use Symfony\Component\Console\Input\InputOption;
44
-use Symfony\Component\Console\Input\Input;
45 41
 use Symfony\Component\Console\Output\OutputInterface;
46 42
 
47 43
 class Create extends Base {
Please login to merge, or discard this patch.
apps/files_external/command/verify.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -28,8 +28,6 @@
 block discarded – undo
28 28
 use OCP\IGroupManager;
29 29
 use OCP\IUserManager;
30 30
 use Symfony\Component\Console\Command\Command;
31
-use Symfony\Component\Console\Helper\Table;
32
-use Symfony\Component\Console\Helper\TableHelper;
33 31
 use Symfony\Component\Console\Input\InputArgument;
34 32
 use Symfony\Component\Console\Input\InputInterface;
35 33
 use Symfony\Component\Console\Input\InputOption;
Please login to merge, or discard this patch.
apps/dav/lib/connector/sabre/checksumlist.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 namespace OCA\DAV\Connector\Sabre;
22 22
 
23 23
 use Sabre\Xml\XmlSerializable;
24
-use Sabre\Xml\Element;
25 24
 use Sabre\Xml\Writer;
26 25
 
27 26
 /**
Please login to merge, or discard this patch.
lib/private/user/user.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
 	/**
333 333
 	 * get the users email address
334 334
 	 *
335
-	 * @return string|null
335
+	 * @return string
336 336
 	 * @since 9.0.0
337 337
 	 */
338 338
 	public function getEMailAddress() {
@@ -417,6 +417,10 @@  discard block
 block discarded – undo
417 417
 		return $url;
418 418
 	}
419 419
 
420
+	/**
421
+	 * @param string $feature
422
+	 * @param string $value
423
+	 */
420 424
 	public function triggerChange($feature, $value = null) {
421 425
 		if ($this->emitter) {
422 426
 			$this->emitter->emit('\OC\User', 'changeUser', array($this, $feature, $value));
Please login to merge, or discard this patch.
lib/public/app/managerevent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	 * DispatcherEvent constructor.
47 47
 	 *
48 48
 	 * @param string $event
49
-	 * @param $appID
49
+	 * @param string $appID
50 50
 	 * @param \OCP\IGroup[] $groups
51 51
 	 * @since 9.0.0
52 52
 	 */
Please login to merge, or discard this patch.
apps/encryption/lib/crypto/encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -370,7 +370,7 @@
 block discarded – undo
370 370
 	 * @param string $path path to the file which should be updated
371 371
 	 * @param string $uid of the user who performs the operation
372 372
 	 * @param array $accessList who has access to the file contains the key 'users' and 'public'
373
-	 * @return boolean
373
+	 * @return null|boolean
374 374
 	 */
375 375
 	public function update($path, $uid, array $accessList) {
376 376
 
Please login to merge, or discard this patch.