owncloud / core

apps/dav/lib/SystemTag/SystemTagsObjectMappingCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
 	 *
 	 * @param ISystemTag $tag
 	 *
-	 * @return SystemTagNode
+	 * @return SystemTagMappingNode
 	 */
 	private function makeNode(ISystemTag $tag) {
 		return new SystemTagMappingNode(

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 use Sabre\DAV\Exception\BadRequest;
 use Sabre\DAV\Exception\PreconditionFailed;
 use Sabre\DAV\ICollection;
-
 use OCP\SystemTag\ISystemTagManager;
 use OCP\SystemTag\ISystemTagObjectMapper;
 use OCP\SystemTag\ISystemTag;

lib/private/App/CodeChecker/CodeChecker.php

Unused Use Statements -2 removed lines

@@ -25,8 +25,6 @@
 
 use OC\Hooks\BasicEmitter;
 use PhpParser\Lexer;
-use PhpParser\Node;
-use PhpParser\Node\Name;
 use PhpParser\NodeTraverser;
 use PhpParser\Parser;
 use RecursiveCallbackFilterIterator;

lib/private/Console/TimestampFormatter.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 	 * Checks if output formatter has style with specified name.
 	 *
 	 * @param string $name
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function hasStyle($name) {
 		$this->formatter->hasStyle($name);

lib/private/DB/Connection.php

Doc Comments +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
 	 * If an SQLLogger is configured, the execution is logged.
 	 *
 	 * @param string                                      $query  The SQL query to execute.
-	 * @param array                                       $params The parameters to bind to the query, if any.
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
 	 * @param array                                       $types  The types the previous parameters are in.
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
 	 *

Unused Use Statements -2 removed lines

@@ -34,14 +34,12 @@
 use Doctrine\DBAL\Cache\QueryCacheProfile;
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
-use Doctrine\DBAL\Exception\ConstraintViolationException;
 use Doctrine\DBAL\Platforms\MySqlPlatform;
 use Doctrine\DBAL\Schema\Schema;
 use OC\DB\QueryBuilder\QueryBuilder;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\IDBConnection;
 use OCP\PreConditionNotMetException;
-use OCP\Util;
 
 class Connection extends \Doctrine\DBAL\Connection implements IDBConnection {
 	/**

lib/private/Files/View.php

Doc Comments +3 added lines, -3 removed lines

@@ -201,7 +201,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -1082,7 +1082,7 @@ 
 	 * @param string $path
 	 * @param array $hooks (optional)
 	 * @param mixed $extraParam (optional)
-	 * @return mixed
+	 * @return string
 	 * @throws \Exception
 	 *
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing
@@ -2090,7 +2090,7 @@ 
 
 	/**
 	 * @param string $filename
-	 * @return array
+	 * @return string[]
 	 * @throws \OC\User\NoUserException
 	 * @throws NotFoundException
 	 */

lib/private/legacy/template/functions.php

Doc Comments +1 added lines

@@ -191,6 +191,7 @@
 
 /**
  * @param string $path
+ * @param string $token
  */
 function publicPreview_icon ( $path, $token ) {
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);

apps/federatedfilesharing/lib/RequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -566,7 +566,7 @@
 	/**
 	 * update permissions in database
 	 *
-	 * @param IShare $share
+	 * @param Share\IShare $share
 	 * @param int $permissions
 	 */
 	protected function updatePermissionsInDatabase(IShare $share, $permissions) {

lib/private/legacy/db.php

Doc Comments -1 removed lines

@@ -150,7 +150,6 @@
 	/**
 	 * saves database schema to xml file
 	 * @param string $file name of file
-	 * @param int $mode
 	 * @return bool
 	 *
 	 * TODO: write more documentation

lib/private/Files/Config/LazyStorageMountInfo.php

Unused Use Statements -3 removed lines

@@ -21,10 +21,7 @@
 
 namespace OC\Files\Config;
 
-use OC\Files\Filesystem;
-use OCP\Files\Config\ICachedMountInfo;
 use OCP\Files\Mount\IMountPoint;
-use OCP\Files\Node;
 use OCP\IUser;
 
 class LazyStorageMountInfo extends CachedMountInfo {