ONGR\ElasticsearchBundle\Result\ObjectIterator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	85
Duplicated Lines	31.76 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	4
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
A	convertDocument()	0	8	1
A	current()	14	14	3
A	offsetGet()	13	13	3

<?php

/*
 * This file is part of the ONGR package.
 *
 * (c) NFQ Technologies UAB <info@nfq.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ONGR\ElasticsearchBundle\Result;

use ONGR\ElasticsearchBundle\Collection\Collection;

/**
 * ObjectIterator class.
 */
class ObjectIterator extends Collection
{
    /**
     * @var Converter
     */
    private $converter;

    /**
     * @var array Aliases information.
     */
    private $alias;

    /**
     * @var array
     */
    private $rawObjects;

    /**
     * Using part of abstract iterator functionality only.
     *
     * @param Converter $converter
     * @param array     $objects
     * @param array     $alias
     */
    public function __construct($converter, $objects, $alias)
    {
        $this->converter = $converter;
        $this->rawObjects = $objects;
        $this->alias = $alias;

        $callback = function ($v) {

The parameter $v is not used and could be removed.

            return null;
        };

        // Pass array with available keys and no values
        parent::__construct(array_map($callback, $objects));
    }

    /**
     * {@inheritdoc}
     */
    protected function convertDocument(array $document)
    {
        return $this->converter->assignArrayToObject(
            $document,
            new $this->alias['namespace'](),
            $this->alias['aliases']
        );
    }

    /**
     * {@inheritdoc}
     */
    public function current()

This method seems to be duplicated in your project.

    {
        $value = parent::current();

        // Generate objects on demand
        if ($value === null && $this->valid()) {
            $key = $this->key();
            $value = $this->convertDocument($this->rawObjects[$key]);
            $this->rawObjects[$key] = null;
            $this->offsetSet($key, $value);
        }

        return $value;
    }

    /**
     * {@inheritdoc}
     */
    public function offsetGet($offset)

This method seems to be duplicated in your project.

    {
        $value = parent::offsetGet($offset);

        // Generate objects on demand
        if ($value === null && $this->valid()) {
            $value = $this->convertDocument($this->rawObjects[$offset]);
            $this->rawObjects[$offset] = null;
            $this->offsetSet($offset, $value);
        }

        return $value;
    }
}